Home » Mailing list archives » linux-kernel » 2008 » May » 27

Re: [PATCH] video4linux: Push down the BKL

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jonathan Corbet
Subject: Re: [PATCH] video4linux: Push down the BKL
Date: Tuesday, May 27, 2008 - 9:37 am

On Tue, 27 May 2008 13:31:00 -0300
Mauro Carvalho Chehab <mchehab@infradead.org> wrote:


In fact, 2.6.26 and prior kernels *do* acquire the BKL on open (for
char devices) - that's the behavior that the bkl-removal tree is there
to do away with.  So, for example, I've pushed that acquisition down
into video_open() instead. 

So, for now, open() is serialized against ioctl() in video drivers.  As
soon as you take the BKL out of ioctl(), though, that won't happen,
unless the mutex you use is also acquired in the open path.

jon
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] video4linux: Push down the BKL, Alan Cox, (Thu May 22, 2:37 pm)
Re: [PATCH] video4linux: Push down the BKL, Andy Walls, (Thu May 22, 7:08 pm)
Re: [PATCH] video4linux: Push down the BKL, Hans Verkuil, (Thu May 22, 11:16 pm)
Re: [PATCH] video4linux: Push down the BKL, Hans Verkuil, (Thu May 22, 11:28 pm)
Re: [PATCH] video4linux: Push down the BKL, Alan Cox, (Fri May 23, 2:09 am)
Re: [PATCH] video4linux: Push down the BKL , Jonathan Corbet, (Fri May 23, 6:56 am)
Re: [PATCH] video4linux: Push down the BKL, Alan Cox, (Fri May 23, 8:39 am)
Re: [PATCH] video4linux: Push down the BKL , Jonathan Corbet, (Fri May 23, 9:09 am)
Re: [PATCH] video4linux: Push down the BKL, Alan Cox, (Fri May 23, 11:58 am)
Re: [PATCH] video4linux: Push down the BKL, Hans Verkuil, (Fri May 23, 12:05 pm)
Re: [PATCH] video4linux: Push down the BKL, Mike Isely, (Sun May 25, 4:46 pm)
Re: [PATCH] video4linux: Push down the BKL, Mauro Carvalho Chehab, (Mon May 26, 9:34 am)
Re: [PATCH] video4linux: Push down the BKL, Mauro Carvalho Chehab, (Mon May 26, 9:39 am)
Re: [PATCH] video4linux: Push down the BKL, Hans Verkuil, (Mon May 26, 9:46 am)
Re: [PATCH] video4linux: Push down the BKL, Mauro Carvalho Chehab, (Mon May 26, 9:59 am)
Re: [PATCH] video4linux: Push down the BKL, Alan Cox, (Mon May 26, 1:23 pm)
Re: [PATCH] video4linux: Push down the BKL, Mauro Carvalho Chehab, (Mon May 26, 2:10 pm)
Re: [PATCH] video4linux: Push down the BKL, Mauro Carvalho Chehab, (Mon May 26, 2:14 pm)
Re: [PATCH] video4linux: Push down the BKL, Alan Cox, (Mon May 26, 3:01 pm)
Re: [PATCH] video4linux: Push down the BKL, Mauro Carvalho Chehab, (Tue May 27, 6:10 am)
Re: [PATCH] video4linux: Push down the BKL, Jonathan Corbet, (Tue May 27, 8:41 am)
Re: [PATCH] video4linux: Push down the BKL, Mauro Carvalho Chehab, (Tue May 27, 9:31 am)
Re: [PATCH] video4linux: Push down the BKL, Jonathan Corbet, (Tue May 27, 9:37 am)
Re: [PATCH] video4linux: Push down the BKL, Alan Cox, (Tue May 27, 11:14 am)
Re: [PATCH] video4linux: Push down the BKL, Mauro Carvalho Chehab, (Tue May 27, 11:59 am)
Re: [PATCH] video4linux: Push down the BKL, Devin Heitmueller, (Tue May 27, 12:26 pm)
Re: [PATCH] video4linux: Push down the BKL, Arjan van de Ven, (Tue May 27, 12:50 pm)
Re: [PATCH] video4linux: Push down the BKL, Mauro Carvalho Chehab, (Tue May 27, 1:24 pm)
Re: [PATCH] video4linux: Push down the BKL, Mauro Carvalho Chehab, (Tue May 27, 2:00 pm)
Re: [PATCH] video4linux: Push down the BKL, Devin Heitmueller, (Tue May 27, 2:22 pm)
Re: [PATCH] video4linux: Push down the BKL, Andy Walls, (Tue May 27, 4:48 pm)
Re: [PATCH] video4linux: Push down the BKL, Devin Heitmueller, (Tue May 27, 5:46 pm)
Re: [PATCH] video4linux: Push down the BKL, Andy Walls, (Tue May 27, 7:37 pm)
Re: [PATCH] video4linux: Push down the BKL, Devin Heitmueller, (Tue May 27, 7:47 pm)
Re: [PATCH] video4linux: Push down the BKL, Hans Verkuil, (Tue May 27, 11:13 pm)
Re: [PATCH] video4linux: Push down the BKL, Alan Cox, (Wed May 28, 1:34 am)