Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Marcel Holtmann <marcel@...>
Cc: Johannes Berg <johannes@...>, David Woodhouse <dwmw2@...>, Sam Ravnborg <sam@...>, <linux-kernel@...>, <alan@...>, Abhay Salunke <Abhay_Salunke@...>, <kay.sievers@...>, Takashi Iwai <tiwai@...>, Michael Buesch <mb@...>
Date: Sunday, May 25, 2008 - 1:17 pm

On May 25, 2008, Marcel Holtmann <marcel@holtmann.org> wrote:


You're contradicting yourself.  Is it a filename, or is it not?
Earlier, you said it wasn't, it was just a name that userspace was
supposed to map to a filename.  Now, you're saying it is a filename.

Clearly (to me) your wish to prohibit '/'s in the firmware name has to
do with an attempt to force a distiction, to make the firmware a
filename rather than a pathname.  But, as you said yourself, the
mapping from firmware name is supposed to be entirely handled in
userland, therefore it doesn't even begin to make sense to distinguish
between filenames and pathnames.  You'd have to make assumptions that
(i) the firmware name names files (with built-in firmware, it
doesn't), and, if it is about filenames, (ii) what the pathname
separator character is.  Should '\\' be ruled out as well, because
someone might want /lib/firmware to be in a FAT filesystem?

nWouldn't it be better to leave the resolution of firmware names to
content *entirely* up to userland?  Say, if userland wants to
implement something very similar to the key-to-data map in-kernel
built-in firmware, this would work just fine, without any artificial
constraints?

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}
FSFLA Board Member       ¡Sé Libre! => http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 1/3] firmware: allow firmware files to be built i..., Lennart Sorensen, (Fri May 23, 12:38 pm)
[PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Fri May 23, 9:46 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sat May 24, 10:46 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sat May 24, 11:25 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sat May 24, 11:34 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sat May 24, 2:18 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 7:49 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Alexandre Oliva, (Sun May 25, 1:17 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 2:49 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Alexandre Oliva, (Sun May 25, 11:30 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Alexandre Oliva, (Sun May 25, 11:13 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Alexandre Oliva, (Mon May 26, 1:09 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 3:01 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 9:19 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 2:15 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 2:34 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 2:23 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 2:46 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 3:03 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sun May 25, 10:18 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 9:12 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 2:12 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 2:28 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 7:54 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sun May 25, 9:46 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 2:07 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sat May 24, 3:23 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sat May 24, 3:31 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Fri May 23, 2:07 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Fri May 23, 1:13 pm)