Home » Mailing list archives » linux-kernel » 2008 » May » 25

[PATCH]scsi: check the return value of device_create_file() in powertec.c

Previous thread: Bad black-lists in use by list recipients... by Matti Aarnio on Sunday, May 25, 2008 - 8:44 am. (1 message)

Next thread: POHMELFS high performance network filesystem. Cache coherency, transactions, parallels. by Evgeniy Polyakov on Sunday, May 25, 2008 - 9:40 am. (13 messages)
[view original message]
From: Qinghuang Feng <s3c24xx@...>
To: <rmk@...>
Cc: <linux-arm-kernel@...>, <linux-kernel@...>
Subject: [PATCH]scsi: check the return value of device_create_file() in powertec.c
Date: Sunday, May 25, 2008 - 9:18 am

This patch adds code to check the return value of device_create_file() called from powertecscsi_probe() in powertec.c 


Signed-off-by: Qinghuang Feng <s3c24xx@gmail.com>

---

diff --git a/drivers/scsi/arm/powertec.c b/drivers/scsi/arm/powertec.c

index d9a546d..d695a6d 100644

--- a/drivers/scsi/arm/powertec.c

+++ b/drivers/scsi/arm/powertec.c

@@ -361,7 +361,9 @@ powertecscsi_probe(struct expansion_card


 	ecard_setirq(ec, &powertecscsi_ops, info);


-	device_create_file(&ec->dev, &dev_attr_bus_term);

+	ret = device_create_file(&ec->dev, &dev_attr_bus_term);

+	if (ret)

+		goto out_put;


 	ret = fas216_init(host);

 	if (ret)

@@ -399,6 +401,8 @@ powertecscsi_probe(struct expansion_card


  out_free:

 	device_remove_file(&ec->dev, &dev_attr_bus_term);

+

+ out_put:

 	scsi_host_put(host);


  out_region:


--
[view original message]
From: Russell King - ARM Linux <linux@...>
To: Qinghuang Feng <s3c24xx@...>
Cc: <linux-arm-kernel@...>, <linux-kernel@...>
Subject: Re: [PATCH]scsi: check the return value of device_create_file() in powertec.c
Date: Wednesday, May 28, 2008 - 10:42 am

I'd prefer not to kill the driver if device_create_file fails.  Just

arrange to print a warning instead (and remember not to unregister

the file if it wasn't created.)

--
Previous thread: Bad black-lists in use by list recipients... by Matti Aarnio on Sunday, May 25, 2008 - 8:44 am. (1 message)

Next thread: POHMELFS high performance network filesystem. Cache coherency, transactions, parallels. by Evgeniy Polyakov on Sunday, May 25, 2008 - 9:40 am. (13 messages)