Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Johannes Berg
Date: Sunday, May 25, 2008 - 4:59 am

Marcel,


Exactly my point! Hence, the kernel just gives it an arbitrary name. The
fact that userspace uses this as a filename could be regarded as a bug,
but it works fine. Therefore, the kernel simply assigns an arbitrary,
NULL-terminated string as the name. It happens to include a / because it
is convenient with the current userspace implementation, but that's mere
detail, the ABI/API here is to allow any arbitrary names.


But that doesn't matter at all! Dave's work to build firmware files into
the kernel will simply result in an entry in the kernel firmware table
that has a '.name =3D "b43/pcm5.fw"', nothing needs to know that b43 is a
module name, in fact, it could very well be 'broadcom wlan/pcm5.fw' as
well.


That will introduce a "flag-day" where you have to upgrade userspace
with the kernel, and vice versa, OR userspace will have to guess. Not a
good solution either.

Why are you so fixated on special-casing the single character '/'?

johannes
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Fri May 23, 6:46 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Fri May 23, 10:13 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Fri May 23, 11:07 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sat May 24, 7:46 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sat May 24, 8:25 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sat May 24, 8:34 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sat May 24, 11:18 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sat May 24, 12:23 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sat May 24, 12:31 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 4:49 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 4:54 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Johannes Berg, (Sun May 25, 4:59 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 6:12 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 6:19 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sun May 25, 6:46 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sun May 25, 7:18 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Alexandre Oliva, (Sun May 25, 10:17 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 11:07 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 11:12 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 11:15 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Michael Buesch, (Sun May 25, 11:18 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 11:23 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Michael Buesch, (Sun May 25, 11:27 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 11:28 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 11:34 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Michael Buesch, (Sun May 25, 11:39 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 11:46 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 11:49 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Michael Buesch, (Sun May 25, 11:49 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Michael Buesch, (Sun May 25, 11:53 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 12:01 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Marcel Holtmann, (Sun May 25, 12:03 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Michael Buesch, (Sun May 25, 12:09 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Michael Buesch, (Sun May 25, 12:21 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Alexandre Oliva, (Sun May 25, 8:13 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Alexandre Oliva, (Sun May 25, 8:30 pm)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Alexandre Oliva, (Mon May 26, 10:09 am)
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option, Michael Buesch, (Mon May 26, 10:11 am)