[PATCHv2 21/28] dvb frontends: treat firmware data as const

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Woodhouse
Date: Sunday, May 25, 2008 - 3:23 am

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
---
 drivers/media/dvb/frontends/bcm3510.c  |    5 +++--
 drivers/media/dvb/frontends/nxt200x.c  |    3 ++-
 drivers/media/dvb/frontends/or51211.c  |    4 ++--
 drivers/media/dvb/frontends/sp8870.c   |    2 +-
 drivers/media/dvb/frontends/sp887x.c   |    2 +-
 drivers/media/dvb/frontends/tda10048.c |    2 +-
 drivers/media/dvb/frontends/tda1004x.c |    2 +-
 7 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/drivers/media/dvb/frontends/bcm3510.c b/drivers/media/dvb/frontends/bcm3510.c
index d268e65..cf5e576 100644
--- a/drivers/media/dvb/frontends/bcm3510.c
+++ b/drivers/media/dvb/frontends/bcm3510.c
@@ -590,7 +590,8 @@ static void bcm3510_release(struct dvb_frontend* fe)
  */
 #define BCM3510_DEFAULT_FIRMWARE "dvb-fe-bcm3510-01.fw"
 
-static int bcm3510_write_ram(struct bcm3510_state *st, u16 addr, u8 *b, u16 len)
+static int bcm3510_write_ram(struct bcm3510_state *st, u16 addr, const u8 *b,
+			     u16 len)
 {
 	int ret = 0,i;
 	bcm3510_register_value vH, vL,vD;
@@ -614,7 +615,7 @@ static int bcm3510_download_firmware(struct dvb_frontend* fe)
 	struct bcm3510_state* st = fe->demodulator_priv;
 	const struct firmware *fw;
 	u16 addr,len;
-	u8  *b;
+	const u8 *b;
 	int ret,i;
 
 	deb_info("requesting firmware\n");
diff --git a/drivers/media/dvb/frontends/nxt200x.c b/drivers/media/dvb/frontends/nxt200x.c
index 23d0228..af29835 100644
--- a/drivers/media/dvb/frontends/nxt200x.c
+++ b/drivers/media/dvb/frontends/nxt200x.c
@@ -93,7 +93,8 @@ static u8 i2c_readbytes (struct nxt200x_state* state, u8 addr, u8* buf, u8 len)
 	return 0;
 }
 
-static int nxt200x_writebytes (struct nxt200x_state* state, u8 reg, u8 *buf, u8 len)
+static int nxt200x_writebytes (struct nxt200x_state* state, u8 reg,
+			       const u8 *buf, u8 len)
 {
 	u8 buf2 [len+1];
 	int err;
diff --git a/drivers/media/dvb/frontends/or51211.c b/drivers/media/dvb/frontends/or51211.c
index 7eaa476..6afe12a 100644
--- a/drivers/media/dvb/frontends/or51211.c
+++ b/drivers/media/dvb/frontends/or51211.c
@@ -69,7 +69,7 @@ struct or51211_state {
 	u32 current_frequency;
 };
 
-static int i2c_writebytes (struct or51211_state* state, u8 reg, u8 *buf,
+static int i2c_writebytes (struct or51211_state* state, u8 reg, const u8 *buf,
 			   int len)
 {
 	int err;
@@ -77,7 +77,7 @@ static int i2c_writebytes (struct or51211_state* state, u8 reg, u8 *buf,
 	msg.addr	= reg;
 	msg.flags	= 0;
 	msg.len		= len;
-	msg.buf		= buf;
+	msg.buf		= (u8 *)buf;
 
 	if ((err = i2c_transfer (state->i2c, &msg, 1)) != 1) {
 		printk(KERN_WARNING "or51211: i2c_writebytes error "
diff --git a/drivers/media/dvb/frontends/sp8870.c b/drivers/media/dvb/frontends/sp8870.c
index aa78aa1..1c9a9b4 100644
--- a/drivers/media/dvb/frontends/sp8870.c
+++ b/drivers/media/dvb/frontends/sp8870.c
@@ -98,7 +98,7 @@ static int sp8870_readreg (struct sp8870_state* state, u16 reg)
 static int sp8870_firmware_upload (struct sp8870_state* state, const struct firmware *fw)
 {
 	struct i2c_msg msg;
-	char *fw_buf = fw->data;
+	const char *fw_buf = fw->data;
 	int fw_pos;
 	u8 tx_buf[255];
 	int tx_len;
diff --git a/drivers/media/dvb/frontends/sp887x.c b/drivers/media/dvb/frontends/sp887x.c
index 49f5587..4543609 100644
--- a/drivers/media/dvb/frontends/sp887x.c
+++ b/drivers/media/dvb/frontends/sp887x.c
@@ -140,7 +140,7 @@ static int sp887x_initial_setup (struct dvb_frontend* fe, const struct firmware
 	u8 buf [BLOCKSIZE+2];
 	int i;
 	int fw_size = fw->size;
-	unsigned char *mem = fw->data;
+	const unsigned char *mem = fw->data;
 
 	dprintk("%s\n", __func__);
 
diff --git a/drivers/media/dvb/frontends/tda10048.c b/drivers/media/dvb/frontends/tda10048.c
index 090fb7d..0ab8d86 100644
--- a/drivers/media/dvb/frontends/tda10048.c
+++ b/drivers/media/dvb/frontends/tda10048.c
@@ -233,7 +233,7 @@ static u8 tda10048_readreg(struct tda10048_state *state, u8 reg)
 }
 
 static int tda10048_writeregbulk(struct tda10048_state *state, u8 reg,
-	u8 *data, u16 len)
+				 const u8 *data, u16 len)
 {
 	int ret = -EREMOTEIO;
 	struct i2c_msg msg;
diff --git a/drivers/media/dvb/frontends/tda1004x.c b/drivers/media/dvb/frontends/tda1004x.c
index 4997384..ff6b427 100644
--- a/drivers/media/dvb/frontends/tda1004x.c
+++ b/drivers/media/dvb/frontends/tda1004x.c
@@ -317,7 +317,7 @@ static int tda10046h_set_bandwidth(struct tda1004x_state *state,
 }
 
 static int tda1004x_do_upload(struct tda1004x_state *state,
-			      unsigned char *mem, unsigned int len,
+			      const unsigned char *mem, unsigned int len,
 			      u8 dspCodeCounterReg, u8 dspCodeInReg)
 {
 	u8 buf[65];
-- 
1.5.4.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCHv2 01/28] libertas: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 02/28] bluetooth: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 03/28] cyclades: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 04/28] cx25840: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 05/28] myri10ge: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 06/28] vx222: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 07/28] riptide: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 08/28] pcxhr: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 09/28] vx: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 10/28] ueagle-atm: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 11/28] cxacru: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 12/28] aic94xx: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 13/28] zd1201: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 14/28] rt2x00: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 15/28] p54: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 16/28] atmel: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 17/28] irda-usb: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 18/28] cxgb3: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 19/28] bt8xx: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 20/28] ttusb-dec: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 21/28] dvb frontends: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 22/28] cxusb: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 23/28] gp8psk: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 24/28] tuners: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 25/28] firmware: make fw-&gt;data const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 27/28] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sun May 25, 3:23 am)
Re: [PATCHv2 22/28] cxusb: treat firmware data as const, Michael Krufky, (Sun May 25, 7:14 am)
Re: [PATCHv2 22/28] cxusb: treat firmware data as const, David Woodhouse, (Sun May 25, 7:27 am)
Re: [PATCHv2 04/28] cx25840: treat firmware data as const, David Woodhouse, (Sun May 25, 7:36 am)
Re: [PATCHv2 04/28] cx25840: treat firmware data as const, David Woodhouse, (Sun May 25, 7:56 am)
Re: [PATCHv2 22/28] cxusb: treat firmware data as const, David Woodhouse, (Sun May 25, 8:02 am)
Re: [PATCHv2 04/28] cx25840: treat firmware data as const, Tyler Trafford, (Sun May 25, 9:16 am)
[PATCHv3 27/28] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sun May 25, 10:00 am)
[PATCH 29/28] firmware: Add 'firmware_install' make target, David Woodhouse, (Thu May 29, 1:29 am)
[PATCHv2 #ERROR!/28] maestro3: treat firmware data as const, David Woodhouse, (Thu May 29, 2:09 am)
[PATCH N/28] ymfpci: treat firmware data as const, David Woodhouse, (Thu May 29, 5:21 am)
[PATCH] smctr: use request_firmware(), David Woodhouse, (Thu May 29, 6:47 am)
[PATCH] kaweth: use request_firmware(), David Woodhouse, (Thu May 29, 7:20 am)
[PATCH] ttusb-budget: use request_firmware(), David Woodhouse, (Thu May 29, 10:49 am)
Re: [PATCH] smctr: use request_firmware(), maximilian attems, (Thu May 29, 12:30 pm)
Re: [PATCH] smctr: use request_firmware(), David Woodhouse, (Thu May 29, 2:02 pm)
[PATCH] keyspan: use request_firmware(), David Woodhouse, (Fri May 30, 4:45 am)
[PATCH] keyspan_pda: use request_firmware(), David Woodhouse, (Fri May 30, 5:19 am)
Re: [PATCH] keyspan: use request_firmware(), Hugh Blemings, (Fri May 30, 6:54 am)
Re: [PATCH] kaweth: use request_firmware(), Oliver Neukum, (Fri May 30, 6:55 am)
Re: [PATCH] kaweth: use request_firmware(), David Woodhouse, (Fri May 30, 8:16 am)
Re: [PATCH] kaweth: use request_firmware(), Marcel Holtmann, (Fri May 30, 8:26 am)
Re: [PATCH] kaweth: use request_firmware(), Alan Cox, (Fri May 30, 8:48 am)
Re: [PATCH] kaweth: use request_firmware(), Oliver Neukum, (Fri May 30, 2:02 pm)
Re: [PATCH] kaweth: use request_firmware(), Alexandre Oliva, (Fri May 30, 5:00 pm)
Re: [PATCH] kaweth: use request_firmware(), Marcel Holtmann, (Fri May 30, 11:51 pm)
Re: [PATCH] kaweth: use request_firmware(), Alan Cox, (Sat May 31, 5:35 am)
Re: [PATCH] ttusb-budget: use request_firmware(), Mauro Carvalho Chehab, (Fri Jun 13, 12:23 pm)