linux-kernel mailing list

FromSubjectsort iconDate
Steven Fuerst
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
How about this? #include <stdio.h> #define CONFIG_FOO 1 /* #define CONFIG_BAR 1 */ #define STR2(x) #x #define STR(x) STR2(x) #define PASTE2(x, y) x##y #define PASTE(x, y) PASTE2(x, y) #define KCONFIG2(x, y) STR(PASTE(CONFIG_, x))[y] #define KCONFIG(x) (!((KCONFIG2(x, 0) == 'C') && \ (KCONFIG2(x, 1) == 'O') && \ (KCONFIG2(x, 2) == 'N') && \ (KCONFIG2(x, 3) == 'F') && \ (KCONFIG2(x, 4) == 'I') && \ (KCONFIG2(x, 5) == 'G') && \ (KCONFIG2(x, 6) == ...
May 24, 4:36 pm 2008
Rafael J. Wysocki
[Bug #10642] general protection fault: 0000 [1] PREEMPT ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10642 Subject : general protection fault: 0000 [1] PREEMPT SMP DEBUG_PAGEALLOC Submitter : Zdenek Kabelac <zdenek.kabelac@gmail.com> Date : 2008-05-07 16:03 (18 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10711] BUG: unable to handle kernel paging request ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10711 Subject : BUG: unable to handle kernel paging request - scsi_bus_uevent Submitter : Zdenek Kabelac <zdenek.kabelac@gmail.com> Date : 2008-05-14 11:23 (11 days old) References : ...
May 24, 1:31 pm 2008
Adrian Bunk
Re: [Bug #10762] ocfs2: rename user_stack{,_ops}
cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --
May 24, 2:47 pm 2008
Rafael J. Wysocki
[Bug #10629] 2.6.26-rc1-$sha1: RIP __d_lookup+0x8c/0x160
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10629 Subject : 2.6.26-rc1-$sha1: RIP __d_lookup+0x8c/0x160 Submitter : Alexey Dobriyan <adobriyan@gmail.com> Date : 2008-05-05 09:59 (20 days old) References : http://lkml.org/lkml/2008/5/5/28 Handled-By : Paul E. ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10733] avr32: export copy_page
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10733 Subject : avr32: export copy_page Submitter : Adrian Bunk <bunk@kernel.org> Date : 2008-05-17 09:01 (8 days old) References : http://article.gmane.org/gmane.linux.kernel/676240 ...
May 24, 1:31 pm 2008
Justin Mattock
Re: [Bug #10724] ACPI : EC: GPE
Hello; This message seems to be appearing on a random, (every x amount of boots). At first I thought this was resolved with adjusting the .config but didn't seem to be the answer. Also I have third party modules installed i.g.(isight driver, and dri driver) which also might be causing this. I guess the best answer is if somebody else can verify this happens to them, with all in kernel modules. I on the other hand will unload the third party modules and see if this appears. regards; -- ...
May 24, 4:08 pm 2008
Rafael J. Wysocki
[Bug #10628] 2.6.26-rc1-git1 -- trying to get vblank cou ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10628 Subject : 2.6.26-rc1-git1 -- trying to get vblank count for disabled pipe 0 Submitter : Miles Lane <miles.lane@gmail.com> Date : 2008-05-04 21:12 (21 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10686] critical thermal shutdown regression 2.6.26 ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10686 Subject : critical thermal shutdown regression 2.6.26-rc1 - HP Pavilion dv6700 Submitter : Len Brown <len.brown@intel.com> Date : 2008-05-12 20:04 (13 days old) Handled-By : Robert Moore ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10714] Badness seen on 2.6.26-rc2 with lockdep enabled
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10714 Subject : Badness seen on 2.6.26-rc2 with lockdep enabled Submitter : Balbir Singh <balbir@linux.vnet.ibm.com> Date : 2008-05-14 12:57 (11 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10751] pciehp probing slow, duplicate kobject_add
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10751 Subject : pciehp probing slow, duplicate kobject_add Submitter : Jan C. Nordholz <jckn@gmx.net> Date : 2008-05-19 14:26 (6 days old) --
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10764] some serial configurations are now broken
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10764 Subject : some serial configurations are now broken Submitter : Russell King <rmk+lkml@arm.linux.org.uk> Date : 2008-05-20 7:35 (5 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10708] V4L2-based build error
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10708 Subject : V4L2-based build error Submitter : Jonathan Corbet <corbet@lwn.net> Date : 2008-05-12 22:14 (13 days old) References : http://marc.info/?l=linux-kernel&m=121063048408534&w=4 Handled-By : Mauro ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10632] [2.6.26-rc1] Output to console stops when b ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10632 Subject : [2.6.26-rc1] Output to console stops when booted without 'vga=791' Submitter : Frans Pop <elendil@planet.nl> Date : 2008-05-05 13:51 (20 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10765] iwl3945/mac80211: association times out sin ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10765 Subject : iwl3945/mac80211: association times out since 2.6.26-rc1 Submitter : Michael S. Tsirkin <m.s.tsirkin@gmail.com> Date : 2008-05-20 22:46 (5 days old) Handled-By : Zhu Yi <yi.zhu@intel.com> --
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10731] gianfar build failure.
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10731 Subject : gianfar build failure. Submitter : Dave Jones <davej@redhat.com> Date : 2008-05-16 23:29 (9 days old) References : http://marc.info/?l=linux-kernel&m=121098065023786&w=4 Handled-By : Paul ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10761] hackbench regression with 2.6.26-rc2 on tul ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10761 Subject : hackbench regression with 2.6.26-rc2 on tulsa machine Submitter : Zhang, Yanmin <yanmin_zhang@linux.intel.com> Date : 2008-05-20 8:09 (5 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10606] 2.6.26-rc1 regression: ACPI fails to load S ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10606 Subject : 2.6.26-rc1 regression: ACPI fails to load SDT. - Dell M1530 Submitter : NIgel Cunningham <nigel@suspend2.net> Date : 2008-05-05 18:11 (20 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10557] [regression] latest git couse kernel oops.
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10557 Subject : [regression] latest git couse kernel oops. Submitter : Alexey Fisher <bug-track@fisher-privat.net> Date : 2008-04-26 00:19 (29 days old) --
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10742] BISECTED REGRESSION: 2.6.26-rc2: FUSE chang ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10742 Subject : BISECTED REGRESSION: 2.6.26-rc2: FUSE changes break mount of ntfs-3g Submitter : Ioan Ionita <opslynx@gmail.com> Date : 2008-05-17 20:37 (8 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10787] pcie hotplug bootup crash fix
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10787 Subject : pcie hotplug bootup crash fix Submitter : Ingo Molnar <mingo@elte.hu> Date : 2008-05-24 16:58 (1 days old) References : http://marc.info/?l=linux-kernel&m=121164842212038&w=4 Handled-By : Ingo ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10726] x86-64 NODES_SHIFT compile failure.
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10726 Subject : x86-64 NODES_SHIFT compile failure. Submitter : Dave Jones <davej@codemonkey.org.uk> Date : 2008-05-16 12:54 (9 days old) References : http://lkml.org/lkml/2008/5/16/312 Handled-By : Mike Travis ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10724] ACPI : EC: GPE
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10724 Subject : ACPI : EC: GPE Submitter : Justin Mattock <justinmattock@gmail.com> Date : 2008-05-16 6:17 (9 days old) References : http://marc.info/?l=linux-kernel&m=121091875711824&w=4 ...
May 24, 1:31 pm 2008
Adrian Bunk
Re: [Bug #10733] avr32: export copy_page
cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --
May 24, 2:47 pm 2008
Rafael J. Wysocki
[Bug #10748] dhclient fails to run; capabilities error
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10748 Subject : dhclient fails to run; capabilities error Submitter : Amit Shah <shahamit@gmail.com> Date : 2008-05-19 06:25 (6 days old) --
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10730] build issue #503 for v2.6.26-rc2-433-gf26a3 ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10730 Subject : build issue #503 for v2.6.26-rc2-433-gf26a398 : undefined reference to `request_firmware' Submitter : Toralf Förster <toralf.foerster@gmx.de> Date : 2008-05-16 17:06 (9 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10725] Write protect on on
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10725 Subject : Write protect on on Submitter : Maciej Rutecki <maciej.rutecki@gmail.com> Date : 2008-05-16 14:55 (9 days old) References : http://marc.info/?l=linux-kernel&m=121095168003572&w=4 --
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10786] 2.6.26-rc3 64bit SMP does not boot on J5600
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10786 Subject : 2.6.26-rc3 64bit SMP does not boot on J5600 Submitter : Domenico Andreoli <cavokz@gmail.com> Date : 2008-05-22 16:14 (3 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10760] PCIEHP breakage in 2.6.26-rc1,2.6.26-rc2,2. ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10760 Subject : PCIEHP breakage in 2.6.26-rc1,2.6.26-rc2,2.6.26-rc3 Submitter : Ryan Hope <rmh3093@gmail.com> Date : 2008-05-19 17:47 (6 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10616] Horrendous Audio Stutter - current git
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10616 Subject : Horrendous Audio Stutter - current git Submitter : Parag Warudkar <parag.warudkar@gmail.com> Date : 2008-05-02 20:14 (23 days old) References : http://lkml.org/lkml/2008/5/1/440 ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10638] sysbench+mysql(oltp, readonly) 30% regressi ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10638 Subject : sysbench+mysql(oltp, readonly) 30% regression with 2.6.26-rc1 Submitter : Zhang, Yanmin <yanmin_zhang@linux.intel.com> Date : 2008-05-07 4:55 (18 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10715] 2.6.25 -> 2.6.26-rc1: pcmcia flash card ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10715 Subject : 2.6.25 -> 2.6.26-rc1: pcmcia flash card changed name from hda to hdc Submitter : Pavel Machek <pavel@suse.cz> Date : 2008-05-15 13:23 (10 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10670] BUG: linux-2.6.26-rc1 oops at thinkpad_acpi ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10670 Subject : BUG: linux-2.6.26-rc1 oops at thinkpad_acpi:led_set_status Submitter : Karol Lewandowski <lmctlx@gmail.com> Date : 2008-05-08 23:12 (17 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10716] VIDEO_DEV=y, DVB_CORE=m build error
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10716 Subject : VIDEO_DEV=y, DVB_CORE=m build error Submitter : Toralf Förster <toralf.foerster@gmx.de> Date : 2008-05-15 13:15 (10 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10749] the system doesn't shutdown
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10749 Subject : the system doesn't shutdown Submitter : Riccardo <goric@trivenet.it> Date : 2008-05-19 09:00 (6 days old) --
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10613] BIOS bug, APIC version is 0 for CPU#0!
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10613 Subject : BIOS bug, APIC version is 0 for CPU#0! Submitter : Gabriel C <nix.or.die@googlemail.com> Date : 2008-05-03 15:11 (22 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
2.6.26-rc3-git7: Reported regressions from 2.6.25
This message contains a list of some regressions from 2.6.25, for which there are no fixes in the mainline I know of. If any of them have been fixed already, please let me know. If you know of any other unresolved regressions from 2.6.25, please let me know either and I'll add them to the list. Also, please let me know if any of the entries below are invalid. Each entry from the list will be sent additionally in an automatic reply to this message with CCs to the people involved in reporting ...
May 24, 1:28 pm 2008
Rafael J. Wysocki
[Bug #10648] CONFIG_PRINTK_TIME broken on git HEAD ?
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10648 Subject : CONFIG_PRINTK_TIME broken on git HEAD ? Submitter : Gabriel C <nix.or.die@googlemail.com> Date : 2008-05-08 00:26 (17 days old) References : http://lkml.org/lkml/2008/5/7/352 Handled-By : Peter Zijlstra ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10759] recent 2.6.26 kernel hangs at suspend
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10759 Subject : recent 2.6.26 kernel hangs at suspend Submitter : Jeff Chua <jeff.chua.linux@gmail.com> Date : 2008-05-19 15:07 (6 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10732] REGRESSION: 2.6.26-rc2-git4: X server faile ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10732 Subject : REGRESSION: 2.6.26-rc2-git4: X server failed start on X61s laptop Submitter : Theodore Ts'o <tytso@mit.edu> Date : 2008-05-17 7:32 (8 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10634] volanoMark regression with kernel 2.6.26-rc1
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10634 Subject : volanoMark regression with kernel 2.6.26-rc1 Submitter : Zhang, Yanmin <yanmin_zhang@linux.intel.com> Date : 2008-05-06 2:06 (19 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10717] crossbuild fails in modpost
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10717 Subject : crossbuild fails in modpost Submitter : Jiri Slaby <jirislaby@gmail.com> Date : 2008-05-15 13:44 (10 days old) References : http://marc.info/?l=linux-kernel&m=121085909512097&w=4 Patch : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #9791] Clock is running too fast^Wslow using acpi_p ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=9791 Subject : Clock is running too fast^Wslow using acpi_pm clocksource Submitter : tosn00j02@sneakemail.com Date : 2008-05-03 05:09 (22 days old) --
May 24, 1:31 pm 2008
Vegard Nossum
Re: [Bug #10710] [BISECTED] Lots of "rescheduling IPIs" ...
It has been fixed in mainline and should not still be listed: commit a738d897b7b03b83488ae74a9bc03d26a2875dc6 Author: Ingo Molnar <mingo@elte.hu> Date: Wed May 14 08:47:40 2008 +0200 x86: remove mwait capability C-state check Thanks :-D Vegard -- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036 --
May 24, 2:35 pm 2008
Rafael J. Wysocki
[Bug #10710] [BISECTED] Lots of "rescheduling IPIs" in p ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10710 Subject : [BISECTED] Lots of "rescheduling IPIs" in powertop Submitter : Vegard Nossum <vegard.nossum@gmail.com> Date : 2008-05-13 20:42 (12 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10762] ocfs2: rename user_stack{,_ops}
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10762 Subject : ocfs2: rename user_stack{,_ops} Submitter : Adrian Bunk <bunk@kernel.org> Date : 2008-05-20 16:01 (5 days old) References : http://lkml.org/lkml/2008/5/20/603 Handled-By : Adrian Bunk ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10713] ehci splatter in 2.6.26-rc2
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10713 Subject : ehci splatter in 2.6.26-rc2 Submitter : Lennert Buytenhek <buytenh@wantstofly.org> Date : 2008-05-14 11:24 (11 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10741] bug in `tty: BKL pushdown'?
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10741 Subject : bug in `tty: BKL pushdown'? Submitter : Johannes Weiner <hannes@saeurebad.de> Date : 2008-05-18 2:16 (7 days old) References : http://marc.info/?l=linux-kernel&m=121107706506181&w=4 Handled-By : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10630] USB devices plugged into dock are not disco ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10630 Subject : USB devices plugged into dock are not discoverred until reload of ehci-hcd Submitter : Lukas Hejtmanek <xhejtman@ics.muni.cz> Date : 2008-05-05 10:02 (20 days old) References : ...
May 24, 1:31 pm 2008
Adrian Bunk
Re: [Bug #10716] VIDEO_DEV=y, DVB_CORE=m build error
cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --
May 24, 2:48 pm 2008
Rafael J. Wysocki
[Bug #10669] ACPI: kmemcheck: Caught 16-bit read from fr ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10669 Subject : ACPI: kmemcheck: Caught 16-bit read from freed memory (f7c12ec6) Submitter : Vegard Nossum <vegard.nossum@gmail.com> Date : 2008-05-06 16:09 (19 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10582] INFO: task pdflush:27505 blocked for more t ...
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10582 Subject : INFO: task pdflush:27505 blocked for more than 120 seconds. Submitter : Plamen Petrov <pvp-lsts@fs.ru.acad.bg> Date : 2008-05-01 02:30 (24 days old) References : ...
May 24, 1:31 pm 2008
Rafael J. Wysocki
[Bug #10493] mips BCM47XX compile error
This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.25. Please verify if it still should be listed. Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=10493 Subject : mips BCM47XX compile error Submitter : Adrian Bunk <adrian.bunk@movial.fi> Date : 2008-04-20 17:07 (35 days old) References : http://lkml.org/lkml/2008/4/20/34 http://lkml.org/lkml/2008/5/12/30 ...
May 24, 1:28 pm 2008
Thomas Gleixner
Re: your mail
It could and it does. Still this does not protect against another lower prio task taking the futex before the woken waiter can do it, which is happening way more often than your theoretical setscheduler case. Again, setscheduler is called in startup code of a program not Your code solves the least to worry about corner case and hurts performance for nothing. You take extra locks in the hot path for no benefit. Aside of that it introduces lock order problems and we can really do without ...
May 24, 1:05 pm 2008
Daniel Walker
Re: your mail
Above I'm not speaking about my code, I'm only speaking in terms of a solution to this case, even if it isn't mine.. Daniel --
May 24, 2:06 pm 2008
Clark Williams
[PATCH -rt] fix for compiling 2.6.24.7-rt10 without CONF ...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Steven, If you build a debugging kernel and don't have CONFIG_FTRACE turned on, -rt10 dies when compiling arch/x86/kernel/x8664_ksyms_64.c, because ktime_t isn't defined in the prototypes at the bottom of include/linux/ftrace.h. Patch to fix attached. Clark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - ...
May 24, 12:49 pm 2008
Jeff Garzik
Re: Bug in libata
This is a configuration problem. You need to pick one driver or the other, not both, as that commit's description indicates. Jeff --
May 24, 12:35 pm 2008
devzero
Re: [PATCH 2/2] Only print "Decompressing Linux" etc w
what about using "quiet" here instead ? quiet is already the parameter to suppress boot messages, so introducing another one doesn`t make sense, imho. the early boot commandline parser was extended some time ago to support boolean options, see: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=32d0b98980... this may shrink your patch , see example in arch/x86/boot/edd.c be_quiet = cmdline_find_option_bool("quiet"); .... if ...
May 24, 12:28 pm 2008
Pavel Machek
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
Could we s/KCONFIG_/CFG_/g ? CONFIG_ is long enough already, and K there is very maningless..... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
May 24, 2:26 pm 2008
Sam Ravnborg
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
Midway... Roman implmented named choices and I have yet to try it out. But I have a bit on my TODO list before I get there and limited time (My day-time job is not Linux related). Sam --
May 24, 2:03 pm 2008
Sam Ravnborg
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
Not today where we have one configuration definition per architecture. I hope we one day can change that so we have one for the whole kernel. This would for example allow us to detect when someone do a misspelled "depends on FOOBAR" because it will no longer be These symbols would be know of - their value would just be 0. The correct patch (last one posted) does this. Sam --
May 24, 2:00 pm 2008
Andrew Morton
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
But there are still holes - KCONFIG_ARCH_FOOTBRIDGE wouldn't be defined on x86, for example. Anything which is inside an `if' or inside an if/source/endif will not be known about? I assume? It's all probably not a big problem in practice - we'd need to be more-than-usually-silly to trip over things like this. --
May 24, 1:48 pm 2008
Adrian Bunk
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
$ cat test.c #define KCONFIG(x) (CONFIG_##x - 0) int main() { if (KCONFIG(PREEMPT)) ; return 0; } $ gcc -O2 -Wall test.c test.c: In function ‘main’: test.c:5: error: ‘CONFIG_PREEMPT’ undeclared (first use in this function) test.c:5: error: (Each undeclared identifier is reported only once test.c:5: error: for each function it appears in.) $ gcc --version cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There ...
May 24, 2:03 pm 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
I think if you know you can use the if(KCONFIG_) technique, then one would tend to structure things so that you do it as much as possible. Ideally you'd use CONFIG vars in Makefiles to make code go away Well, logically that means that all config vars are always "known", even if they can never be defined. I don't know what the practicalities of that are: can all Kconfig files everywhere reasonably be scanned to produce the symbol list? J --
May 24, 1:14 pm 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
Yep. But is a unified config something that someone is actively working on, or a distant pipe dream? J --
May 24, 1:56 pm 2008
Adrian Bunk
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
I'm talking about the one set with MODFLAGS = -DMODULE But looking through the kernel I have to take my statement back since there don't seem to be many usages that could (if wanted) be transformed to if()'s at all (and similarily there wouldn't be many use cases in cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. ...
May 24, 1:57 pm 2008
Sam Ravnborg
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
When we have one configuration for the kernel and not as today where we have one configuration for each architecture (with a lot of shared files) then it is already taken care of by my (updated) patch. Sam --
May 24, 1:46 pm 2008
Sam Ravnborg
[PATCH] x86: use defconfig as last resort
From: Sam Ravnborg <sam@ravnborg.org> Subject: [PATCH] x86: use defconfig as last resort When using "make oldconfig" with no .config present try the list from init/Kconfig DEFCONFIG_LIST before resorting to use one of the defconfigs. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> --- I had the patch in my local tree but never got it posted. And then I forgot. I plan to redo this stuff soonish so we have a more clean and predictive approach. But the KCONFIG_ stuff was just more fun ...
May 24, 1:37 pm 2008
Linus Torvalds
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
Can we get the /etc/kernel-config regression fixed before even posting things like this? Please? Linus --
May 24, 1:20 pm 2008
Adrian Bunk
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
If you really want to be able to transform all #if's in .c files to Also an error message if if the varible is not currently available on this architecture (e.g. KCONFIG_ISA on ia64). Not an unsolvable problem, but something that has to be taken care of. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. ...
May 24, 1:05 pm 2008
Sam Ravnborg
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
1) I have no pland to replace the current CONFIG_ use. My master plan is to have a single configuration for the kernel and not as today where we have one configuration for each architecture. How far away we are from that I dunno. It is a while I visited this. And I will not have time to do so anytime soon I'm afraid. Sam --
May 24, 1:44 pm 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
How about rather than defining a pile of new constants, we just define: #define KCONFIG(x) (x - 0) /* XXX choose better macro name */ That would allow CONFIG_X variables to be used in C expressions, while still coping with non-existent/unknown CONFIG vars. Also saves on a lot of #defines... J --
May 24, 1:48 pm 2008
Sam Ravnborg
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
It would have helped if I had applied the correct patch... All boolean and tristate symbols in the konfiguration have their symbols defined as KCONFIG_* no matter their values. So KCONFIG_DVB_VES1820 would get defined. Correct patch below. Sam diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index ee5fe94..247ea30 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -666,6 +666,43 @@ out: return res; } +static void ...
May 24, 1:24 pm 2008
Andrew Morton
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
It could help to get us out of the occasional sticky situation, but it does seem a bit risky. What happens with Kconfig variables which are just not known about at all with some .configs? Silly example, one could add if (KCONFIG_DVB_VES1820) to kernel/sched.c and that would work happily until someone sets DVB=n, in which case I assume KCONFIG_DVB_VES1820 doesn't get defined anywhere? A more realistic example might be using an x86-only KCONFIG_* in non-x86 code. --
May 24, 12:53 pm 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
You and your scientific method. Yeah, this is one of those cases where you need cpp to rescan its input after pasting, and I don't think it will ever do that. J --
May 24, 2:13 pm 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for ...
Would #define KCONFIG(x) (CONFIG_##x - 0) if (KCONFIG(PREEMPT)) { ... } work? J --
May 24, 1:58 pm 2008
Sam Ravnborg
[RFC PATCH] kconfig: introduce KCONFIG_* symbols for .c files
We have many places in the kernel that looks like the following: #ifdef CONFIG_FOO ... #endif Which has the disadvantage that the code denoted '...' are not even built if CONFIG_FOO is not selected in the current configuration. We know that gcc do simple code-elimination for conditionals which is always true/false and thus the above code could be turned into: if (CONFIG_FOO) ... One line smaller and we follow the normal flow in the program. The code is always build but we do ...
May 24, 12:25 pm 2008
j.mell
Re: CONFIG_PREEMPT causes corruption of application's FP ...
I found now that the problem was introduced somewhere between the kernel.org kernels 2.6.19.7 and 2.6.20. I will start bisecting now. Bye, Jürgen --
May 24, 11:52 am 2008
Abhishek Sagar
[PATCH] ftrace: fix updating of ftrace_update_cnt
Hi Ingo/Steven, Ftrace currently maintains an update count which includes false updates, i.e, updates which failed. If anything, such failures should be tracked by some separate variable, but this patch provides a minimal fix. Signed-off-by: Abhishek Sagar <sagar.abhishek@gmail.com> --- fix updating of ftrace_update_cnt diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index bfba25c..14e086f 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -443,7 +443,7 @@ static ...
May 24, 11:40 am 2008
Abhishek Sagar
[PATCH] ftrace: safe traversal of ftrace_hash hlist
Hi Steven, I noticed that concurrent instances of ftrace_record_ip() have a race between ftrace_hash list traversal during ftrace_ip_in_hash() (before acquiring ftrace_shutdown_lock) and ftrace_add_hash().If it's so then this should fix it. Signed-off-by: Abhishek Sagar <sagar.abhishek@gmail.com> --- Accommodate traversal of ftrace_hash hlist with concurrent insertions. diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 89bd9a6..bfba25c 100644 --- a/kernel/trace/ftrace.c +++ ...
May 24, 11:15 am 2008
Andrea Righi
[PATCH 3/3] io-throttle accounting and control
Apply the io-throttle controller to the opportune kernel functions. Both accounting and throttling functionalities are performed by cgroup_io_account(). Signed-off-by: Andrea Righi <righi.andrea@gmail.com> --- block/blk-core.c | 2 ++ fs/buffer.c | 6 ++++++ fs/direct-io.c | 2 ++ mm/page-writeback.c | 5 +++++ mm/readahead.c | 2 ++ 5 files changed, 17 insertions(+), 0 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index ...
May 24, 9:56 am 2008
Andrea Righi
[PATCH 0/3] cgroup: block device i/o bandwidth controller
I'm resending an updated version of the cgroup I/O bandwidth controller that I wrote some months ago (http://lwn.net/Articles/265944), since someone asked me recently. The goal of this patchset is to implement a block device I/O bandwidth controller using cgroups. Detailed informations about design, its goal and usage are described in the documentation. Review, comments and feedbacks are welcome. -Andrea --
May 24, 9:56 am 2008
Balbir Singh
Re: [PATCH 0/3] cgroup: block device i/o bandwidth controller
Hi, Andrea, There are several parallel efforts for the IO controller? Could you describe/compare them with yours? Is any consensus building taking place? CC'ing containers mailing list. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL --
May 24, 11:22 am 2008
Andrea Righi
Re: [PATCH 0/3] cgroup: block device i/o bandwidth controller
Hi Balbir, I've seen the Ryo Tsuruta's dm-band (http://lwn.net/Articles/266257), the CFQ cgroup solution proposed by Vasily Tarasov (http://lwn.net/Articles/274652) and a similar approach by Satoshi Uchida (http://lwn.net/Articles/275944). First one is implemented at the device mapper layer and AFAIK at the moment it allows only to define per-task, per-user and per-group rules (cgroup support is in the TODO list anyway). Second and third solutions are implemented at the i/o ...
May 24, 3:28 pm 2008
Andrea Righi
[PATCH 2/3] io-throttle controller infrastructure
This is the core io-throttle kernel infrastructure. It creates the basic interfaces to cgroups and implements the I/O measurement and throttling functions. Signed-off-by: Andrea Righi <righi.andrea@gmail.com> --- block/Makefile | 2 + block/blk-io-throttle.c | 219 +++++++++++++++++++++++++++++++++++++++ include/linux/blk-io-throttle.h | 10 ++ include/linux/cgroup_subsys.h | 6 + init/Kconfig | 10 ++ 5 files changed, 247 ...
May 24, 9:56 am 2008
Andrea Righi
[PATCH 1/3] Add io-throttle controller documentation
Documentation of the block device I/O bandwidth controller: description, usage, advantages and design. Signed-off-by: Andrea Righi <righi.andrea@gmail.com> --- Documentation/controllers/io-throttle.txt | 81 +++++++++++++++++++++++++++++ 1 files changed, 81 insertions(+), 0 deletions(-) diff --git a/Documentation/controllers/io-throttle.txt b/Documentation/controllers/io-throttle.txt new file mode 100644 index 0000000..e7ab050 --- /dev/null +++ ...
May 24, 9:56 am 2008
Manfred Spraul
[PATCH 2/4] ipc/sem.c: remove unused entries from struct ...
sem_queue.sma and sem_queue.id were never used, the attached patch removes them. Signed-Off-By: Manfred Spraul <manfred@colorfullife.com> --- include/linux/sem.h | 2 -- ipc/sem.c | 2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/include/linux/sem.h b/include/linux/sem.h index 6a1af1b..87756ef 100644 --- a/include/linux/sem.h +++ b/include/linux/sem.h @@ -107,8 +107,6 @@ struct sem_queue { struct sem_undo * undo; /* undo structure */ int ...
May 24, 4:23 am 2008
Manfred Spraul
[PATCH 1/4] ipc/sem.c: convert undo structures to struct ...
The undo structures contain two linked lists, the attached patch replaces them with generic struct list_head lists. Signed-Off-By: Manfred Spraul <manfred@colorfullife.com> --- include/linux/sem.h | 12 ++-- ipc/sem.c | 165 ++++++++++++++++++++++++++++----------------------- 2 files changed, 96 insertions(+), 81 deletions(-) diff --git a/include/linux/sem.h b/include/linux/sem.h index c8eaad9..6a1af1b 100644 --- a/include/linux/sem.h +++ b/include/linux/sem.h @@ -95,7 +95,7 ...
May 24, 4:20 am 2008
Manfred Spraul
[PATCH 4/4] ipc/sem.c: rewrite undo list locking
The attached patch: - reverses the locking order of ulp->lock and sem_lock: Previously, it was first ulp->lock, then inside sem_lock. Now it's the other way around. - converts the undo structure to rcu. Benefits: - With the old locking order, IPC_RMID could not kfree the undo structures. The stale entries remained in the linked lists and were released later. - The patch fixes a a race in semtimedop(): if both IPC_RMID and a semget() that recreates exactly the same id happen between ...
May 24, 9:06 am 2008
Manfred Spraul
[PATCH 3/4] ipc/sem.c: convert sem_array.sem_pending to ...
sem_array.sem_pending is a double linked list, the attached patch converts it to struct list_head. Signed-Off-By: Manfred Spraul <manfred@colorfullife.com> --- include/linux/sem.h | 12 +++---- ipc/sem.c | 90 ++++++++++++++++++-------------------------------- 2 files changed, 38 insertions(+), 64 deletions(-) diff --git a/include/linux/sem.h b/include/linux/sem.h index 87756ef..d425993 100644 --- a/include/linux/sem.h +++ b/include/linux/sem.h @@ -93,21 +93,19 @@ struct ...
May 24, 4:26 am 2008
Manfred Spraul
[PATCH 0/4] ipc/sem.c: cleanup
I did some cleanup in ipc/sem: - ipc/sem contained hand-written linked lists, they can be replaced with standard list_head lists. - the locking was written before CLONE_SYSVSEM was introduced, with ulp->lock, it's now possible to free undo structures during IPC_RMID immediately. - There is a (extremely unlikely) race in semtimedop(), it can access kfree'd memory. The patches pass my own simple test cases, what do you think? -- Manfred --
May 24, 4:20 am 2008
Andrew Morton
Re: [patch, -git] pcie hotplug bootup crash fix
It is fishy that pcie_init() calls pciehp_request_irq() before calling pcie_init_hardware_part2(). That looks like the classic "lets die horridly if a shared IRQ comes in at the wrong time" sequence. --
May 24, 10:40 am 2008
Ingo Molnar
[patch, -git] pcie hotplug bootup crash fix
-tip tree testing found that the the PCI hotplug ISR routine crashes with a NULL pointer dereference under certain circumstances. The situation under which it occurs is hw and timing related: it appears to happen on a system that has PCI hotplug hardware but with no active hotplug cards, and another interrupt in the same (shared) IRQ line arrives too early, before the hotplug-slot entry has been set up - as triggered by CONFIG_DEBUG_SHIRQ=y: pciehp: HPC vendor_id 8086 device_id 27d0 ...
May 24, 9:58 am 2008
Mariusz Kozlowski
some numbers on macros
Hello, I wrote a rather dumb script to see some numbers on macros I was interested in. The script basically parses *.c file, finds macro definitions and counts how many times each macro was used in this source file. The script doesn't see any context so it can produce false positives - that is one of the reasons it doesn't look into header files - it's simply too dumb. The macros I was interested in were these which are: - defined and unused - defined and used only once - defined more than ...
May 24, 8:48 am 2008
Mariusz Kozlowski
Re: some numbers on macros
Maybe I wasn't precise enough. The script looks for macros which take argument(s) i.e. Well I'll just go through some of them. This is long term task as its number is quite big. Maybe I can improve the script some more or apply some other measures. I guess one can find there all sort of macros and some part of them are leftovers from something that was there some time ago. Interesting part would be to write a 'parser' that actually sees the context and understands cpp directives, that ...
May 24, 4:41 pm 2008
Arjan van de Ven
Re: some numbers on macros
On Sun, 25 May 2008 01:41:09 +0200 you could approach it from the opposite angle... I mean, lxr.linux.no already has all this data in some database.. maybe you can turn it into a set of database queries ;) --
May 24, 4:46 pm 2008
Matthew Wilcox
Re: some numbers on macros
Possibly. There's likely to be a lot of macros unused like these ones: #define PCI_X_CMD_MAX_READ 0x000c /* Max Memory Read Byte Count */ /* Max # of outstanding split transactions */ #define PCI_X_CMD_SPLIT_1 0x0000 /* Max 1 */ #define PCI_X_CMD_SPLIT_2 0x0010 /* Max 2 */ #define PCI_X_CMD_SPLIT_3 0x0020 /* Max 3 */ ... where the macros embody the PCI specification in code -- possibly we don't use them yet, but if we ever did, ...
May 24, 11:52 am 2008
Arjan van de Ven
Re: some numbers on macros
On Sat, 24 May 2008 17:48:19 +0200 An unused define/macro that was declared in a .c file isn't very interesting to be honest; that tends to be helper macros for the developer and removing those is just counter productive. unused macros in common header files are an indication of stale APIs otoh.. and might be of some interest. (Same for static inline in headers) --
May 24, 9:33 am 2008
Cyrill Gorcunov
[patch 11/11] x86: nmi_32/64.c - merge down nmi_32.c and ...
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Index: linux-2.6.git/arch/x86/kernel/nmi.c ==================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ linux-2.6.git/arch/x86/kernel/nmi.c 2008-05-24 17:23:04.000000000 +0400 @@ -0,0 +1,532 @@ +/* + * NMI watchdog support on APIC systems + * + * Started by Ingo Molnar <mingo@redhat.com> + * + * Fixes: + * Mikael Pettersson : AMD K7 support for local APIC NMI ...
May 24, 8:36 am 2008
Cyrill Gorcunov
[patch 10/11] x86: nmi_32/64.c - add helper functions to ...
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Index: linux-2.6.git/arch/x86/kernel/nmi_32.c ==================================================================== --- linux-2.6.git.orig/arch/x86/kernel/nmi_32.c 2008-05-24 13:20:13.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/nmi_32.c 2008-05-24 14:14:51.000000000 +0400 @@ -51,6 +51,26 @@ static DEFINE_PER_CPU(short, wd_enabled) static int endflag __initdata = 0; +static inline unsigned int get_nmi_count(int ...
May 24, 8:36 am 2008
Cyrill Gorcunov
[patch 07/11] x86: nmi_32.c - unknown_nmi_panic_callback ...
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Index: linux-2.6.git/arch/x86/kernel/nmi_32.c ==================================================================== --- linux-2.6.git.orig/arch/x86/kernel/nmi_32.c 2008-05-24 13:07:08.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/nmi_32.c 2008-05-24 13:10:10.000000000 +0400 @@ -425,7 +425,7 @@ static int unknown_nmi_panic_callback(st char buf[64]; sprintf(buf, "NMI received for unknown reason %02x\n", reason); - die_nmi(buf, ...
May 24, 8:36 am 2008
Cyrill Gorcunov
[patch 09/11] x86: nmi_32.c cleanup - use for_each_onlin ...
Since cpu_online_map is touched (by for_each_online_cpu) at moment when cpu_callin_map is already filled up we can get rid of its checking at all Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Index: linux-2.6.git/arch/x86/kernel/nmi_32.c ==================================================================== --- linux-2.6.git.orig/arch/x86/kernel/nmi_32.c 2008-05-24 13:16:48.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/nmi_32.c 2008-05-24 13:20:13.000000000 +0400 @@ -108,13 ...
May 24, 8:36 am 2008
Cyrill Gorcunov
[patch 08/11] x86: nmi_64.c - use for_each_possible_cpu ...
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Index: linux-2.6.git/arch/x86/kernel/nmi_64.c ==================================================================== --- linux-2.6.git.orig/arch/x86/kernel/nmi_64.c 2008-05-24 13:09:27.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/nmi_64.c 2008-05-24 13:17:59.000000000 +0400 @@ -98,7 +98,7 @@ int __init check_nmi_watchdog(void) smp_call_function(nmi_cpu_busy, (void *)&endflag, 0, 0); #endif - for (cpu = 0; cpu < NR_CPUS; ...
May 24, 8:36 am 2008
Cyrill Gorcunov
[patch 00/11] tip/x86/nmi nmi-32/64.c merge v3
This series tries to merge down nmi_32/64.c to nmi.c. It is done by small steps in hope it would help to bisect problems (which will appear anyway ;) Please review *carefully* since it is NMI what I've touched (and I'm not nmi specialist). So I really apreciate _ANY_ comments on this. The series is produced over today 'tip' tree branch 'x86/nmi'. - Cyrill - -- --
May 24, 8:36 am 2008
Cyrill Gorcunov
[patch 06/11] x86: nmi_32/64.c - use apic_write_around i ...
apic_write_around will be expanded to apic_write in 64bit mode anyway. Only a few CPUs (well, old CPUs to be precise) requires such an action. In general it should not hurt and could be cleaned up for apic_write (just in case) Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Index: linux-2.6.git/arch/x86/kernel/nmi_32.c ==================================================================== --- linux-2.6.git.orig/arch/x86/kernel/nmi_32.c 2008-05-24 13:04:20.000000000 +0400 +++ ...
May 24, 8:36 am 2008
Cyrill Gorcunov
[patch 04/11] x86: nmi_32.c - add "panic" option
Allow to pass "panic" option in 32bit mode Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Index: linux-2.6.git/arch/x86/kernel/nmi_32.c ==================================================================== --- linux-2.6.git.orig/arch/x86/kernel/nmi_32.c 2008-05-24 12:29:17.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/nmi_32.c 2008-05-24 12:45:30.000000000 +0400 @@ -42,6 +42,7 @@ static cpumask_t backtrace_mask = CPU_MA * 0: the lapic NMI watchdog is disabled, but can be ...
May 24, 8:36 am 2008
Cyrill Gorcunov
[patch 05/11] x86: nmi_32.c - add nmi_watchdog_default helper
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Index: linux-2.6.git/arch/x86/kernel/nmi_32.c ==================================================================== --- linux-2.6.git.orig/arch/x86/kernel/nmi_32.c 2008-05-24 13:01:21.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/nmi_32.c 2008-05-24 13:04:20.000000000 +0400 @@ -51,6 +51,17 @@ static DEFINE_PER_CPU(short, wd_enabled) static int endflag __initdata = 0; +/* Run after command line and cpu_init init, but before all ...
May 24, 8:36 am 2008
Cyrill Gorcunov
[patch 03/11] x86: nmi_64.c - move do_nmi(), stop_nmi() ...
traps_32.c already holds these functions so do the same for traps_64.c Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Index: linux-2.6.git/arch/x86/kernel/nmi_64.c ==================================================================== --- linux-2.6.git.orig/arch/x86/kernel/nmi_64.c 2008-05-24 12:25:57.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/nmi_64.c 2008-05-24 12:38:09.000000000 +0400 @@ -30,7 +30,6 @@ int unknown_nmi_panic; int nmi_watchdog_enabled; -int ...
May 24, 8:36 am 2008
Cyrill Gorcunov
[patch 02/11] x86: nmi - die_nmi() output message unification
Make 64bit die_nmi() to produce the same message as 32bit mode has Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Index: linux-2.6.git/arch/x86/kernel/nmi_64.c ==================================================================== --- linux-2.6.git.orig/arch/x86/kernel/nmi_64.c 2008-05-24 12:07:40.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/nmi_64.c 2008-05-24 12:25:57.000000000 +0400 @@ -358,8 +358,8 @@ nmi_watchdog_tick(struct pt_regs *regs, */ ...
May 24, 8:36 am 2008
Cyrill Gorcunov
[patch 01/11] x86: nmi - unify die_nmi() interface
By slightly changing 32bit mode die_nmi() we may unify the interface and make it common for both (32/64bit) modes Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Index: linux-2.6.git/arch/x86/kernel/nmi_32.c ==================================================================== --- linux-2.6.git.orig/arch/x86/kernel/nmi_32.c 2008-05-24 19:22:41.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/nmi_32.c 2008-05-24 19:22:47.000000000 +0400 @@ -320,8 +320,6 @@ void ...
May 24, 8:36 am 2008
Stefan Richter
[PATCH] firewire: clean up fw_card reference counting
This is a functionally equivalent replacement of the current reference counting of struct fw_card instances. It only converts it to common idioms as suggested by Kristian Høgsberg: - struct kref replaces atomic_t as the counter. - wait_for_completion is used to wait for all card users to complete. BTW, it may make sense to count card->flush_timer and card->work as card users too. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> --- Applies after patch "firewire: clean up ...
May 24, 7:50 am 2008
Stefan Richter
[PATCH] firewire: clean up some includes
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> --- drivers/firewire/fw-transaction.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux/drivers/firewire/fw-transaction.h =================================================================== --- linux.orig/drivers/firewire/fw-transaction.h +++ linux/drivers/firewire/fw-transaction.h @@ -20,12 +20,12 @@ #define __fw_transaction_h #include <linux/device.h> -#include <linux/timer.h> -#include ...
May 24, 7:48 am 2008
Stefan Richter
[PATCH] firewire: remove unused struct members
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> --- drivers/firewire/fw-card.c | 1 - drivers/firewire/fw-device.h | 1 - drivers/firewire/fw-ohci.c | 1 - drivers/firewire/fw-transaction.h | 2 -- 4 files changed, 5 deletions(-) Index: linux/drivers/firewire/fw-card.c =================================================================== --- linux.orig/drivers/firewire/fw-card.c +++ linux/drivers/firewire/fw-card.c @@ -497,7 +497,6 @@ ...
May 24, 7:46 am 2008
Stefan Richter
[PATCH] firewire: implement broadcast_channel CSR for 13 ...
See IEEE 1394a clause 8.3.2.3.11. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> --- drivers/firewire/fw-card.c | 1 + drivers/firewire/fw-transaction.c | 20 +++++++++++++++++--- drivers/firewire/fw-transaction.h | 4 ++++ 3 files changed, 22 insertions(+), 3 deletions(-) Index: linux/drivers/firewire/fw-card.c =================================================================== --- linux.orig/drivers/firewire/fw-card.c +++ linux/drivers/firewire/fw-card.c @@ ...
May 24, 7:41 am 2008
許欣怡
珍珠墬鏈禮盒每盒特價$600
您2008想5給24心愛的另ㄧ半ㄧ份24驚5喜2008嗎? 近5來5看5看,試5試5這5個5喔 ^.^ 珍23珠23貝23殼23項23鍊23禮23盒 ~ 日23本23九23州23空23運23來23台 網址在這→203.70.179.39/ju←複製這行網址貼上即可 ×∵⊙?▽
May 24, 6:05 am 2008
Octavian Purdila
[announce] linux kernel library project
Hi everybody, The purpose of the Linux Kernel Library project is to organize the Linux kernel code in a library which can be used in third party projects. It strives to be portable across hardware platforms, operating systems, as well as kernel and user-space environments. The library prototype we developed was tested with a few applications (prototypes as well): - portable FTP daemon (using the Apache Runtime Library) which can be used to read/write Linux filesystems - windows ...
May 24, 4:44 am 2008
Jeremy Fitzhardinge
[PATCH] xen: make earlyprintk=xen work again
For some perverse reason, if you call add_preferred_console() it prevents setup_early_printk() from successfully enabling the boot console - unless you make it a preferred console too... Also, make xenboot console output distinct from normal console output, since it gets repeated when the console handover happens, and the duplicated output is confusing without disambiguation. [ Applies to end of xen pvfb series ] Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> Cc: ...
May 24, 1:19 am 2008
David Greaves
[REPORT] anticipatory: forced dispatching is broken
I am guessing these things are linked.. [24243.778594] anticipatory: forced dispatching is broken (nr_sorted=1), please report this [24243.831710] ------------[ cut here ]------------ [24243.831808] WARNING: at block/blk-barrier.c:252 blk_do_ordered+0x1f0/0x228() [24243.831901] Modules linked in: lirc_serial lirc_dev dm_mod stv0299 msp3400 saa7127 saa7115 tuner tea5767 tda8290 tda18271 tda827x tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 psmouse budget_ci budget_core ivtv dvb_core ...
May 24, 1:07 am 2008
Steven Rostedt
[PATCH RT] remove user_trace_stop
[ Doing a full config compile I came up with this ] Remove user_trace_stop that was more of a hack to debug xrun latencies. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- sound/core/pcm_lib.c | 1 - 1 file changed, 1 deletion(-) Index: linux-2.6.24.7-rt10/sound/core/pcm_lib.c =================================================================== --- linux-2.6.24.7-rt10.orig/sound/core/pcm_lib.c 2008-05-24 00:53:24.000000000 -0400 +++ ...
May 23, 11:18 pm 2008
Steven Rostedt
2.6.24.7-rt10
We are pleased to announce the 2.6.24.7-rt10 tree, which can be downloaded from the location: http://rt.et.redhat.com/download/ Information on the RT patch can be found at: http://rt.wiki.kernel.org/index.php/Main_Page Changes since 2.6.24.7-rt9 - ported latest ftracers (Steven Rostedt) - vdso vsyscall generic (Luis Goncalves) - git-ignore update (Hiroshi Shimamoto) - lockstat updates (Peter Zijlstra) - Adjust pi_lock in wakeup waiters (Peter Morreale) - ...
May 23, 10:51 pm 2008
lltyr7652
--12 19 29【月薪百萬】最簡單日本証照,讓天才彼
29 2008 3ca084f9-08fd-46a6-b6ec-ecfb5377c3b0 ★8★5★2008年日本通譯案內士考試:考前104天:★2★0★ ★★★您懂日文或曾經學過日文嗎?★★★★      月薪百萬台幣的簡單日本証照     這項對台灣人相當容易 考的日本執照考試告訴您:日本通譯案內士考試:只要考 簡單科目即可.不會比台灣的大學時期的期中考難喔.. 不必去坊間高價而效果有限補習班.告訴您自修即可簡單 自力達成方法..  (我們免費提供考試必須的:日本轉信地址) ★★★99個國家如何去留學?★★★★ 及40個低學費國家去留學.您想留學高學費的英日語以 外國家卻求助無門嗎?您知道全世界有40個國家大學. 研究所.博士班免費..這裡告訴您求助管道.. ★★★99國語言如何去學習法?★★★★ 歐洲人精通5.6國語言是家常便飯..您想精通數國以上語言竟求助無門嗎? 請電 0 9 1 2 2 8 4 5 9 9張小姐詢問 想了解更多請至 ...
May 23, 9:38 pm 2008
Matt Domsch
Re: [PATCH] edd: consolidate error checks
Looks reasonable, but I haven't had a chance to test this. Will do so next week. Thanks, Matt -- Matt Domsch Linux Technology Strategist, Dell Office of the CTO linux.dell.com & www.dell.com/linux --
May 23, 10:24 pm 2008
Akinobu Mita
[PATCH] edd: consolidate error checks
Many show operations in edd_attribute have same error checks at the head. This patch consolidates these error checks to callee function. Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Matt Domsch <Matt_Domsch@Dell.com> --- drivers/firmware/edd.c | 74 ++++++++++++++++++++----------------------------- 1 file changed, 31 insertions(+), 43 deletions(-) Index: 2.6-git/drivers/firmware/edd.c =================================================================== --- ...
May 23, 7:05 pm 2008
Akinobu Mita
[PATCH] edd: fix error paths in module_init
This patch fixes error handlings when kzalloc() or edd_device_register() failed in module_init. It needs to clean registered edd_devices before return error. Also this patch fixes return value of module_init. module_init should not return positive value. Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Matt Domsch <Matt_Domsch@Dell.com> --- drivers/firmware/edd.c | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) Index: ...
May 23, 7:03 pm 2008
Akinobu Mita
Re: [PATCH] edd: fix error paths in module_init
OK. This is update patch. From: Akinobu Mita <akinobu.mita@gmail.com> Subject: edd: fix error paths in module_init If kzalloc() or edd_device_register() failed in module_init, it returns error without cleanup the devices already registered. Rather than fixing it to back completely out (unregister everything that had successfully registered until now) and return error, This patch makes it have succeeded. Because having even the first device be reported, even if the others couldn't ...
May 24, 1:13 am 2008
Matt Domsch
Re: [PATCH] edd: fix error paths in module_init
Thanks for these. You caught me on holiday; I'll take a more thorough Wouldn't WARN_ON() and return failure be sufficient? I hate crashing I didn't really like my initial approach, but the question was: when you hit a failure, do you try to back completely out (unregister everything that had successfully registered until now), or do you leave the things that have succeeded, and only fail the current and future devices? For my purposes, having even the first device be reported, even if ...
May 23, 10:22 pm 2008
Stefan Richter
Re: floppy question of the hour
(Adding Cc: block layer maintainer for no solid reason...) There was only a single change to drivers/block/floppy.c after 2.6.25: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7afea3... [...] By "until it(2.6.26-rc1) went away" you mean a crash during writing to or reading from the FDD, or during general usage? -- Stefan Richter -=====-==--- -=-= ==--- http://arcgraph.de/sr/ --
May 24, 2:28 am 2008
Gene Heskett
Re: floppy question of the hour
Floppy has not worked well for me since about the 2.6.22 time frame. But I was usually able to make it work with minimal fussing before that, and there was a period where it appeared that fdutils-5.4 worked better than 5.5 too. I don't know just yet. On a whim yesterday after posting this, I rebuilt 2.6.26-rc2 with the floppy as a module, and with one or two hiccups, like setfdprm might have to be done more than once after the disc is inserted, it worked nominally well, whereas if ...
May 24, 5:52 am 2008
Gene Heskett
floppy question of the hour
Greetings all; Who is the maintainer of drivers/block/floppy.c and associated files? I ask because there are a few of us still using it, in particular with what some may call oddball disk formats & I'm up to here with doing such as this: [root@coyote coco3]# setfdprm /dev/fd0 COCO7203.5 [root@coyote coco3]# getfdprm /dev/fd0 get geometry parameters: No such device Or: Assuming the above took, [root@coyote coco3]# dd if=/dev/fd0 of=test.dsk dd: reading `/dev/fd0': Input/output ...
May 23, 6:14 pm 2008
Fausto Richetti Blanco
Pipe buffers' limit of 16 * 4K
Hello guys, I'm working with a 2.6.9 kernel (ok, I know it's quite old) and faced a problem with the 4K (one page) buffer limit for the pipes. I've found that in the 2.6.11 the pipes' buffers were changed to a circular list of pages which increased this limit to 16 * 4K. This limit is hardcoded here /usr/src/linux/include/linux/pipe_fs_i.h:6 #define PIPE_BUFFERS (16) Is there a reason for this not to be an adjustable parameter (eg.: by an ulimit in the userspace) ? ...
May 23, 5:19 pm 2008
Rik van Riel
Re: Pipe buffers' limit of 16 * 4K
On Fri, 23 May 2008 21:19:13 -0300 What is the problem you found? Why do you need to change the limit from 16? Did it bring you any performance enhancements? If so, how much? -- All rights reversed. --
May 23, 5:56 pm 2008
Diego Calleja
Re: [PATCH 2/2] Only print "Decompressing Linux" etc whe ...
And there's already a parameter to switch the verbosity of printk - 'quiet' --
May 24, 11:07 am 2008
Rik van Riel
Re: [PATCH 1/2] Use structs instead of hardcoded offsets ...
On Fri, 23 May 2008 17:59:27 -0400 People who wonder why these pointers never get initialized: they point to the zeropage, which of course lives at address zero. /* The so-called "zeropage" */ struct boot_params { struct screen_info screen_info; /* 0x000 */ struct apm_bios_info apm_bios_info; /* 0x040 */ __u8 _pad2[12]; /* 0x054 */ struct ist_info ist_info; /* 0x060 */ ... -- ...
May 23, 6:07 pm 2008
H. Peter Anvin
Re: [PATCH 1/2] Use structs instead of hardcoded offsets ...
Uhm... except it doesn't live at address zero, at all. It's called "zeropage" because we used to recycle it into empty_zero_page, a long long time ago. The bootparms structure is pointed to by %esi being passed from the setup code to the decompressor to the kernel. -hpa --
May 23, 11:17 pm 2008
Mikael Pettersson
Re: [PATCH 2/2] Only print "Decompressing Linux" etc whe ...
=?utf-8?q?Kristian=20H=C3=B8gsberg?= writes: > Signed-off-by: Kristian Høgsberg <krh@redhat.com> > --- > arch/x86/boot/compressed/misc.c | 30 +++++++++++++++++++++++++++--- > 1 files changed, 27 insertions(+), 3 deletions(-) How is this an improvement? What bug does it fix? Is there any evidence that these messages are harmful for end-users? All this accomplishes is to make early boot failures harder to debug. --
May 24, 2:25 am 2008
Max Krasnyanskiy
Re: [PATCH] [genirq] Expose default irq affinity mask
There is not going to be whole a lot of documentation for this. Basically the commit comment is what will be in the documentation. In other words I do not think it'll help you with the review. Max --
May 23, 5:39 pm 2008
Paul Jackson
Re: [PATCH] [genirq] Expose default irq affinity mask
> In other words I do not think it'll help you with the review. I really do prefer to encourage people to include the Doc changes in their submitted patches. It does make it easier to review, and the Doc changes are part of what needs to be reviewed. I will do my best to complete my review, and I will most likely ack this patch, once it is complete. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson ...
May 23, 5:53 pm 2008
Andras Mantia
Re: libata (pata_via) timeouts causing unusable device: ...
So far: pci=nomsi does not help pci=nomsi acpi=off noapic works pci=nomsi noapic also works I will try noapic only as well and report. Andras -- Quanta Plus developer - http://quanta.kdewebdev.org K Desktop Environment - http://www.kde.org --
May 24, 6:12 am 2008
Jeff Garzik
Re: libata (pata_via) timeouts causing unusable device: ...
Generally you only want to use one of those... Jeff --
May 24, 8:35 am 2008
Sam Ravnborg
Re: kernel coding style for if ... else which cross #ifdef
We could do that - but then it would need another name not to clash with all the places where we rely on CONFIG_FOO='n' => CONFIG_FOO is not defined. We could teach kconfig to emit something like: #define KFOO 0 (for the 'n' value) And 1 or 2 for the y and m values. Sam --
May 23, 10:43 pm 2008
Willy Tarreau
Re: kernel coding style for if ... else which cross #ifdef
I use it in some of my code (but moderately). It's particularly useful for limit checking such as above. It's useful too when you want to use the config value as an offset or a bit shift. Eg: p = malloc(buf_size << (CONFIG_SHIFT-0)); Willy --
May 24, 7:46 am 2008
Jeremy Fitzhardinge
Re: kernel coding style for if ... else which cross #ifdef
Well, you could use "enum { config_foo = 0/1 }" to define a proper C constant. But it means you could only use them in C, not in CPP or asm expressions. J --
May 24, 9:02 am 2008
H. Peter Anvin
Re: kernel coding style for if ... else which cross #ifdef
Sorry, we already have CONFIG_FOO (meaning =y) and CONFIG_FOO_MODULE (meaning =m). This seems to work well and will generally do the right thing. If we had CFG_FOO=2 for the case of FOO=n then the clean use of: if (CFG_FOO && blah)... -hpa --
May 24, 11:08 am 2008
Sam Ravnborg
Re: kernel coding style for if ... else which cross #ifdef
Because then the CONFIG_* is not changed and we do not want to change that. But on the other hand it is only in odd cases we distingush between built-in and module. For non-boolean/tristate values we simply skip CFG_ values - thats the most simple approach. Sam --
May 24, 4:27 am 2008
H. Peter Anvin
Re: kernel coding style for if ... else which cross #ifdef
I think that would be a massive disadvantage. Furthermore, they *can* (and arguably *should*) still be used for the preprocessor; something like: #if CFG_BLUTTAN ... at least can be configured to warn on a typo. -hpa --
May 24, 11:12 am 2008
Sam Ravnborg
Re: kernel coding style for if ... else which cross #ifdef
We should actually do as you intially suggested and alwyas define CONFIG_FOO no matter if FOO is built-in or module. Because we do only want to distingush between the two in rare cases. But that is a separate patch and lets not do the same mistage with CFG_* I cooked up following patch - but I have not test-build a kernel yet. We may use CFG_* here and there and clash is not good. Sam diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index ee5fe94..98a2c39 ...
May 24, 8:36 am 2008
H. Peter Anvin
Re: kernel coding style for if ... else which cross #ifdef
I don't think we want to use "1 or 2"... I suspect we want to use the same booleans we currently have. I would suggest CFG_* instead of CONFIG_* for the new set. -hpa --
May 23, 10:42 pm 2008
H. Peter Anvin
Re: kernel coding style for if ... else which cross #ifdef
Well, that's pretty much what it was meant to be. -hpa --
May 24, 11:12 am 2008
Willy Tarreau
Re: kernel coding style for if ... else which cross #ifdef
You still have the possibility to use the "-0" trick : if (CFG_THINGY_LIMIT && x > (CONFIG_THINGY_LIMIT-0)) {...} Willy --
May 24, 7:39 am 2008
Jeremy Fitzhardinge
Re: kernel coding style for if ... else which cross #ifdef
I think pretty strongly that CFG_ and CONFIG_ should be exactly parallel. If you want to change the meaning of CONFIG_X in the presence of modules, then change CFG_X at the same time. Making them have different meanings will just confuse anyone wanting to convert #ifdef I have to say I'm not very keen on the CFG_* prefix. It doesn't have any inherent meaning and just looks like a redundant abbreviation of CONFIG_; something which actually expresses the notion that it's always a ...
May 24, 8:45 am 2008
Jeremy Fitzhardinge
Re: kernel coding style for if ... else which cross #ifdef
Oh, that's cute in a vile way. I hadn't seen it before. J --
May 24, 7:41 am 2008
Sam Ravnborg
Re: kernel coding style for if ... else which cross #ifdef
I'm a bit dense (or I need more coffe - it's morning here). Agreed. Sam --
May 23, 11:42 pm 2008
Jeremy Fitzhardinge
Re: kernel coding style for if ... else which cross #ifdef
I think CONFIG_ and CFG_ should be exact parallels, so if CONFIG_FOO is I suppose, but it might be useful to know whether a constant is present: if (CFG_THINGY_LIMIT && x > CONFIG_THINGY_LIMIT) {...} (which fails if CONFIG_THINGY_LIMIT is undefined, so I guess it still doesn't work very well). J --
May 24, 7:35 am 2008
Jeremy Fitzhardinge
Re: kernel coding style for if ... else which cross #ifdef
Yes, I'd agree if we were starting from scratch. But given that we can't get rid of CONFIG_* and their dubious semantics, we just have to make do. But typo-detection *would* be very nice: I can never remember if its CONFIG_MEMORY_HOTPLUG or CONFIG_HOTPLUG_MEMORY. J --
May 24, 1:51 pm 2008
Tom Spink
Re: kernel coding style for if ... else which cross #ifdef
I, of course, meant: #define CFGVAL_CONFIG_FOO 0 #define CFGVAL_CONFIG_BAR 1 #define CFGVAL_CONFIG_BAZ_MODULE 1 -- Tom Spink --
May 24, 9:42 am 2008
Sam Ravnborg
Re: kernel coding style for if ... else which cross #ifdef
We agree they should have the same semantics - we do just not agree on the timing. I would love to do a two patch set: 1) Introduce CFG_ 2) Alwyas define CONFIG_FOO in case of modules But I ned someone to audit the use of CONFIG_FOO before I do such a change. I could just do it - but I'm pretty sure it will hurt. And I do not want to introduce CFG_ with the same Of the above I would prefer KCONFIG_FOO if we do not go for the CFG_FOO version. That it is const is already given by being ...
May 24, 11:51 am 2008
H. Peter Anvin
Re: kernel coding style for if ... else which cross #ifdef
That can *strongly* be argued with. In particular, the use of #ifdef is crap to begin with. Using #if even for the preprocessor makes it possible to trap misspellings. -hpa --
May 24, 1:43 pm 2008
Jeremy Fitzhardinge
Re: kernel coding style for if ... else which cross #ifdef
They should be plain 0/1 booleans. For a bool/tristate option FOO, it would define: Enabled y: #define CONFIG_FOO #define CFG_FOO 1 #undef CONFIG_FOO_MODULE #define CFG_FOO_MODULE 0 Enabled m: #define CONFIG_FOO #define CFG_FOO 1 #define CONFIG_FOO_MODULE #define CFG_FOO_MODULE 1 Disabled n: #undef CONFIG_FOO #define CFG_FOO 0 #undef CONFIG_FOO_MODULE #define CFG_FOO_MODULE 0 Not sure what CFG_* should be for ...
May 24, 3:06 am 2008
Adrian Bunk
Re: kernel coding style for if ... else which cross #ifdef
A quite common pattern in the kernel is: #if defined(CONFIG_FOO) || (defined(CONFIG_FOO_MODULE) && defined(MODULE)) Your suggestion would require them to be changed to: #if (defined(CONFIG_FOO) && !defined(CONFIG_FOO_MODULE)) || (defined(CONFIG_FOO_MODULE) && defined(MODULE)) (We could push these cases to kconfig, but there might also be other cases where changing the existing semantics of CONFIG_FOO could cause breakages.) We see daily in kconfig that mixing tristates with bools is ...
May 24, 3:49 am 2008
Jeremy Fitzhardinge
Re: kernel coding style for if ... else which cross #ifdef
Well, in that case you could use Willy's magic hack: #define config_defined(x) (x - 0) Which isn't a bad alternative to defining a whole pile of new symbols... J --
May 24, 1:38 pm 2008
Tom Spink
Re: kernel coding style for if ... else which cross #ifdef
Hi, A thought occurred to me that we may be able to used some preprocessor magic and do this: #define config_defined(x) CFGVAL_## x Which means that, if we get Kconfig to produce: #define CFGVAL_CONFIG_FOO 0 #define CFGVAL_CONFIG_VALUE_BAR 1 #define CFGVAL_CONFIG_VALUE_BAZ_MODULE 1 We can use this: if (config_defined(CONFIG_FOO) && some_expr) { panic("Oh no."); } Thoughts? -- Tom Spink --
May 24, 9:40 am 2008
Vegard Nossum
Re: kernel coding style for if ... else which cross #ifdef
Don't know if this is really my place, but I could not agree more with your characterisation of the CFG_* prefix and I will make the following suggestion: Why not use all-lowercase config_* names? It seems elegant, and fits in with the notion that these are to be used not as macros, but as ordinary constants. (The only disadvantage I can see is that they will stand out less. But I don't know how great the disadvantage is.) You could even go further and make them real constants, ...
May 24, 8:57 am 2008
H. Peter Anvin
Re: kernel coding style for if ... else which cross #ifdef
That's a very defeatist stance, and quite frankly bogus. Doing it as a flag day event is not really practical, which is why we need a new set of symbols. However, at that point we can discourage continuing use of the CONFIG_ symbols and deprecate them over time. It's not like we're talking about user-space-visible interfaces here! -hpa --
May 24, 1:54 pm 2008
Jeremy Fitzhardinge
Re: kernel coding style for if ... else which cross #ifdef
Well, I'm thinking more along the lines of: 1. We introduce this <whatever> mechanism 2. Hundreds of people pop out of the woodwork thinking "this looks more fun than tweaking whitespace" 3. They produce one-hundred trillion "convert #ifdef to if()" patches 4. We have one-hundred trillion^2 followup "fix build with this .config" patches 3 might be enough to finally drive Andrew out of the kernel business, but 4 definitely would be. The whole point is to try ...
May 24, 2:15 pm 2008
David Brownell
Re: [RFC] OpenFirmware bindings for the MMC-over-SPI driver
Summary: an OF-specific wrapper around the mmc_spi platform code. I think a wrapper to encapsulate all the OF-specific knowledge makes much sense here. The only thing that looks odd to me about this is that the wrapper is a spi_device rather than an of_device. To me it makes more sense to just have an of_device setting up the right spi_device. (Though maybe I missed some discussion about why that can't work.) Example: drivers/usb/host/sl811_cs.c does that for PCMCIA card that just ...
May 24, 12:56 pm 2008
Segher Boessenkool
Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for t ...
It's perfectly acceptable. The sole purpose of "compatible" is for a client (i.e., the kernel) to decide what to do with this device; most often, to decide what driver to use. It would be nice to have a completely generic thing that matches device tree nodes to drivers, and it sounds perfectly reasonable to me to go via modalias for that (i.e., just translate from device tree namespace to the kernel driver namespace). As a bonus, it would make driver matching more correct in some ...
May 24, 4:14 pm 2008
Segher Boessenkool
Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for t ...
You mean, "does this node define a bus". If it doesn't, there shouldn't be #a and #s; if it does, the binding should describe what the addressing is. #a = #s = 0 describes a bus without any Yes please. There's a good chance that it doesn't turn out to be Linux-specific at all (after some modification, perhaps). Segher --
May 24, 4:06 pm 2008
Jochen Friedrich
Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for t ...
i2c exactly has the same problem. Here the compatible entry is used in drivers/of/of_i2c.c and mangled into a name to be used as modalias. It's still sort of hackish, but it seems to be a compromise acceptable by both OF and i2c folks. Thanks, Jochen --
May 24, 7:32 am 2008
Stephen Rothwell
Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for t ...
Hi Anton, On Fri, 23 May 2008 22:28:42 +0400 Anton Vorontsov <avorontsov@ru.mvista.co= If you delay this assignment, you may not have to clean it up in the Maybe you should do this last so that you don't leak more than necessary if mmc_spi_remove fails. (I don't know what state mmc_spi_remove leaves This is initialised by spi_register_driver(). --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
May 23, 7:35 pm 2008
Grant Likely
Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for t ...
Yup, I like this approach better. I had been thinking about putting this all in the same file (drivers/mmc/host/mmc_spi.c) instead of exporting the probe/remove symbols and by using clear comment blocks to divide the sections, but I've got no issues with this approach. This is good work. Some comments below. (I won't repeat Stephen's comments) On Fri, May 23, 2008 at 12:28 PM, Anton Vorontsov I'm not even sure if the whole linux,modalias is even a good idea. I had kind of thrown it in ...
May 23, 10:19 pm 2008
Andrew Morton
Re: cpufreq limits avilable frequencies to 800MHz on git ...
Thanks. Is this a newly-occurring bug or did earlier kernels do this also? If it was newly added, do you know in which kernel version we might have added it? --
May 23, 6:25 pm 2008
Theodore Tso
Re: Top 10 bugs/warnings for the week of March 23rd, 2008
Not really. It's on my todo list but fixing a bug caused by users doing something stupid (pulling a mounted USB stick) has been lower than a number of other fires burning on my plate. I'll try to get to it but a lot of other things I need to worry about have deadlines associated with them.... - Ted --
May 24, 3:45 pm 2008
Jan Kara
Re: Top 10 bugs/warnings for the week of March 23rd, 2008
Is someone looking into this? It could be somehow connected with commit 1be62dc190ebaca331038962c873e7967de6cc4b where we add smp_mb() to mark_buffer_dirty() under some circumstances. But I don't really see how. The WARN_ON() being triggered is !buffer_uptodate(bh) but that seems ridiculous for call paths like ext2_sync_super() -> mark_buffer_dirty() or journal_destroy() -> journal_update_superblock() -> mark_buffer_dirty() which are in oopses. Also this warning started appearing only recently ...
May 24, 3:23 pm 2008
Chris Wright
Re: Top 10 bugs/warnings for the week of March 23rd, 2008
looking at first one: http://www.kerneloops.org/raw.php?rawid=13598&msgid= OK, aside of the obvious (their problem): Tainted: P EIP is at task_has_capability+0x48/0x76 Code: ... <0f> 0b ^^^^^^^ BUG() This should be listed under the BUG/BUG_ON category as opposed to oops, no? Also, I think the raw data is missing some bit. Where is the: kernel BUG at... At any rate, they have a bug in their proprietary module (news at 11). So, I don't think this should make ...
May 23, 5:15 pm 2008
Greg KH
Re: Top 10 bugs/warnings for the week of March 23rd, 2008
Note, only the older 2.6.24 and possibly .25 versions of this are my "fault", as those come from the usb core. That's a bug that I thought we fixed, and I can not duplicate it myself at all. Other instances of this are real problems in other areas of the kernel (like the pci hotplug drivers), and are not my fault :) If anyone knows of a way to constantly reproduce this issue with a USB device, please contact me and I'll work to resolve this. Arjan, thanks a lot for these reports, I find ...
May 23, 10:32 pm 2008
Arjan van de Ven
Re: Top 10 bugs/warnings for the week of March 23rd, 2008
yes absolutely; this is a question I'll have for the customers of the data... do people want to see "only-tainted" in these top 10s? Right now I mark them as such but leave them in. It's trivial for me to just leave them out instead (the info is there, yeah iirc the AMD graphics driver gives the user process full root caps for some time... Annoying things these non-root linux users ;) --
May 23, 10:07 pm 2008
Arjan van de Ven
Re: Top 10 bugs/warnings for the week of March 23rd, 2008
On Sun, 25 May 2008 00:23:04 +0200 Ted looked at these during the LF summit, and his conclusion was that they're all media errors (eg USB unplug) that ext3 then did not handle well at all. Maybe Ted has an update on this? the 2.6.24-rc is a red herring btw.. that's just the first kernel version that actually printed its version as part of WARN_ON(). --
May 24, 3:30 pm 2008
Andrew Morton
Re: [PATCH] Add switch for dock events
Confused. This patch doesn't do anything. Also, please sort out the changelogging? - The one-line changelog you have there would make a decent _title_. Better than the one which was actually chosen. - The not-to-be-included discussion which you have below the "---" cutoff line would make a reasonable changelog. --
May 23, 6:23 pm 2008
Linus Torvalds
Re: [PATCH 0 of 4] mm+paravirt+xen: add pte read-modify- ...
It's not that it's not "very useful" - it's that it would be TOTALLY WRONG. If you change the page and the AD bits can change randomly while you do so, that means that the AD bits are now _undefined_. Which of the two pages did it happen to? The old one? The new one? Nobody can know. So you'd effectively have dirty bits that could be associated with the wrong physical page, which means that some page may be dirty, but the kernel would have it marked clean. That would be beyond ...
May 24, 10:25 am 2008
Jeremy Fitzhardinge
Re: [PATCH 0 of 4] mm+paravirt+xen: add pte read-modify- ...
Sorry, I was using ironic understatement. I meant "...while preserving the AD bits, but I think that would be totally fucking stupid". J --
May 24, 1:44 pm 2008
Marcel Holtmann
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
I explained this a couple of times. The request_firmware() is an abstract mechanism that can request a firmware file. The location of the firmware file is up to the userspace. The kernel requests a particular file and that is it. All namespacing has to be done by the firmware helper script (nowadays udev). That the current implementation of the firmware helper maps the filename 1:1 to a file under /lib/firmware/ just works, but doesn't have to work all the time. It is not the ...
May 24, 12:31 pm 2008
David Woodhouse
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
Hm. Is there any fundamental reason why we should forbid this? It does seem to make sense to let people use the namespace for it. -- dwmw2 --
May 24, 12:23 pm 2008
David Woodhouse
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
It doesn't seem to have that effect. Whatever I do, on 'make clean' the .o files are removed and the auto-generated .c files remain. Which is probably OK. -- dwmw2 --
May 24, 7:46 am 2008
Marcel Holtmann
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
so using "/" within the name parameter for request_firmware() is actually forbidden. I know that some driver authers think it is a good idea, but it is not. I am actually working on a patch to make request_firmware() fail/warn when the name has a "/" in it. You don't need to consider any deep nesting of firmware file names. It was never meant to be used like this. Regards Marcel --
May 24, 11:18 am 2008
Sam Ravnborg
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
strange - like 'make clean' does not vist this directory?? The .o files are deleted using a simple find ... which explain why they are hit. I have not applied your patches but if you d not see issues with it I wil not try to chase it further atm. Sam --
May 24, 8:22 am 2008
David Woodhouse
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
Here's what I have (on top of the git tree) now. I just need to sort out the clean/mrproper behaviour -- and possibly should rename the korg firmware to firmware/korg/k1212.c_shipped? commit 728aa4212690701823ce3dcf22816f3953923530 Author: David Woodhouse <dwmw2@infradead.org> Date: Sat May 24 11:56:32 2008 +0100 firmware: move firmware files into firmware/ Signed-off-by: David Woodhouse <dwmw2@infradead.org> diff --git a/firmware/Makefile b/firmware/Makefile index ...
May 24, 8:34 am 2008
David Woodhouse
Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
Playing with it now. I fixed the mkdir thing by including $(objtree) in the target. -- dwmw2 --
May 24, 8:25 am 2008
Andrew Morton
Re: [RFC] Circular include dependencies
(cc's added). Thanks. I'm not sure who we could tap for the topology.h one. A suitable (and often good) way of solving this is to identify the things which a.h needs from b.h and hoist them out into a new c.h and include that from both a.h and b.h. --
May 23, 6:17 pm 2008
Eric W. Biederman
Re: correction to compat_sys_kexec_load
The architecture parameter is the architecture of the running kernel that implements sys_kexec_load. Because it is a pain for testing and in general impossible we don't change cpu modes during a kexec. So a 32bit caller of sys_kexec_load will need to passing in different code if it is running on a 32bit or a 64bit kernel. The trampoline code in /sbin/kexec does change modes on x86 when appropriate. Caring if you know the architecture in the unload case is a bit silly. As there is no ...
May 23, 5:36 pm 2008
Arjan van de Ven
Re: [PATCH 3/3] futex: fix miss ordered wakeups
On Sat, 24 May 2008 12:19:34 -0700 nope. Don't look at the release path... look at the acquire path. If a thread sees the futex is free, it'll take it, without even going to the kernel at all. So you have the situation where the kernel spends a lot of time finding the "perfect" candidate to wake up, but kaboom some other thread just happens to try to get the mutex between the wakeup and the acquire of the wakee.. and just "steal" the lock. --
May 24, 1:34 pm 2008
Daniel Walker May 24, 10:24 am 2008
Thomas Gleixner
Re: [PATCH 3/3] futex: fix miss ordered wakeups
This is a solution looking for a problem. Normal futexes have no ordering guarantees at all. There is no mechanism to prevent lock stealing from lower priority tasks. So why should we care about the once a year case, where a sleepers priority is modified ? { .... There are more issues vs. pi futexes as well. The simple case of futex_wait() vs. futex_adjust_waiters will just upset lockdep, but there are real dealocks vs. unqueue_me_pi waiting. Thanks, tglx --
May 24, 1:55 am 2008
Daniel Walker
Re: [PATCH 3/3] futex: fix miss ordered wakeups
Lock stealing? The usage of sched_setscheduler is fairly pervasive in userspace, if a task becomes SCHED_FIFO it did so via sched_setscheduler. So I don't think this is at all "once a year". Tasks shouldn't be forced to determine if a task is sleeping or not before it There are degree's of overhead with each step.. Someone may not need or You mean the lock ordering would cause the deadlock vs. unqueue_me_pi , or are you talking about something else? Daniel --
May 24, 8:32 am 2008
Thomas Gleixner
Re: [PATCH 3/3] futex: fix miss ordered wakeups
Do you have the faintest idea how the futex code works at all ? There is no guarantee that the task which is woken up first gets the futex. A) A task on another CPU can get it independent of its priority Sigh. sched_setscheduler is usually done during the startup and not in the A sane written program which uses RT priorities does none of this and Do I write Chinese or what ? Thanks, tglx --
May 24, 10:03 am 2008
Thomas Gleixner
Re: [PATCH 3/3] futex: fix miss ordered wakeups
And it works this way even after the plist code. May I politely suggest, that you carefully read futex_wake() and the corresponding libc implementation and figure out why there is no guarantee and why there can't be one? Sorry, I'm not abusive. You make claims about correctness and you seem to believe that the plist code gives guarantees except for the setscheduler corner case, but your hypothesis is simply wrong: There is no kernel side controlled handover of a normal futex. The woken ...
May 24, 11:35 am 2008
Ulrich Drepper
Re: [PATCH 3/3] futex: fix miss ordered wakeups
That's your claim. Again, almost nobody outside the realm of embedded fortunately uses priorities. It's a complete waste of time almost all programs, certainly all but one or two on any of my systems. There is already a solution for priority wakeup. Use it and don't punish everybody else for your needs. --
May 23, 8:38 pm 2008
Daniel Walker
Re: [PATCH 3/3] futex: fix miss ordered wakeups
After reading futex_wake, Doesn't it depend how many waiters are woken? Given that comes from userspace, glibc could wake a single waiter and If that's the requirement then code that cleans up the corner case that I've identified, which is also minimal should be acceptable .. Since it's meeting the same requirement you layed out above for the original plist changes. Daniel --
May 24, 12:19 pm 2008
Kevin Winchester
Re: [RFC] x86: Switch apm to unlocked_kernel
(Added Stephen to cc as he is the maintainer here) After looking at this for a while to figure out the necessary locking, I discovered drivers/char/apm_emulation.c, which has very similar structures to arch/x86/kernel/apm_32.c, and has much more locking (e.g. A state_lock mutex, a user_list_lock rwsem) and it uses a list_head for the apm_user_list instead of an open coded doubly linked list. This brought up the following question: - Should I just copy the locking from apm_emulation to ...
May 24, 11:59 am 2008
Greg KH
Re: [PATCH 1/1] UIO: Add a write() function to enable/di ...
Why not just a new sysfs file for the uio device, irq_enabled, or something like that? That way our main read/write path is left alone. thanks, greg k-h --
May 23, 9:43 pm 2008
Hans J. Koch
Re: [PATCH 1/1] UIO: Add a write() function to enable/di ...
Hi Greg, this is in a fast path, so I'm not sure if a sysfs file is not too much overhead. Special devices in embedded boards sometimes generate a considerable irq load, and I think it might be problem to do a sysfs write operation a few thousand times per second. Thanks, Hans --
May 24, 3:20 pm 2008
Thomas Gleixner
Re: [PATCH 1/1] UIO: Add a write() function to enable/di ...
It makes a certain amount of sense to use write. You hold the device file descriptor anyway for the read (wait for interrupt) operation, so using the same file descriptor is not a too bad idea: while (!stop) { /* wait for interrupt */ read(fd); do_stuff(); /*reenable interrupt */ write(fd); } I thought about using a sysfs entry for a while, but looking at the actual use case made the write() solution a more natural choice. Thanks, tglx --
May 24, 3:22 pm 2008
Tom Spink
Re: [PATCH 1/1] UIO: Add a write() function to enable/di ...
I thought ioctl would be more natural, as [en,dis]abling interrupts is -- Tom Spink --
May 24, 3:34 pm 2008
Tom Spink
Re: [PATCH 1/1] UIO: Add a write() function to enable/di ...
Simpler implementation, simpler use and future-proofing (in the sense Fair enough :-) symmetry is good. This is pretty much the response I -- Tom Spink --
May 24, 4:00 pm 2008
Leon Woestenberg
Re: [PATCH 1/1] UIO: Add a write() function to enable/di ...
Hello, We don't want to be future-proof? With kernel UIO and userspace driver in seperate source repositories, expect serious API drift in the longer term. I.e. the UIO interface *Currently*, read() and write() only deal with irq handling. In the future you might want to add a second control. I cannot think of what that should be now, much like it was not foreseen a write() So that *if* we have a second write()able location (again, for something I cannot foresee now), you at least check ...
May 23, 5:02 pm 2008
Thomas Gleixner
Re: [PATCH 1/1] UIO: Add a write() function to enable/di ...
Oh no. We are not going to open the bottomless pit of ioctls in UIO. Once we have an ioctl channel in place we have the same mess which we want to avoid in the first place. Also when a driver needs more than the obvious interrupt wait / control functions (which are pretty symetric btw.) aside of the mmapped access to the device then it does not belong into the category of an UIO driver. Thanks, tglx --
May 24, 3:46 pm 2008
Evgeniy Polyakov
Re: pagevecs of more than PAGEVEC_SIZE pages
It depends. In usual life with not that big requests and 64bit arch (or low mem pages on 32 bit x86) difference is marginal, but with high-pages kernel_sendpage() has only single page argument, but that should not be a problem, since stack will combine multiple pages into single skb if needed (if it can, especially for stuff like TSO/GSO), so just loop for whatever you fetched pages via find_get_pages_tag() and send them one-by-one, network stack will coalesce them by itself. But note that ...
May 24, 3:38 am 2008
Tetsuo Handa
Re: [git patch] vfs: permission API cleanup (v2)
Hello. I tried to insert a new LSM hook for truncate operation, but I had to insert security_path_truncate() hook into multiple locations since do_truncate() is directly called from some locations. http://svn.sourceforge.jp/cgi-bin/viewcvs.cgi/*checkout*/trunk/2.2.x/tomoyo-lsm/patche... Is it possible to replace do_truncate() and file_truncate() with path_truncate() so that security_path_truncate() is called from only ...
May 23, 9:04 pm 2008
Andrew G. Morgan
Re: capget() overflows buffers.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Chris Wright wrote: | Hmm, it would be kind of nice to have a formalized way get the size, | perhaps it would help with KaiGai's request for caps printed out. | Something that tells us either the number of u32s, or the max bit | supported? Serge has already provided one with the call, ~ sys_prctl(PR_CAPBSET_READ, x); returns -EINVAL if (x > max-supported-capability). (Ref: 3b7391de67da515c91f48aa371de77cb6cc5c07e) |> | All looks ...
May 23, 9:40 pm 2008
Chris Wright
Re: capget() overflows buffers.
It's dropped privileges to help mitigate any security related bug it may contain. It's conceivable (albeit remote[1]) that fork/exec plus That's it. thanks, -chris [1] Get lucky combo in the garbage bits and have not shed uid 0. Much less likely. --
May 24, 1:07 am 2008
Chris Wright
Re: capget() overflows buffers.
Yes, like the one in the patch I sent that added a warn_broken_capability_use(). thanks, -chris --
May 24, 1:17 am 2008
Chris Wright
Re: capget() overflows buffers.
Doh, I missed the leading portion of the pathname (cscope -p3 didn't Hmm, it would be kind of nice to have a formalized way get the size, perhaps it would help with KaiGai's request for caps printed out. Something that tells us either the number of u32s, or the max bit Yes, thanks. But I still think we need to print a warning (unfortunately we can't distinguish libcap from non-libcap app), because apps that aren't using libcap should really be updated (either pull new update from vendor or ...
May 23, 6:09 pm 2008
Andrew G. Morgan
Re: capget() overflows buffers.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Chris Wright wrote: | caps is essentially | CAP_NET_BIND_SERVICE|CAP_SYS_CHROOT|CAP_SETGID|CAP_DAC_READ_SEARCH|CAP_SYS_RESOURCE | | linux_setcaps(cap_t caps) { | struct __user_cap_header_struct caphead; | struct __user_cap_data_struct cap; <-- 12 bytes on stack | memset(&caphead, 0, sizeof(caphead)); | caphead.version = _LINUX_CAPABILITY_VERSION; <-- v2 now | caphead.pid = 0; | memset(&cap, 0, sizeof(cap)); <-- start initializing 12 ...
May 23, 11:25 pm 2008
Andrew G. Morgan
Re: capget() overflows buffers.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Chris Wright wrote: | * Andrew G. Morgan (morgan@kernel.org) wrote: |> diff --git a/include/linux/capability.h b/include/linux/capability.h |> index f4ea0dd..f88b4db 100644 |> --- a/include/linux/capability.h |> +++ b/include/linux/capability.h |> @@ -34,9 +34,6 @@ struct task_struct; |> #define _LINUX_CAPABILITY_VERSION_2 0x20071026 |> #define _LINUX_CAPABILITY_U32S_2 2 |> |> -#define _LINUX_CAPABILITY_VERSION ...
May 23, 5:02 pm 2008
Mike Galbraith
Re: PostgreSQL pgbench performance regression in 2.6.23+
btw, the problem with 2.6.25.4 and this load is one and the same. With a 1:N load, you really don't want work generator waking all worker-bees on it's CPU. The patchlet below let's you turn it off. diff --git a/kernel/sched.c b/kernel/sched.c index 1e4596c..5641eb8 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -596,6 +596,7 @@ enum { SCHED_FEAT_START_DEBIT = 4, SCHED_FEAT_HRTICK = 8, SCHED_FEAT_DOUBLE_TICK = 16, + SCHED_FEAT_SYNC_WAKEUPS = 32, }; const_debug ...
May 24, 1:08 am 2008
Miklos Szeredi
Re: [patch 06/14] hfsplus: remove hfsplus_permission()
Heh, you just want me to do all the hard work :) OK, I'll go along: /mnt/a/x is a regular file ln /mnt/a/x /mnt/b/x rename /mnt/a/x /mnt/b/x/p & ln /mnt/b/x /mnt/a/q Neither ->rename nor ->link is required to be defined on x. The rename will first lock x, then a. The link will first lock a then x, AFAICS. This is probably just one of several ways to make it deadlock. Hmm? Miklos --
May 23, 11:59 pm 2008
Enrico Weigelt
Re: Suggestion About Kernel Releases
ACK. I, personally use the newest releases on mostly unimportant systems, where a kernel bug is ugly but not that bad. For production systems I use the stableized/well-tested distro kernels, eg. unmasked on Gentoo). If you're using such an distro, you already have an more tested kernel, less chance of bugs (than with vanilla). My suggestion istead is bringing these individual efforts from distros to some central point, let's call this "mature kernel". This (IMHO) wouldn't affect the ...
May 23, 8:11 pm 2008
Willy Tarreau
Re: Wired behaviour with IPv6 over PPP
Well, at least it has been working for years in kernel 2.4 for me with pppd 2.4.2b3 to 2.4.4 (I've not upgraded my firewall to 2.6 yet). So it has definitely been working at some point. Willy --
May 23, 9:29 pm 2008
Miquel van Smoorenburg
Re: 2.6.26: x86/kernel/pci_dma.c: gfp |= __GFP_NORETRY ?
And Andi wrote: So how about linux-2.6.26-gfp-no-oom.patch (see previous mail) for 2.6.26 ? Mike. --
May 24, 12:38 pm 2008
Tomas Winkler
Re: regression iwl3945/mac80211: association times out s ...
On Sat, May 24, 2008 at 9:29 PM, Michael S. Tsirkin It looks like also this issue should be fixed by ' mac80211: reorder channel and freq reporting in wext scan report' patch. http://article.gmane.org/gmane.linux.kernel.wireless.general/15177 Please try. Thanks Tomas --
May 24, 4:24 pm 2008
Michael S. Tsirkin
Re: regression iwl3945/mac80211: association times out s ...
As requested, more configuration and log files have been attached to this item. --
May 24, 11:29 am 2008
Gregory Haskins
Re: [PATCH 5/5] remove the extra call to try_to_take_lock
>>> On Fri, May 23, 2008 at 11:02 PM, in message <Pine.LNX.4.58.0805232301080.12686@gandalf.stny.rr.com>, Steven Rostedt Its not that we are saying it doesn't happen. Rather, we are saying the overhead of exiting from the second call (and only remaining call after this patch) is not as significant as it would seem on paper (based on empirical data). In essence, it adds an xchg to the steal-case which is not "great", but.... ..conversely, if the first test fails, the second test will *always* ...
May 23, 8:30 pm 2008
Steven Rostedt
Re: [PATCH 5/5] remove the extra call to try_to_take_lock
This would suggested that lock stealing doesn't happen. On lock stealing, this is the condition that is triggered and we have a nice quick exit. --
May 23, 8:02 pm 2008
Peter W. Morreale
Re: [PATCH 5/5] remove the extra call to try_to_take_lock
I should have made this more descriptive to eliminate the confusion. Lock stealing, upon entry to *slowlock(), almost never happens. By almost I mean out of ~2+M locks, only 10s of locks were granted from the original redundant attempt. (From manual instrumentation) I do not have exact numbers. Best, --
May 24, 7:11 am 2008
Yinghai Lu
Re: kernel boot hangs after x86: insert_resorce for lapi ...
On Fri, May 23, 2008 at 4:50 PM, Ciaran McCreesh how about /proc/iomem with pnpacpi=off? YH --
May 23, 5:05 pm 2008
Yinghai Lu
Re: kernel boot hangs after x86: insert_resorce for lapi ...
On Fri, May 23, 2008 at 6:09 PM, Ciaran McCreesh it's weird, you should have 00000 - 9f400: System RAM ===> is not showing up 100000 - d7ff0000: System RAM ===> is not showing up 100000000-11fffffff : System RAM YH --
May 23, 6:51 pm 2008
Yinghai Lu
Re: kernel boot hangs after x86: insert_resorce for lapi ...
please try to revert attached commit... it seems that your compiler is not happy... YH
May 23, 7:29 pm 2008
Ciaran McCreesh
Re: kernel boot hangs after x86: insert_resorce for lapi ...
--MP_/2AlIvHwc55xUh=g1dkRxHpi Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Fri, 23 May 2008 17:05:34 -0700 I've attached /proc/iomem from current head minus the original patch, with and without pnpacpi=3Doff. Thanks, --=20 Ciaran McCreesh --MP_/2AlIvHwc55xUh=g1dkRxHpi Content-Type: text/plain; name=iomem-normal.txt Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; ...
May 23, 6:09 pm 2008
David Brownell
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
... all the more reason to have the SPI glue go there too, matching the ACPI/PCI precedent as well as those others! --
May 24, 10:45 am 2008
Grant Likely
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
I would argue 'yes!' g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
May 24, 10:33 am 2008
Jochen Friedrich
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
Isn't the same true for drivers/of/gpio.c or drivers/of/of_i2c.c, as well? Thanks, Jochen --
May 24, 10:14 am 2008
Grant Likely
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
Okay, I wasn't sure. Will do. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
May 23, 11:26 pm 2008
David Brownell
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
It's not usable by *any* SPI master on a non-OF system though. I'd still rather see such translations in the OF-specific part of the source tree. Like drivers/acpi/pci_*.c code, this has more to do with the firmware interface than with bus (SPI) interface. Arguments could be made both ways here, but for the moment it makes more sense to me to keep this type of platform glue (be it OF, ACPI, arch-specific setup code, or whatever) together in the source tree and apart from the bus-specific ...
May 24, 10:43 am 2008
Grant Likely
Re: [spi-devel-general] [PATCH 3/4] spi: Add OF binding ...
Very good point. Okay, so we cannot assume any correlation between the number of CS lines and the number of child nodes to the SPI bus. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
May 23, 11:25 pm 2008
Grant Likely
Re: [PATCH 2/4] spi: split up spi_new_device() to allow ...
Ah, okay. I'm still a bit fuzzy on the device model conventions. I'll remove that then. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
May 23, 11:43 pm 2008
Grant Likely
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
On Sat, May 24, 2008 at 12:26 AM, Grant Likely I'm having second thoughts about this. I think this code is more SPI centric than it is OF centric. ie. it is usable by all spi masters in an OF enabled system, but it is not usable by all OF devices in an SPI enabled system. Or, in other words; it adds OF support to SPI, not the other way around. I think drivers/spi is the right place for this to live. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
May 24, 9:50 am 2008
David Brownell
Re: [spi-devel-general] [PATCH 3/4] spi: Add OF binding ...
That wasn't what I was implying ... all the devices hooked up to a given chipselect should be viewed as a single (albeit composite) child node. Now, the driver for that child node may want to expose lots of substructure. But that's no different from any other complex device, whose protocol happens to embed some notion of component addressing. It's just that in the case I mentioned, that addressing is a bit more externally visible than it is in some other cases. - Dave --
May 24, 12:13 am 2008
Grant Likely
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
Oh, of course the driver needs it! I'm not claiming otherwise. More what I mean is that the driver doesn't need to be loaded or even I do not dispute any of that. My point, however, is that pdata is typically used simply as a representation that is convenient for platform code to pass that data into the driver and that often drivers don't use that representation directly. Instead, the data is explicitly copied explicitly field by field into the driver at probe time and is not touched ...
May 23, 11:24 pm 2008
Grant Likely
Re: [PATCH 2/4] spi: split up spi_new_device() to allow ...
On Sat, May 24, 2008 at 12:43 AM, Grant Likely Question: spi_alloc_device() (and the original code) does a spi_master_get() on the spi_master device. Doesn't spi_master_put() need to be called when the device is discarded? spi_dev_put() doesn't do that explicitly; is it an implicit operation after a device has been deregistered from the spi_master? Thanks, -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
May 23, 11:54 pm 2008
Willy Tarreau
Re: RFI for 2.6.25.5 : Re: Regression- XFS won't mount o ...
Hi David, It would have helped to CC stable (fixed) and to give the mainline commit ID since the stable branch only holds already merged patches. Greg, the commit is 6ab455ee... Willy --
May 24, 6:52 am 2008
Eric Sandeen
Re: RFI for 2.6.25.5 : Re: Regression- XFS won't mount o ...
Yup I'll agree that this should probably go to -stable unless hch or dchinner disagree. FWIW I've already put it in the Fedora kernels. -Eric --
May 24, 8:39 am 2008
David Greaves
RFI for 2.6.25.5 : Re: Regression- XFS won't mount on pa ...
Hi Greg Perusing: http://git.kernel.org/?p=linux/kernel/git/stable/stable-queue.git doesn't show the patch referenced below as in the queue for 2.6.25.5 David --
May 24, 6:33 am 2008
Mariusz Kozlowski
Re: spontaneous reboots and hangs on x86_64
Whatever it was its gone in recent linux-next releases, box boots without problems. Mariusz --
May 24, 9:11 am 2008
Jan Engelhardt
Re: crossbuild fails in modpost
That is good for ppc. But for x86, things seem to have changed. Previously, one could just do `make ARCH=x86_64` on an i586 installation, now the required magic is a little bit tougher, unless I am missing something (new). --
May 23, 9:46 pm 2008
Chandra Seetharaman
Re: 2.6.26-rc2-mm1 (SCSI_DH build errors)
Oh, my... it is getting very tricky. Here is a patch that compiles clean in different combinations. But, I agree that the "depends" (under DM_MULTIPATH) sure looks weird. ----------- Do not automatically "select" SCSI_DH for dm-multipath. If SCSI_DH doesn't exist,just do not allow hardware handlers to be used. Handle SCSI_DH being a module also. Make sure it doesn't allow DM_MULTIPATH to be compiled in when SCSI_DH is a module. Signed-off-by: Chandra Seetharaman ...
May 23, 6:16 pm 2008
Yinghai Lu May 23, 5:01 pm 2008
Jeremy Fitzhardinge
Re: [PATCH] x86: extend e820 ealy_res support 32bit - fix v2
OK, I've fixed earlyprintk=xen, so I can finally get some useful debugging information. With this patch it still crashes, but outputs: (early) Reserving virtual address space above 0xf57fe000 (early) Linux version 2.6.26-rc3-sched-devel.git (jeremy@victim.goop.org) (gcc version 4.1.2 20070925 (Red Hat 4.1.2-33)) #466 SMP PREEMPT Sat May 24 01:05:41 PDT 2008 (early) ACPI in unprivileged domain disabled (early) BIOS-provided physical RAM map: (early) Xen: 0000000000000000 - 000000000009f000 ...
May 24, 1:54 am 2008
Yinghai Lu
Re: [PATCH] xen: boot via i386_start_kernel to get early ...
.. need to do the same thing in arch/x86/lguest.c::lguest_init YH --
May 24, 3:04 pm 2008
Yinghai Lu
Re: [PATCH] x86: extend e820 ealy_res support 32bit - fix v2
great. i guess 64bit XEN pv will call x86_64_start_kernel. INIT_PG_TABLE is right after "TEXT DATA BSS". So you bootloader will don't leave space between kernel and ramdisk? or need to put INIT_PG_TABLE before end of BSS like 64bit did.... YH --
May 24, 12:57 pm 2008
Yinghai Lu
Re: [PATCH] x86: extend e820 ealy_res support 32bit - fix v2
I moved reserve_ebda_region() to i386_start_kernel from setup_arch. and reserve_ebda_region will check if (paravirt_enabled()), wonder if that cause problem. but 64bit already did that. YH --
May 23, 5:09 pm 2008
Jeremy Fitzhardinge
[PATCH] xen: boot via i386_start_kernel to get early res ...
Boot Xen via i386_start_kernel so that all the early reservations are made properly; without these, it will start using the kernel and pagetables as early heap memory, which is a bit suboptimal. One tricky part is that reserve_early() will just panic if any of the early reservations overlap any others. When a Xen domain is built, it constructs the initial address space as: kernel text+data+bss initrd initial pagetable Therefore, when reserving the pagetable (from &_end ...
May 24, 2:49 am 2008
Rafael J. Wysocki
Re: Suspend to memory is freezing my machine
Hm, what kind of graphics adapter is there in your box? Rafael --
May 24, 2:01 pm 2008
Jan Kara
Re: [PATCH-v2] JBD: Fix race between free buffer and com ...
Well, but by the time log_wait_commit() finishes, it may well happen that a new transaction is already started so your lock doesn't help you much. And the page you are called on is actually locked, so noone can really mess with it until you unlock it... So I think you can just use the lock for obtaining tid and then drop it. Honza PS: For JBD2 you'd need to be a bit more careful because you cannot call log_wait_commit() while holding page lock (we have reversed locking order for ...
May 24, 3:44 pm 2008
previous daytodaynext day
May 23, 2008May 24, 2008May 25, 2008