Re: kernel coding style for if ... else which cross #ifdef

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jeremy Fitzhardinge
Date: Saturday, May 24, 2008 - 2:15 pm

H. Peter Anvin wrote:

But <stamp foot> coding is *hard*.


Well, I'm thinking more along the lines of:

   1. We introduce this <whatever> mechanism
   2. Hundreds of people pop out of the woodwork thinking "this looks
      more fun than tweaking whitespace"
   3. They produce one-hundred trillion "convert #ifdef to if()" patches
   4. We have one-hundred trillion^2 followup "fix build with this
      .config" patches

3 might be enough to finally drive Andrew out of the kernel business, 
but 4 definitely would be.

The whole point is to try and get config-invariant build breakages, so 
that we become less dependent on lots of randconfig testing.  If the 
definedness of the KCONFIG_ constants is still dependent on a particular 
.config, then we're not really making all that much progress.

If we move to having a single unified kernel config rather than per-arch 
ones (as Sam mentioned), then we can be sure of generating a complete 
list of all config variables, and we can explicitly define them.  But if 
we don't move to that state more or less simultaneously with using 
KCONFIG_ constants, then we should do it in the defeatest way so we can 
make forward progress with minimal regression.

    J
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
kernel coding style for if ... else which cross #ifdef, Steve French, (Fri May 23, 12:11 pm)
Re: kernel coding style for if ... else which cross #ifdef, H. Peter Anvin, (Fri May 23, 4:03 pm)
Re: kernel coding style for if ... else which cross #ifdef, H. Peter Anvin, (Fri May 23, 10:42 pm)
Re: kernel coding style for if ... else which cross #ifdef, Jeremy Fitzhardinge, (Sat May 24, 3:06 am)
Re: kernel coding style for if ... else which cross #ifdef, Jeremy Fitzhardinge, (Sat May 24, 7:35 am)
Re: kernel coding style for if ... else which cross #ifdef, Jeremy Fitzhardinge, (Sat May 24, 7:41 am)
Re: kernel coding style for if ... else which cross #ifdef, Jeremy Fitzhardinge, (Sat May 24, 8:45 am)
Re: kernel coding style for if ... else which cross #ifdef, Jeremy Fitzhardinge, (Sat May 24, 9:02 am)
Re: kernel coding style for if ... else which cross #ifdef, H. Peter Anvin, (Sat May 24, 11:08 am)
Re: kernel coding style for if ... else which cross #ifdef, H. Peter Anvin, (Sat May 24, 11:12 am)
Re: kernel coding style for if ... else which cross #ifdef, H. Peter Anvin, (Sat May 24, 11:12 am)
Re: kernel coding style for if ... else which cross #ifdef, Jeremy Fitzhardinge, (Sat May 24, 1:38 pm)
Re: kernel coding style for if ... else which cross #ifdef, H. Peter Anvin, (Sat May 24, 1:43 pm)
Re: kernel coding style for if ... else which cross #ifdef, Jeremy Fitzhardinge, (Sat May 24, 1:51 pm)
Re: kernel coding style for if ... else which cross #ifdef, H. Peter Anvin, (Sat May 24, 1:54 pm)
Re: kernel coding style for if ... else which cross #ifdef, Jeremy Fitzhardinge, (Sat May 24, 2:15 pm)
Re: kernel coding style for if ... else which cross #ifdef, H. Peter Anvin, (Sun May 25, 5:27 pm)