Re: [RFC] OpenFirmware bindings for the MMC-over-SPI driver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Brownell
Date: Saturday, May 24, 2008 - 12:56 pm

On Friday 23 May 2008, Anton Vorontsov wrote:

Summary:  an OF-specific wrapper around the mmc_spi platform code.

I think a wrapper to encapsulate all the OF-specific knowledge makes
much sense here.

The only thing that looks odd to me about this is that the wrapper
is a spi_device rather than an of_device.  To me it makes more sense
to just have an of_device setting up the right spi_device.  (Though
maybe I missed some discussion about why that can't work.)

Example:  drivers/usb/host/sl811_cs.c does that for PCMCIA card
that just wraps an sl811 chip that's more often used standalone.
The PCMCIA descriptors being analagous to OF device table entries.

- Dave


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] OpenFirmware bindings for the MMC-over-SPI driver, Anton Vorontsov, (Fri May 23, 11:27 am)
[RFC PATCH 1/2] mmc_spi: export probe and remove functions, Anton Vorontsov, (Fri May 23, 11:28 am)
Re: [RFC] OpenFirmware bindings for the MMC-over-SPI driver, David Brownell, (Sat May 24, 12:56 pm)
Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the ..., Segher Boessenkool, (Sat May 24, 4:06 pm)
Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the ..., Segher Boessenkool, (Sat May 24, 4:14 pm)