Re: PostgreSQL pgbench performance regression in 2.6.23+

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Greg Smith <gsmith@...>
Cc: Ingo Molnar <mingo@...>, Peter Zijlstra <peterz@...>, Dhaval Giani <dhaval@...>, lkml <linux-kernel@...>, Srivatsa Vaddagiri <vatsa@...>
Date: Saturday, May 24, 2008 - 4:08 am

On Sat, 2008-05-24 at 01:46 +0200, Mike Galbraith wrote:


btw, the problem with 2.6.25.4 and this load is one and the same.  With
a 1:N load, you really don't want work generator waking all worker-bees
on it's CPU.  The patchlet below let's you turn it off.

diff --git a/kernel/sched.c b/kernel/sched.c
index 1e4596c..5641eb8 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -596,6 +596,7 @@ enum {
 	SCHED_FEAT_START_DEBIT		= 4,
 	SCHED_FEAT_HRTICK		= 8,
 	SCHED_FEAT_DOUBLE_TICK		= 16,
+	SCHED_FEAT_SYNC_WAKEUPS		= 32,
 };
 
 const_debug unsigned int sysctl_sched_features =
@@ -603,7 +604,8 @@ const_debug unsigned int sysctl_sched_features =
 		SCHED_FEAT_WAKEUP_PREEMPT	* 1 |
 		SCHED_FEAT_START_DEBIT		* 1 |
 		SCHED_FEAT_HRTICK		* 1 |
-		SCHED_FEAT_DOUBLE_TICK		* 0;
+		SCHED_FEAT_DOUBLE_TICK		* 0 |
+		SCHED_FEAT_SYNC_WAKEUPS         * 0;
 
 #define sched_feat(x) (sysctl_sched_features & SCHED_FEAT_##x)
 
@@ -1902,6 +1904,9 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state, int sync)
 	long old_state;
 	struct rq *rq;
 
+	if (!sched_feat(SYNC_WAKEUPS))
+		sync = 0;
+
 	smp_wmb();
 	rq = task_rq_lock(p, &flags);
 	old_state = p->state;


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
PostgreSQL pgbench performance regression in 2.6.23+, Greg Smith, (Wed May 21, 1:34 pm)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 3:10 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 5:05 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 6:34 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 7:25 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Peter Zijlstra, (Thu May 22, 7:44 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 8:09 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Peter Zijlstra, (Thu May 22, 8:24 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Fri May 23, 6:00 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Fri May 23, 9:05 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Fri May 23, 9:35 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Fri May 23, 6:15 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Fri May 23, 7:46 pm)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Sat May 24, 4:08 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 9:16 am)