login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
24
Re: kernel coding style for if ... else which cross #ifdef
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Sam Ravnborg
Subject:
Re: kernel coding style for if ... else which cross #ifdef
Date: Friday, May 23, 2008 - 11:42 pm
On Fri, May 23, 2008 at 10:42:58PM -0700, H. Peter Anvin wrote:
quoted text
> Sam Ravnborg wrote: > >>*However*, the best would really be if we changed Kconfig to emit > >>configuration constants what were 0/1 instead of undefined/defined. > >>That way we could do: > >> > >> if (CONFIG_SOMETHING && foo) { > >> /* ... something ... */ > >> } else if ((mode & S_IWUGO) == 0) { > >> /* ... */ > > > >We could do that - but then it would need another > >name not to clash with all the places where we rely > >on CONFIG_FOO='n' => CONFIG_FOO is not defined. > > > >We could teach kconfig to emit something like: > >#define KFOO 0 (for the 'n' value) > >And 1 or 2 for the y and m values. > > > > I don't think we want to use "1 or 2"... I suspect we want to use the > same booleans we currently have.
I'm a bit dense (or I need more coffe - it's morning here). What "same booleans"?
quoted text
> I would suggest CFG_* instead of CONFIG_* for the new set.
Agreed. Sam --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
kernel coding style for if ... else which cross #ifdef
, Steve French
, (Fri May 23, 12:11 pm)
Re: kernel coding style for if ... else which cross #ifdef
, Willy Tarreau
, (Fri May 23, 1:42 pm)
Re: kernel coding style for if ... else which cross #ifdef
, Adrian Bunk
, (Fri May 23, 1:49 pm)
Re: kernel coding style for if ... else which cross #ifdef
, Willy Tarreau
, (Fri May 23, 2:05 pm)
Re: kernel coding style for if ... else which cross #ifdef
, H. Peter Anvin
, (Fri May 23, 4:03 pm)
Re: kernel coding style for if ... else which cross #ifdef
, H. Peter Anvin
, (Fri May 23, 10:42 pm)
Re: kernel coding style for if ... else which cross #ifdef
, Sam Ravnborg
, (Fri May 23, 10:43 pm)
Re: kernel coding style for if ... else which cross #ifdef
, Sam Ravnborg
, (Fri May 23, 11:42 pm)
Re: kernel coding style for if ... else which cross #ifdef
, Jeremy Fitzhardinge
, (Sat May 24, 3:06 am)
Re: kernel coding style for if ... else which cross #ifdef
, Adrian Bunk
, (Sat May 24, 3:49 am)
Re: kernel coding style for if ... else which cross #ifdef
, Sam Ravnborg
, (Sat May 24, 4:27 am)
Re: kernel coding style for if ... else which cross #ifdef
, Jeremy Fitzhardinge
, (Sat May 24, 7:35 am)
Re: kernel coding style for if ... else which cross #ifdef
, Willy Tarreau
, (Sat May 24, 7:39 am)
Re: kernel coding style for if ... else which cross #ifdef
, Jeremy Fitzhardinge
, (Sat May 24, 7:41 am)
Re: kernel coding style for if ... else which cross #ifdef
, Willy Tarreau
, (Sat May 24, 7:46 am)
Re: kernel coding style for if ... else which cross #ifdef
, Sam Ravnborg
, (Sat May 24, 8:36 am)
Re: kernel coding style for if ... else which cross #ifdef
, Jeremy Fitzhardinge
, (Sat May 24, 8:45 am)
Re: kernel coding style for if ... else which cross #ifdef
, Vegard Nossum
, (Sat May 24, 8:57 am)
Re: kernel coding style for if ... else which cross #ifdef
, Jeremy Fitzhardinge
, (Sat May 24, 9:02 am)
Re: kernel coding style for if ... else which cross #ifdef
, Tom Spink
, (Sat May 24, 9:40 am)
Re: kernel coding style for if ... else which cross #ifdef
, Tom Spink
, (Sat May 24, 9:42 am)
Re: kernel coding style for if ... else which cross #ifdef
, H. Peter Anvin
, (Sat May 24, 11:08 am)
Re: kernel coding style for if ... else which cross #ifdef
, H. Peter Anvin
, (Sat May 24, 11:12 am)
Re: kernel coding style for if ... else which cross #ifdef
, H. Peter Anvin
, (Sat May 24, 11:12 am)
Re: kernel coding style for if ... else which cross #ifdef
, Sam Ravnborg
, (Sat May 24, 11:51 am)
Re: kernel coding style for if ... else which cross #ifdef
, Jeremy Fitzhardinge
, (Sat May 24, 1:38 pm)
Re: kernel coding style for if ... else which cross #ifdef
, H. Peter Anvin
, (Sat May 24, 1:43 pm)
Re: kernel coding style for if ... else which cross #ifdef
, Jeremy Fitzhardinge
, (Sat May 24, 1:51 pm)
Re: kernel coding style for if ... else which cross #ifdef
, H. Peter Anvin
, (Sat May 24, 1:54 pm)
Re: kernel coding style for if ... else which cross #ifdef
, Jeremy Fitzhardinge
, (Sat May 24, 2:15 pm)
Re: kernel coding style for if ... else which cross #ifdef
, Adrian Bunk
, (Sun May 25, 4:57 pm)
Re: kernel coding style for if ... else which cross #ifdef
, H. Peter Anvin
, (Sun May 25, 5:27 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Mel Gorman
Re: [PATCH 1/4] vmstat: remove zone->lock from walk_zones_in_node
Guenter Roeck
Re: [lm-sensors] Location for thermal drivers
David Woodhouse
Re: RFC: Moving firmware blobs out of the kernel.
Siddha, Suresh B
Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU k...
Peter Zijlstra
Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)
git-commits-head
:
Linux Kernel Mailing List
[MIPS] Fix potential latency problem due to non-atomic cpu_wait.
Linux Kernel Mailing List
USB: rename USB_SPEED_VARIABLE to USB_SPEED_WIRELESS
Linux Kernel Mailing List
lib/vsprintf.c: fix bug omitting minus sign of numbers (module_param)
Linux Kernel Mailing List
[Bluetooth] Initiate authentication during connection establishment
Linux Kernel Mailing List
[POWERPC] 4xx: Add ppc40x_defconfig
linux-netdev
:
MERCEDES
Your mail id has won 950,000.00 in the MERCEDES Benz Online Promo.for claims send:
David Miller
Re: [PATCH] xen/netfront: do not mark packets of length < MSS as GSO
David Miller
Re: skb_segment() questions
Shan Wei
[RFC PATCH net-next 2/5]IPv6:netfilter: Send an ICMPv6 "Fragment Reassembly Timeou...
Stanislaw Gruszka
[PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
git
:
Nicolas Sebrecht
git-svn died of signal 11 (was "3 failures on test t9100 (svn)")
Junio C Hamano
Re: [PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
Martin Langhoff
Re: [PATCH] GIT commit statistics.
Alexandre Julliard
[PATCH] gitweb: Put back shortlog instead of graphiclog in the project list.
Josh Triplett
[PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
openbsd-misc
:
Taisto Qvist XX
Re: AMD GEODE LX-800 just works with kernel from install42.iso and kernelpanics wi...
Nico Meijer
Re: gOS Develop Kit with VIA pc-1 Processor Platform VIA C7-D
Andreas Bihlmaier
Re: jetway board sensors (Fintek F71805F)
admin
Drive a 2009 car from R799p/m
Antti Harri
Re: how to create a sha256 hash
Colocation donated by:
Syndicate