Hi Anton,

On Fri, 23 May 2008 22:28:42 +0400 Anton Vorontsov <avorontsov@ru.mvista.co=
m> wrote:
quoted text
>
> +++ b/drivers/mmc/host/of_mmc_spi.c

quoted text
> +static int of_mmc_spi_probe(struct spi_device *spi)

quoted text
> +	/*
> +	 * mmc_spi_probe will use drvdata, so we can't use it. Use node's
> +	 * data instead.
> +	 */
> +	spi->dev.archdata.of_node->data =3D oms;

If you delay this assignment, you may not have to clean it up in the
error path.

quoted text
> +	ocr_mask =3D of_get_property(np, "linux,mmc-ocr-mask", &size);

You should really explicitly include linux/of.h to use of_get_property etc

quoted text
> +int __devexit of_mmc_spi_remove(struct spi_device *spi)
> +{
> +	struct of_mmc_spi *oms =3D spi->dev.archdata.of_node->data;
> +	int ret;
> +
> +	ret =3D mmc_spi_remove(spi);
> +	if (ret)
> +		return ret;

Maybe you should do this last so that you don't leak more than necessary
if mmc_spi_remove fails.  (I don't know what state mmc_spi_remove leaves
stuff in if it fails ...)

quoted text
> +static struct spi_driver of_mmc_spi_driver =3D {
> +	.driver =3D {
> +		.name =3D "of_mmc_spi",
> +		.bus =3D &spi_bus_type,

This is initialised by spi_register_driver().

--=20
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/