Re: [patch 06/14] hfsplus: remove hfsplus_permission()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Miklos Szeredi
Date: Friday, May 23, 2008 - 11:02 am

> > And so I strongly suggest this patch as well.  Apparently this feature

Because

 a) it's nontrivial to fix (even understanding the problem is
 nontrivial, see Documentation/filesystems/directory-locking)

 b) the feature is obviously unused, so the easiest fix is simply to
 remove it for the time being.

We generally don't leave code around which is known to be deadlockable
by unprivileged users.  Of course if you have a better fix, then
that's fine.

Miklos
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 06/14] hfsplus: remove hfsplus_permission(), Miklos Szeredi, (Wed May 21, 10:15 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Roman Zippel, (Wed May 21, 1:35 pm)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Miklos Szeredi, (Thu May 22, 12:58 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Roman Zippel, (Thu May 22, 5:02 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Miklos Szeredi, (Thu May 22, 5:17 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Roman Zippel, (Thu May 22, 5:28 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Miklos Szeredi, (Thu May 22, 5:37 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Christoph Hellwig, (Fri May 23, 2:21 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Roman Zippel, (Fri May 23, 8:11 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Roman Zippel, (Fri May 23, 8:18 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Miklos Szeredi, (Fri May 23, 8:31 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Miklos Szeredi, (Fri May 23, 8:49 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Roman Zippel, (Fri May 23, 9:30 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Miklos Szeredi, (Fri May 23, 11:02 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Roman Zippel, (Fri May 23, 11:33 am)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Miklos Szeredi, (Fri May 23, 12:05 pm)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Roman Zippel, (Fri May 23, 2:52 pm)
Re: [patch 06/14] hfsplus: remove hfsplus_permission(), Miklos Szeredi, (Fri May 23, 11:59 pm)