On Fri, 2008-05-23 at 17:19 +0200, Takashi Iwai wrote:
quoted text
> Hm, but request_firmware() returns the const pointer.  It implies that
> the caller shouldn't change the content, doesn't it?
> 
> I cannot guarantee that there must be no misbehaving drivers,
> though...

The 'struct firmware' is const. It contains a pointer to data.
That data is not const.

 fw->data = some_other_data; 	// bad.
 fw->data[0] = 0;		// ok.

Of course, we could _make_ it const (if we can remember whether it's
'const u8 *' or 'u8 const *'...)

-- 
dwmw2

--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/