[RFC] Circular include dependencies

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linux Kernel List <linux-kernel@...>
Date: Friday, May 23, 2008 - 9:20 am

Hi,

Having discovered some circular include dependencies in the ARM header
files which were causing build issues, I created a script to walk ARM
includes and report any similar issues found - which includes traversing
any referenced linux/ includes.

It identified the following two in include/linux/:

  linux/mmzone.h <- linux/memory_hotplug.h <- linux/mmzone.h
  linux/mmzone.h <- linux/topology.h <- linux/mmzone.h

Checking them by hand reveals that these are real.  Whether they're
capable of causing a problem or not, I'm not going to comment on.
However, they're not a good idea and someone should probably look at
resolving the loops.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] Circular include dependencies, Russell King, (Fri May 23, 9:20 am)
Re: [RFC] Circular include dependencies, Andrew Morton, (Fri May 23, 9:17 pm)
Re: [RFC] Circular include dependencies, Yasunori Goto, (Mon May 26, 9:10 am)