Re: PostgreSQL pgbench performance regression in 2.6.23+

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Greg Smith <gsmith@...>, Peter Zijlstra <peterz@...>, Dhaval Giani <dhaval@...>, lkml <linux-kernel@...>, Srivatsa Vaddagiri <vatsa@...>
Date: Friday, May 23, 2008 - 9:05 am

On Fri, 2008-05-23 at 12:10 +0200, Ingo Molnar wrote:


Running SCHED_BATCH with only the below put a large dent in the problem.

You can have tl <= current->se.load.weight.  Nothing good happens in
either case, at least with this load.

--- kernel/sched_fair.c.org	2008-05-23 14:59:39.000000000 +0200
+++ kernel/sched_fair.c	2008-05-23 14:49:05.000000000 +0200
@@ -1081,7 +1081,7 @@ wake_affine(struct rq *rq, struct sched_
 	 * effect of the currently running task from the load
 	 * of the current CPU:
 	 */
-	if (sync)
+	if (sync && tl > current->se.load.weight)
 		tl -= current->se.load.weight;
 
 	if ((tl <= load && tl + target_load(prev_cpu, idx) <= tl_per_task) ||
 


2.6.26-smp x86_64
1 9209.503213
2 15792.406916
3 23369.199181
4 23140.108032
5 24556.515470
6 24926.457776
8 26896.607558
10 27350.988396
15 29005.426298
20 28558.267290
30 27002.328374
40 25809.202374
50 24589.478654

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
PostgreSQL pgbench performance regression in 2.6.23+, Greg Smith, (Wed May 21, 1:34 pm)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 3:10 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 5:05 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 6:34 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 7:25 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Peter Zijlstra, (Thu May 22, 7:44 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 8:09 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Peter Zijlstra, (Thu May 22, 8:24 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Fri May 23, 6:00 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Fri May 23, 9:05 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Fri May 23, 9:35 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Fri May 23, 6:15 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Fri May 23, 7:46 pm)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Sat May 24, 4:08 am)
Re: PostgreSQL pgbench performance regression in 2.6.23+, Mike Galbraith, (Thu May 22, 9:16 am)