correction to compat_sys_kexec_load

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>, <fastboot@...>, <akpm@...>, <maneesh@...>, <ebiederm@...>, <mohan@...>, <sachinp@...>
Cc: <mohd.omar@...>, <IndhuDurai@...>
Date: Friday, May 23, 2008 - 7:36 am

Hi
   While testing with kexec tool, I observed some problems. When 
application (kexec) is 32 bit and kernel is 64 bit I observed that 
loading crash kernel works without any issues but unloading crash kernel 
fails.
--------------------------------------------------------
running strace over 'kexec -u -p'
show the problem to be with sys_kexec_load() call

sys_kexec_load(0, 0, 0, 0x1, 0)         = -1 EINVAL (Invalid argument)
write(2, "kexec_load (0 segments) failed: "..., 49
kexec_load (0 segments) failed: Invalid argument
) = 4
--------------------------------------------------------

This is patch to fix the problem, I think kernel code had a typo where in:
if((flags & KEXEC_ARCH_MASK) == KEXEC_ARCH) was used instead of
if((flags & KEXEC_ARCH_MASK) != KEXEC_ARCH)

This patch takes care of that, I have tested the patch it worked fine 
for me. Please review the patch and let me know of your views. This 
patch is based on linux-2.6.26-rc3.

Thanks
Yeehaw
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
correction to compat_sys_kexec_load, Sharyathi Nagesh, (Fri May 23, 7:36 am)
Re: correction to compat_sys_kexec_load, Eric W. Biederman, (Fri May 23, 4:14 pm)
Re: correction to compat_sys_kexec_load, Bernhard Walle, (Fri May 23, 5:33 pm)
Re: correction to compat_sys_kexec_load, Eric W. Biederman, (Fri May 23, 8:36 pm)
Re: correction to compat_sys_kexec_load, Bernhard Walle, (Mon May 26, 4:32 pm)
Re: correction to compat_sys_kexec_load, Sharyathi Nagesh, (Wed May 28, 12:39 am)