Re: [RFC] x86: merging nmi 32/64 to nmi.c v2

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Thomas Gleixner
Date: Thursday, May 22, 2008 - 2:37 pm

On Wed, 21 May 2008, Cyrill Gorcunov wrote:

Cyrill,

I really like that patch, but I'm a bit wary about the doit in one go
approach. Its pretty hard to review that way and in case of breakage
bisecting will just point to one large diff which is hard to decode.

Can you please try to make this a more fine grained patch series ?

Gradually add/modify the two files so they are identical at the
end. There are a couple of obvious steps, e.g. the move of function to
traps_*.c and adding the inline functions like get_timer_irqs().

Thanks,
	tglx
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] x86: merging nmi 32/64 to nmi.c v2, Cyrill Gorcunov, (Wed May 21, 9:30 am)
Re: [RFC] x86: merging nmi 32/64 to nmi.c v2, Hiroshi Shimamoto, (Wed May 21, 11:20 am)
Re: [RFC] x86: merging nmi 32/64 to nmi.c v2, Cyrill Gorcunov, (Wed May 21, 11:47 am)
Re: [RFC] x86: merging nmi 32/64 to nmi.c v2, Cyrill Gorcunov, (Wed May 21, 12:21 pm)
Re: [RFC] x86: merging nmi 32/64 to nmi.c v2, Thomas Gleixner, (Thu May 22, 2:37 pm)
Re: [RFC] x86: merging nmi 32/64 to nmi.c v2, Cyrill Gorcunov, (Thu May 22, 8:33 pm)