Re: [PATCH 2/5] sky2: don't warn if page allocation fails

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Stephen Hemminger <shemminger@...>
Cc: <netdev@...>, LKML <linux-kernel@...>, Nick Piggin <nickpiggin@...>, Andrew Morton <akpm@...>
Date: Thursday, May 22, 2008 - 5:57 am

>  


IMO it's inappropriate to add these warnings to net drivers that 
properly check all return values.

This approach is too maintenance intensive, and winds up fixing the same 
problem over and over again -- a hint that the fix is in the wrong place.

	Jeff


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 2/5] sky2: don't warn if page allocation fails, Jeff Garzik, (Thu May 22, 5:57 am)
Re: [PATCH 2/5] sky2: don't warn if page allocation fails, Stephen Hemminger, (Tue May 27, 2:47 pm)