| From | Subject | Date |
|---|---|---|
| Chris Friesen | fair group scheduler not so fair?
I just downloaded the current git head and started playing with the fair
group scheduler. (This is on a dual cpu Mac G5.)
I created two groups, "a" and "b". Each of them was left with the
default share of 1024.
I created three cpu hogs by doing "cat /dev/zero > /dev/null". One hog
(pid 2435) was put into group "a", while the other two were put into
group "b".
After giving them time to settle down, "top" showed the following:
2438 cfriesen 20 0 3800 392 336 R 99.5 0.0 4:02....
| May 21, 7:59 pm 2008 |
| Adrian Bunk | [2.6 patch] avr32: export strnlen_user
This patch fixes the following build error:
<-- snip -->
...
MODPOST 1327 modules
ERROR: "strnlen_user" [drivers/input/misc/uinput.ko] undefined!
...
make[2]: *** [__modpost] Error 1
<-- snip -->
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
0318ae73cb3e61e5c192d62c22d988424e04f354 diff --git a/arch/avr32/kernel/avr32_ksyms.c b/arch/avr32/kernel/avr32_ksyms.c
index 3a090ba..84a7d44 100644
--- a/arch/avr32/kern...
| May 21, 6:01 pm 2008 |
| Randy Dunlap | [PATCH] netfilter: conntrack_helper needs to include rculist.h
Sure, makes sense.
Looks like it's some sched/auto-sched tree/branch if I'm reading
correctly.
Ingo, is there a sched tree that add rculist.h file?
If so, one of its users needs to #include it. Patch below.
---
From: Randy Dunlap <randy.dunlap@oracle.com>
nf_conntrack_helper users rcu hlist functions so it needs to #include
rculist.h.
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function 'hlist_for_each_entry_rcu'
linux-next-20080521...
| May 21, 5:55 pm 2008 |
| Vegard Nossum | [PATCH] kmemcheck: use tasklets instead of timers
From: Vegard Nossum <vegard.nossum@gmail.com>
Date: Wed, 21 May 2008 22:58:37 +0200
Subject: [PATCH] kmemcheck: use tasklets instead of timers
Instead of triggering a timer every HZ, we use the new tasklet function
which guarantuees not to touch any other tasklets on the tasklet list,
and is thus safe to use from the page fault handler.
Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
---
arch/x86/kernel/kmemcheck.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8...
| May 21, 5:37 pm 2008 |
| Rafael J. Wysocki | Suspend and hibernation patchset for 2.6.26-rc3
Hi,
For everyone interested, I have put together a patchset containing some "fresh"
patches related to suspend and hibernation, on top of 2.6.26-rc3, located at:
http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.26-rc3/patches/
Patches 01-06 and 11 have been sent to Len as 2.6.27 material. They have
been tested by me for some time (except for the most recent changes in patches
01 and 11) and have not lead to any problems so far.
Patches 07-10 are in the Jesse's PCI tree, targeted at 2.6....
| May 21, 5:29 pm 2008 |
| Takashi Iwai | Moving sound/* to drivers/ ?
While we are at the issue ALSA HG <-> GIT transition...
One thing that annoys me sometimes is that the sound driver codes are
on a different subdirectory than other normal drivers, namely under
/sound. I don't remember exactly why it came there, but this often
makes people forget to change the necessary code for the sound
subsystem, or slip from the statistics (I'm not sure whether Linus
counted sound/* with recent his posts).
If I understand correctly, with git, we can move the files in
...
| May 21, 5:20 pm 2008 |
| Jeff Garzik | Re: Moving sound/* to drivers/ ?
Speaking as a former OSS driver maintainer, I always preferred
drivers/sound.
Though Rene's suggestion (use both sound/ and drivers/sound/) might make
sense if the subsystem code is huge -- I supported the drivers/block/ ->
block/ code movement for example.
Jeff
--
| May 21, 7:37 pm 2008 |
| Rene Herman | Re: Moving sound/* to drivers/ ?
Well, not _huge_ but ALSA is very much structured like that; large
middle layer with "miniport" drivers (I do by the way expect this was
also Takashi plan originally due to him using sound/* and not just
"sound/"; that is, I took the * to be shorthand for isa, pci, usb and so on)
From a structural view, the PCM core is just as much not a driver as
the IP protocol isn't one and moving all of sound/ to drivers/ would
trade the current "why are the drivers not under drivers/?" issue for a
"wh...
| May 21, 7:53 pm 2008 |
| Adrian Bunk | Re: Moving sound/* to drivers/ ?
Under drivers/media/ it would only generate confusion regarding who's
responsible for what.
But drivers/sound/ sounds good.
The only possible problem that comes into my mind is to check what
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
| May 21, 6:23 pm 2008 |
| Timur Tabi | Re: [alsa-devel] Moving sound/* to drivers/ ?
That gets my vote.
--
Timur Tabi
Linux kernel developer at Freescale
--
| May 21, 6:05 pm 2008 |
| Linus Torvalds | Re: Moving sound/* to drivers/ ?
I would certainly personally like drivers/sound more, and the placement at
the top level is actually because the sound maintainers wanted it that
way, probably to avoid the confusion with the old OSS drivers that used to
live in drivers/sound.
I forget the exact details. It's been many many years, and there may have
been some real technical issues too. But basically sound/ was created when
ALSA was first merged, and we had a lot of renames from drivers/sound/xyz
to sound/oss/xyz.
(It...
| May 21, 5:44 pm 2008 |
| Paul Mackerras | Moving include/asm-* [was: Re: Moving sound/* to drivers/ ?]
We could git mv include/asm-xyz arch/xyz/asm and then arrange to pass
-Iarch/$(ARCH) to gcc. The only downside is that "asm" is a slightly
strange name for a directory of include files, but I assume we don't
want to have to change all the #include <asm/blah.h> lines in all the
*.c files.
Paul.
--
| May 21, 7:21 pm 2008 |
| Linus Torvalds | Re: Moving include/asm-* [was: Re: Moving sound/* to drivers...
That would work, but there's a few alternatives that I think would work
even better.
The downside with what you suggest is that I'd like the arch-specific
include files to be clearly separated (ie I think the naming should be
"something/include/something", which makes things clearer.
Also, I hate how doing '-Iarch/$(ARCH)' would basically make any random
arch/xyz/ subdirectory be a potential location for a header file. I'd hate
for the include-path to contain subdirectories that simpl...
| May 21, 7:51 pm 2008 |
| Rene Herman | Re: [alsa-devel] Moving sound/* to drivers/ ?
I'd personally like the net/ structure more. So subsystem code under
And a few symlinks will do wonders as well. I do/did that when I "port"
patches developped against mainline to the alsa-kernel HG repo. Not a
And one would not forget to add the include directory to a "git log" or
"git bisect" path specification...
Rene.
--
| May 21, 5:58 pm 2008 |
| Rene Herman | Re: [alsa-devel] Moving sound/* to drivers/ ?
Suggestion for sound/drivers: drivers/sound/generic :-)
Rene.
--
| May 21, 6:08 pm 2008 |
| Sam Ravnborg | Re: Moving sound/* to drivers/ ?
Something like:
include/asm-$ARCH/ => arch/$ARCH/include/asm/*
?
I can cook up something simple so kbuild will try both so we can
move the archs that do symlinks later than the rest.
I really like to keep the 'asm' directory so we can kill the asm symlink.
Sam
--
| May 21, 5:54 pm 2008 |
| Vegard Nossum | [PATCH] tasklets: new tasklet scheduling function
Hi,
Does this seem like anything that has even a remote possibility of entering
the Kernel? It's not a strict requirement for kmemcheck, but it's extremely
nice compared to the 1 Hz timer I've been using till now.
(Again, I can put it in my queue for now, but it would be nice to have the
necessary Signed-off-bys for when it gets merged. I mean, _if_ it gets
merged...)
Vegard
From: Vegard Nossum <vegard.nossum@gmail.com>
Date: Wed, 21 May 2008 22:53:13 +0200
Subject: [PATCH] tasklet...
| May 21, 5:11 pm 2008 |
| Maciej W. Rozycki | [PATCH 8/8] x86: I/O APIC: Timer through 8259A second-chance
Some systems incorrectly report the ExtINTA pin of the I/O APIC as the
genuine target of the timer interrupt. Here is a change that copies timer
pin information found to the other pin if one has been found only. This
way both a direct and a through-8259A route is tested with the pin letting
these problematic systems work well enough.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
patch-2.6.26-rc1-20080505-timer-pins-0
diff -up --recursive --new-file linux-2.6.26-rc1-2008050...
| May 21, 5:10 pm 2008 |
| Maciej W. Rozycki | [PATCH 7/8] x86: I/O APIC: Clean up the 8259A on a NMI watch...
There is no point in keeping the 8259A enabled if the I/O APIC NMI
watchdog has failed and the 8259A is not used to pass through regular
timer interrupts. This fixes problems with some systems where some logic
gets confused.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
patch-2.6.26-rc1-20080505-timer-8259-6
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_32.c linux-2.6.26-rc1-20080505/arch/x86/kernel/io_apic_32.c
--- linux-2.6.26-rc...
| May 21, 5:10 pm 2008 |
| Maciej W. Rozycki | [PATCH 6/8] x86: APIC/SMP: Downgrade the NMI watchdog for "n...
If configured to use the I/O APIC, the NMI watchdog is deemed to fail if
the chip has been deactivated as a result of "nosmp". Downgrade to the
local APIC watchdog similarly to what is done for the UP case.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
patch-2.6.26-rc1-20080505-nosmp-watchdog-0
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/smpboot.c linux-2.6.26-rc1-20080505/arch/x86/kernel/smpboot.c
--- linux-2.6.26-rc1-20080505.macro/arch/...
| May 21, 5:10 pm 2008 |
| Maciej W. Rozycki | [PATCH 5/8] x86: APIC/SMP: Correct the message for "nosmp"
The local APIC is no longer forced off when "nosmp" has been specified.
Correct the message printed.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
patch-2.6.26-rc1-20080505-nosmp-apic-0
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/smpboot.c linux-2.6.26-rc1-20080505/arch/x86/kernel/smpboot.c
--- linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/smpboot.c 2008-05-05 02:56:19.000000000 +0000
+++ linux-2.6.26-rc1-20080505/arch/x86/kernel/smpboot....
| May 21, 5:09 pm 2008 |
| Maciej W. Rozycki | [PATCH 4/8] x86: I/O APIC: Keep IRQ off when changing LVT re...
Disable the 8259A acting in the "virtual wire" mode to keep the interrupt
line inactive while fiddling with local APIC interrupt vector registers
associated with its destination inputs. To be on the safe side,
especially concerning flipping the trigger mode.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
patch-2.6.26-rc1-20080505-timer-8259-nmi-unmask-0
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_32.c linux-2.6.26-rc1-20080505/arch/x...
| May 21, 5:09 pm 2008 |
| Maciej W. Rozycki | [PATCH 3/8] x86: I/O APIC: Clean up after a fasteoi failure
Disable the 8259A when routing of the timer interrupt through the chip to
the local APIC of the primary processor has failed.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
patch-2.6.26-rc1-20080505-timer-fasteoi-cleanup-0
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_32.c linux-2.6.26-rc1-20080505/arch/x86/kernel/io_apic_32.c
--- linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_32.c 2008-05-21 18:51:28.000000000 +0000
+++ linux-...
| May 21, 5:09 pm 2008 |
| Maciej W. Rozycki | [PATCH 2/8] x86: I/O APIC: Remove parameters to fiddle with ...
Remove the "disable_8254_timer" and "enable_8254_timer" kernel
parameters. Now that AEOI acknowledgements are no longer needed for
correct timer operation, the 8259A can be kept disabled unconditionally
unless interrupts, either timer or watchdog ones, are actually passed
through it.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
patch-2.6.26-rc1-20080505-timer-8254-2
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/early-quirks.c linux-2.6.26-...
| May 21, 5:09 pm 2008 |
| Maciej W. Rozycki | [PATCH 1/8] x86: I/O APIC: AEOI timer acknowledgement clean-...
The code that used to be in do_slow_gettimeoffset() that relied on the
IRR bit of the master 8259A PIC for IRQ0 to check the state of the output
timer 0 of the PIT is no longer there. As a result, there is no need to
use the POLL command to acknowledge the timer interrupt in the "8259A
Virtual Wire", except for the NMI watchdog when the i82489DX APIC is used
(this is because this particular APIC treats NMIs as level-triggered and
keeping the input asserted would keep motherboard NMI sources held off...
| May 21, 5:09 pm 2008 |
| Maciej W. Rozycki | [PATCH 0/8] x86: Timer through APIC and related clean-ups
Hello,
This is a set of patches replacing patch-2.6.26-rc1-20080505-timer_ack-1
and patch-2.6.26-rc1-20080505-timer-8259-0 sent previously. The patches
have been split up into smaller logically self-contained chunks to make
tracking down problems easier.
The patch-2.6.26-rc1-20080505-nosmp-watchdog-0 change fixes a problem
with timer interrupts getting masked in the 8259A as a result of
patch-2.6.26-rc1-20080505-timer-8259-6 in the corner-case scenario of
"nmi_watchdog=1 nosmp" being passed a...
| May 21, 5:08 pm 2008 |
| Yinghai Lu | Re: Suspected regression in "x86: extend e820 ealy_res suppo...
thanks. please check the attached patch
YH
| May 21, 4:35 pm 2008 |
| Johannes Weiner | Re: Suspected regression in "x86: extend e820 ealy_res suppo...
Hi,
Besides, what did you want to accomplish?
Hannes
--
| May 21, 7:14 pm 2008 |
| Yinghai Lu | Re: Suspected regression in "x86: extend e820 ealy_res suppo...
please drop this patch...
YH
--
| May 21, 7:23 pm 2008 |
| Jeremy Fitzhardinge | Re: Suspected regression in "x86: extend e820 ealy_res suppo...
Thanks for the quick response. I definitely confirmed that "x86: extend
e820 ealy_res support 32bit" is the source of the regression, and
reverting the change makes the system bootable under Xen. (My previous
reversion failed because I didn't actually have the x86.git changes
applied :-/)
This patch generates the warning:
CC arch/x86/kernel/setup_32.o
/home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/setup_32.c: In
function ‘setup_arch’:
/home/jeremy/hg/xen/pa...
| May 21, 6:01 pm 2008 |
| Yinghai Lu | Re: Suspected regression in "x86: extend e820 ealy_res suppo...
noticed that bootmap_size is shifted already...
please use attached patch to see if bootmap is right...
YH
| May 21, 6:40 pm 2008 |
| Jeremy Fitzhardinge | Re: Suspected regression in "x86: extend e820 ealy_res suppo...
Unfortunately its a bit difficult because printk() output isn't
appearing at early boot (not sure why). I'll try to extract something
useful tomorrow.
Perhaps this is helpful:
This the e820 map of a regular boot:
BIOS-provided physical RAM map:
Xen: 0000000000000000 - 000000000009f000 (usable)
Xen: 0000000000100000 - 0000000010000000 (usable)
debug: ignoring loglevel setting.
limit_regions start: 0000000000000000 - 000000000009f000 (usable)
limit_regions start: 0000000000100000 - 00...
| May 21, 7:23 pm 2008 |
| Justin Mattock | success
AAAAAAAAAAAAAHHHHHHHHHHHHHHHHHHH
finally after three weeks I have finished my task of figuring out what
the hell Linus
did to the kernel to mess me up.......
Love or regards you choose....
--
Justin P. Mattock
--
| May 21, 4:05 pm 2008 |
| Steven Rostedt | [PATCH RT] rwlocks fix for non PREEMPT_RT
Seems that the addition of RT_RW_READER broke the non PREEMPT_RT case.
This patch fixes it.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/rtmutex.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
Index: linux-2.6.24.7-rt9/kernel/rtmutex.c
===================================================================
--- linux-2.6.24.7-rt9.orig/kernel/rtmutex.c 2008-05-20 23:38:08.000000000 -0400
+++ linux-2.6.24.7-rt9/kernel/rtmutex.c 2008-05-21 15:16:18...
| May 21, 3:35 pm 2008 |
| Philipp Marek | [patch] kmalloc returns (void*), don't do type conversions
Hello everybody,
as requested on http://kernelnewbies.org/KernelJanitors/Todo
here's a first patch that removes type conversion on
kmalloc() (which returns a (void*)):
It was done against current linus-git=20
(d40ace0c7b4a329f7d869d0fbf27435543bb2acc, if I'm not mistaken),
and looks like that:
list_del(&bss->list);
local->num_bss_info--;
} else {
=2D bss =3D (struct hostap_bss_info *)
=2D kmalloc(sizeof(*bss), GFP_ATOMIC);
+ bss =3D kmalloc(sizeof(*bss), GFP_ATO...
| May 21, 3:13 pm 2008 |
| Johannes Weiner | Re: [patch] kmalloc returns (void*), don't do type conversions
Hi Phillip,
You can include the diffstat in the patch as comment. And please don't
attach patches, include them inline. See
How about:
Better use: Real Name <user@domain>
Hope that helps,
Hannes
--
| May 21, 4:17 pm 2008 |
| Jesper Juhl | Re: [patch] kmalloc returns (void*), don't do type conversions
I agree, keep things seperate. One mail with patch to fix casts,
Thank you, I'll keep an eye on this patch.
Philipp: Johannes makes some good points, please address his comments
and re-submit the patch with trivial@kernel.org on Cc: if it draws no
negative comments it looks good to me to add to the trivial tree.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
--
| May 21, 6:24 pm 2008 |
| Johannes Weiner | May 21, 6:15 pm 2008 | |
| David Daney | [PATCH] mips: Remove board_watchpoint_handler.
mips: Remove board_watchpoint_handler.
It is not used anywhere in tree.
Signed-off-by: David Daney <ddaney@avtrex.com>
---
arch/mips/kernel/traps.c | 6 ------
include/asm-mips/traps.h | 1 -
2 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index f9165d1..6e7e4a2 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -71,7 +71,6 @@ extern asmlinkage void handle_reserved(void);
extern int fpu_emu...
| May 21, 2:39 pm 2008 |
| Gabriel C | [PATCH] scripts/ver_linux use 'gcc -dumpversion'
These magic greps and hacks in ver_linux to get the gcc version always break after some gcc releases.
Since now gcc >4.3 allows compiling with '--with-pkgversion' ( which can be everything 'My Cool Gcc' or something )
ver_linux will report random junk for these.
Simply use 'gcc -dumpversion' to get the gcc version which should always work.
Signed-off-by: Gabriel C <nix.or.die@googlemail.com>
---
Andrew sorry to bug you about that but
I have no clue how is maintaining scripts/*
...
| May 21, 2:36 pm 2008 |
| Vegard Nossum | initialization of static per-cpu variables
Hi,
I encountered this comment in kernel/softirq.c:
/* Some compilers disobey section attribute on statics when not
initialized -- RR */
static DEFINE_PER_CPU(struct tasklet_head, tasklet_vec) = { NULL };
static DEFINE_PER_CPU(struct tasklet_head, tasklet_hi_vec) = { NULL };
So I assume it's the combination of static and whatever section
DFINE_PER_CPU puts the variable in which is the problem.
However, there's a LOT of these "static DEFINE_PER_CPU" without any
initializer in the rest of ...
| May 21, 2:28 pm 2008 |
| Pekka J Enberg | [RFC/PATCH 3/3] SLOB: make ksize() more strict for page allo...
From: Pekka Enberg <penberg@cs.helsinki.fi>
This patch re-uses the PG_slab flag for marking SLOB bigblock pages so we can
check that the pointer passed ksize() was really allocated by SLOB.
Cc: Christoph Lameter <clameter@sgi.com>
Cc: Matt Mackall <mpm@selenic.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---
mm/slob.c | 34 ++++++++++++++++++++++++++++++----
1 files ...
| May 21, 2:26 pm 2008 |
| Matt Mackall | Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page ...
Ok, first, BUG_ON is wrong.
We already know users (ie nommu memory usage reporting) are abusing this
interface. Making them blow up is unnecessary. Just give them wrong
answers. Issuing a warning might be a good idea for debugging.
Second, I'd prefer to keep this sort of debugging code out of SLOB.
SLUB is much better suited to debugging allocator abuse.
--
Mathematics is the supreme nostalgia of our time.
--
| May 21, 3:07 pm 2008 |
| Pekka Enberg | Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page ...
But kobjsize() never calls ksize() with SLOB as it doesn't set PageSlab.
Or are you talking about something else here?
Fair enough. I'll drop the patch.
--
| May 21, 3:11 pm 2008 |
| Christoph Lameter | Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page ...
I also would prefer to keep this out of SLUB. Set/Clear PageSlab dirties
the cacheline and it forces the unlining of kmalloc_large.
--
| May 21, 5:12 pm 2008 |
| Pekka Enberg | Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page ...
Hmm, well, that leaves ksize() open for more abuse. I guess we'll just
have to live with that then.
--
| May 21, 5:13 pm 2008 |
| Christoph Lameter | Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page ...
SLUB could add a BUG_ON(!PageCompound ) since we added buffering for order
0 allocs. So only order 1 and higher go through kmalloc large. That should
catch the general case.
--
| May 21, 5:16 pm 2008 |
| Pekka J Enberg | [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allo...
From: Pekka Enberg <penberg@cs.helsinki.fi>
This patch changes ksize() to be more strict with objets passed to it. We now
set PageSlab also for objects allocated with page allocator and use page->slab
to check whether page is a regular slab page or a pass-through page.
Also moves kmalloc_large() out-of-line as it's too big for inlining now.
Cc: Christoph Lameter <clameter@sgi.com>
Cc: Matt Mackall <mpm@selenic.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: David Howel...
| May 21, 2:25 pm 2008 |
| Christoph Lameter | Re: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page ...
Why is it too big? Without your additions it is converting kmallocs
inline to get_free_pages(). That results in a simple function call with
two constant parameters.
The patch touches the page struct uselessly. I think the PageSlab marking
is useful for debugging but not for a production kernel.
--
| May 21, 2:52 pm 2008 |
| Pekka Enberg | Re: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page ...
Well, it's a PITA because of #include dependencies in any case. Is
moving it out-of-line a problem?
Hmm, where? page_address() already references ->virtual. I suppose
CONFIG_SLUB_DEBUG is a no no as well then so do we want to add a
CONFIG_KSIZE_DEBUG config option...? (Btw, I removed the BUG_ON() from
kfree() as spotted by Vegard Nossum.)
Pekka
--
| May 21, 2:56 pm 2008 |
| previous day | today | next day |
|---|---|---|
| May 20, 2008 | May 21, 2008 | May 22, 2008 |
| Greg Kroah-Hartman | [PATCH 008/196] Chinese: add translation of volatile-considered-harmful.txt |
| Tarkan Erimer | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| Greg KH | Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in |
| Andrew Morton | -mm merge plans for 2.6.23 |
git: | |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
| Herbert Xu | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| David Miller | [GIT]: Networking |
| Rémi Denis-Courmont | [PATCH 01/14] Phonet global definitions |
