Home » Mailing list archives » linux-kernel » 2008 » May » 21

Re: Suspected regression in "x86: extend e820 ealy_res support 32bit"

Previous thread: success by Justin Mattock on Wednesday, May 21, 2008 - 4:05 pm. (1 message)

Next thread: [PATCH 0/8] x86: Timer through APIC and related clean-ups by Maciej W. Rozycki on Wednesday, May 21, 2008 - 5:08 pm. (3 messages)
[view original message]
From: Yinghai Lu <yhlu.kernel@...>
To: Jeremy Fitzhardinge <jeremy@...>
Cc: Ingo Molnar <mingo@...>, kernel list <linux-kernel@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>
Subject: Re: Suspected regression in "x86: extend e820 ealy_res support 32bit"
Date: Wednesday, May 21, 2008 - 4:35 pm

thanks. please check the attached patch


YH
[view original message]
From: Johannes Weiner <hannes@...>
To: Yinghai Lu <yhlu.kernel@...>
Cc: Jeremy Fitzhardinge <jeremy@...>, Ingo Molnar <mingo@...>, kernel list <linux-kernel@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>
Subject: Re: Suspected regression in "x86: extend e820 ealy_res support 32bit"
Date: Wednesday, May 21, 2008 - 7:14 pm

Hi,


Besides, what did you want to accomplish?


	Hannes

--
[view original message]
From: Yinghai Lu <yhlu.kernel@...>
To: Johannes Weiner <hannes@...>
Cc: Jeremy Fitzhardinge <jeremy@...>, Ingo Molnar <mingo@...>, kernel list <linux-kernel@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>
Subject: Re: Suspected regression in "x86: extend e820 ealy_res support 32bit"
Date: Wednesday, May 21, 2008 - 7:23 pm

please drop this patch...


YH

--
[view original message]
From: Jeremy Fitzhardinge <jeremy@...>
To: Yinghai Lu <yhlu.kernel@...>
Cc: Ingo Molnar <mingo@...>, kernel list <linux-kernel@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>
Subject: Re: Suspected regression in "x86: extend e820 ealy_res support 32bit"
Date: Wednesday, May 21, 2008 - 6:01 pm

Thanks for the quick response.  I definitely confirmed that "x86: extend

e820 ealy_res support 32bit" is the source of the regression, and

reverting the change makes the system bootable under Xen. (My previous

reversion failed because I didn't actually have the x86.git changes

applied :-/)


This patch generates the warning:


      CC      arch/x86/kernel/setup_32.o

    /home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/setup_32.c: In

    function ‘setup_arch’:

    /home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/setup_32.c:580:

    warning: ‘bootmap_size’ is used uninitialized in this function


but I think it's just that the panic() message still uses it before its

assigned.


Hm, and it also fails to fix the problem.  I'm still seeing the virtual

machine crash in the same way.


Thanks,

    J

--
[view original message]
From: Yinghai Lu <yhlu.kernel@...>
To: Jeremy Fitzhardinge <jeremy@...>
Cc: Ingo Molnar <mingo@...>, kernel list <linux-kernel@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>
Subject: Re: Suspected regression in "x86: extend e820 ealy_res support 32bit"
Date: Wednesday, May 21, 2008 - 6:40 pm

noticed that bootmap_size is shifted already...


please use attached patch to see if bootmap is right...


YH
[view original message]
From: Jeremy Fitzhardinge <jeremy@...>
To: Yinghai Lu <yhlu.kernel@...>
Cc: Ingo Molnar <mingo@...>, kernel list <linux-kernel@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>
Subject: Re: Suspected regression in "x86: extend e820 ealy_res support 32bit"
Date: Wednesday, May 21, 2008 - 7:23 pm

Unfortunately its a bit difficult because printk() output isn't

appearing at early boot (not sure why).  I'll try to extract something

useful tomorrow.


Perhaps this is helpful:


This the e820 map of a regular boot:


BIOS-provided physical RAM map:

 Xen: 0000000000000000 - 000000000009f000 (usable)

 Xen: 0000000000100000 - 0000000010000000 (usable)

debug: ignoring loglevel setting.

 limit_regions start: 0000000000000000 - 000000000009f000 (usable)

 limit_regions start: 0000000000100000 - 0000000010000000 (usable)

 limit_regions endfunc: 0000000000000000 - 000000000009f000 (usable)

 limit_regions endfunc: 0000000000100000 - 0000000010000000 (usable)

user-defined physical RAM map:

 user: 0000000000000000 - 000000000009f000 (usable)

 user: 0000000000100000 - 0000000010000000 (usable)

0MB HIGHMEM available.

256MB LOWMEM available.

[...]

Entering add_active_range(0, 0, 65536) 0 entries of 256 used

Zone PFN ranges:

  DMA             0 ->     4096

  Normal       4096 ->    65536

  HighMem     65536 ->    65536

Movable zone start PFN for each node

early_node_map[1] active PFN ranges

    0:        0 ->    65536

On node 0 totalpages: 65536

  DMA zone: 56 pages used for memmap

  DMA zone: 0 pages reserved

  DMA zone: 4040 pages, LIFO batch:0

  Normal zone: 840 pages used for memmap

  Normal zone: 60600 pages, LIFO batch:15

  HighMem zone: 0 pages used for memmap

  Movable zone: 0 pages used for memmap


.config attached.


    J
[view original message]
From: Yinghai Lu <yhlu.kernel@...>
To: Jeremy Fitzhardinge <jeremy@...>
Cc: Ingo Molnar <mingo@...>, kernel list <linux-kernel@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>
Subject: Re: Suspected regression in "x86: extend e820 ealy_res support 32bit"
Date: Wednesday, May 21, 2008 - 9:43 pm

please check patch


http://lkml.org/lkml/2008/5/21/570


[PATCH] x86: extend e820 ealy_res support 32bit - fix


also please try to boot with

console=uart8250,io,0x3f8,115200n8

to get more early printout...


YH

--
Previous thread: success by Justin Mattock on Wednesday, May 21, 2008 - 4:05 pm. (1 message)

Next thread: [PATCH 0/8] x86: Timer through APIC and related clean-ups by Maciej W. Rozycki on Wednesday, May 21, 2008 - 5:08 pm. (3 messages)