login
Login
/
Register
Search
Header Space
Forums
News
Jobs
Blogs
Features
Man Pages
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
21
Re: Suspected regression in "x86: extend e820 ealy_res support 32bit"
view
thread
Score:
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Johannes Weiner <hannes@...>
To: Yinghai Lu <yhlu.kernel@...>
Cc: Jeremy Fitzhardinge <jeremy@...>, Ingo Molnar <mingo@...>, kernel list <linux-kernel@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>
Subject:
Re: Suspected regression in "x86: extend e820 ealy_res support 32bit"
Date: Wednesday, May 21, 2008 - 7:14 pm
Hi, "Yinghai Lu" <yhlu.kernel@gmail.com> writes:
quoted text
> On Wed, May 21, 2008 at 11:19 AM, Jeremy Fitzhardinge <jeremy@goop.org> wrote: >> I'm seeing a crash in current x86.git tip/auto-latest when booting under >> Xen. The crash is rather early, but it's in __alloc_bootmem_core() in the >> final memset clear. Apparently the allocator is returning a bad page. >> >> This points to changes in the setup of the bootmem allocator, and the >> changes "x86: extend e820 ealy_res support 32bit" make to >> arch/x86/kernel/setup_32.c:setup_bootmem_allocator() looks like the most >> likely suspect. Unfortunately its a rather large patch which is not easy to >> revert, so I haven't actually confirmed this yet. > > > thanks. please check the attached patch > > YH > > [PATCH] x86: bootmap size fix for 32 bit > > Jeremy Fitzhardinge found > x86: extend e820 ealy_res support 32bit > cause regression... > > in setup_bootmem_allocator > > Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> > > diff --git a/arch/x86/kernel/setup_32.c b/arch/x86/kernel/setup_32.c > index f38d840..938c7b3 100644 > --- a/arch/x86/kernel/setup_32.c > +++ b/arch/x86/kernel/setup_32.c > @@ -566,17 +566,22 @@ static void __init relocate_initrd(void) > > void __init setup_bootmem_allocator(void) > { > + unsigned long bootmap_pages; > unsigned long bootmap_size, bootmap; > /* > * Initialize the boot-time allocator (with low memory only): > */ > - bootmap_size = bootmem_bootmap_pages(max_low_pfn)<<PAGE_SHIFT; > + bootmap_pages = bootmem_bootmap_pages(max_low_pfn)<<PAGE_SHIFT;
Forgot to remove the shift?
quoted text
> bootmap = find_e820_area(min_low_pfn<<PAGE_SHIFT, > - max_low_pfn<<PAGE_SHIFT, bootmap_size, > + max_low_pfn<<PAGE_SHIFT, > + bootmap_pages<<PAGE_SHIFT,
Because this value is hardly sane anymore.
quoted text
> PAGE_SIZE); > if (bootmap == -1L) > panic("Cannot find bootmem map of size %ld\n", bootmap_size); > bootmap_size = init_bootmem(bootmap >> PAGE_SHIFT, max_low_pfn); > + printk(KERN_INFO " bootmap [%016lx - %016lx] pages %lx\n", > + bootmap, bootmap + bootmap_size - 1, > + bootmap_pages); > register_bootmem_low_pages(max_low_pfn); > early_res_to_bootmem(0, max_low_pfn<<PAGE_SHIFT); > reserve_bootmem(bootmap, bootmap_size, BOOTMEM_DEFAULT);
Besides, what did you want to accomplish? Hannes --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
Re: Suspected regression in "x86: extend e820 ealy_res suppo...
, Yinghai Lu
, (Wed May 21, 4:35 pm)
Re: Suspected regression in "x86: extend e820 ealy_res suppo...
, Johannes Weiner
, (Wed May 21, 7:14 pm)
Re: Suspected regression in "x86: extend e820 ealy_res suppo...
, Yinghai Lu
, (Wed May 21, 7:23 pm)
Re: Suspected regression in "x86: extend e820 ealy_res suppo...
, Jeremy Fitzhardinge
, (Wed May 21, 6:01 pm)
Re: Suspected regression in "x86: extend e820 ealy_res suppo...
, Yinghai Lu
, (Wed May 21, 6:40 pm)
Re: Suspected regression in "x86: extend e820 ealy_res suppo...
, Jeremy Fitzhardinge
, (Wed May 21, 7:23 pm)
Re: Suspected regression in "x86: extend e820 ealy_res suppo...
, Yinghai Lu
, (Wed May 21, 9:43 pm)
Navigation
Create content
Mailing list archives
Recent posts
Mail archive search
Enter your search terms.
all mailing lists
alsa-devel
dragonflybsd-bugs
dragonflybsd-commit
dragonflybsd-docs
dragonflybsd-kernel
dragonflybsd-submit
dragonflybsd-user
freebsd-announce
freebsd-bugs
freebsd-chat
freebsd-cluster
freebsd-current
freebsd-drivers
freebsd-embeded
freebsd-fs
freebsd-hackers
freebsd-hardware
freebsd-mobile
freebsd-net
freebsd-performance
freebsd-pf
freebsd-security
freebsd-security-notifications
freebsd-threads
git
git-commits-head
linux-activists
linux-arm
linux-ath5k-devel
linux-btrfs
linux-c-programming
linux-driver-devel
linux-ext4
linux-fsdevel
linux-ia64
linux-input
linux-kernel
linux-kernel-janitors
linux-kernel-mentors
linux-kernel-newbies
linux-kvm
linux-net
linux-netdev
linux-newbie
linux-nfs
linux-raid
linux-scsi
linux-security-module
linux-sparse
linux-usb
linux-usb-devel
madwifi-devel
netbsd-announce
netbsd-tech-kern
openbsd-announce
openbsd-bugs
openbsd-ipv6
openbsd-misc
openbsd-security-announce
openbsd-smp
openbsd-source-changes
openbsd-tech
openfabrics-general
openmoko-community
openmoko-devel
openmoko-kernel
reiserfs-devel
tux3
ucarp
Optionally limit your search to a specific mailing list.
advanced
Popular discussions
linux-kernel
:
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Ingo Molnar
Re: [BUG] New Kernel Bugs
Tony Lindgren
[PATCH 42/90] ARM: OMAP: Tabify mux.c
Roland Dreier
Re: Integration of SCST in the mainstream Linux kernel
git
:
Martin Langhoff
Re: pack operation is thrashing my server
Andreas Ericsson
Re: VCS comparison table
Ingo Molnar
[OT] Your branch is ahead of the tracked remote branch 'origin/master' by 50 commi...
Nicolas Vilz 'niv'
git + ssh + key authentication feature-request
openbsd-misc
:
Richard Stallman
Real men don't attack straw men
Darren Spruell
Re: About Xen: maybe a reiterative question but ..
Nick Holland
Re: 4.1 on ALIX.1C - recommendations?
Lord Sporkton
Re: low-MHz server
linux-netdev
:
KOSAKI Motohiro
[bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"
Mark Lord
Re: 2.6.25-rc8: FTP transfer errors
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Brandeburg, Jesse
RE: e1000 full-duplex TCP performance well below wire speed
Latest forum posts
high memory
1 day ago
Linux kernel
semaphore access speed
1 day ago
Applications and Utilities
the kernel how to power off the machine
1 day ago
Linux kernel
Easter Eggs in windows XP
1 day ago
Windows
Shared swap partition
1 day ago
Linux general
Root password
1 day ago
Linux general
Where/when DNOTIFY is used?
1 day ago
Linux kernel
How to convert Linux Kernel built-in module into a loadable module
1 day ago
Linux kernel
Linux 2.6.24 and I/O schedulers
1 day ago
Linux kernel
USB Driver -- Interrupt Polling -- A Little Help Please
2 days ago
Linux general
Show all forums...
Recent Tags
quote
-rc
Linus Torvalds
bugs
Intel
-rc8
2.6.27
2.6.27-rc8
Linux
more tags
Colocation donated by:
Who's online
There are currently
3 users
and
827 guests
online.
Online users
strcmp
jnareb
Mr_Z
Syndicate
speck-geostationary