Home » Mailing list archives » linux-kernel » 2008 » May » 21

[PATCH 3/8] x86: I/O APIC: Clean up after a fasteoi failure

Previous thread: [PATCH 2/8] x86: I/O APIC: Remove parameters to fiddle with the 8259A by Maciej W. Rozycki on Wednesday, May 21, 2008 - 2:09 pm. (1 message)

Next thread: [PATCH 4/8] x86: I/O APIC: Keep IRQ off when changing LVT registers by Maciej W. Rozycki on Wednesday, May 21, 2008 - 2:09 pm. (1 message)
[view original message]
From: Maciej W. Rozycki
Subject: [PATCH 3/8] x86: I/O APIC: Clean up after a fasteoi failure
Date: Wednesday, May 21, 2008 - 2:09 pm

Disable the 8259A when routing of the timer interrupt through the chip to 
the local APIC of the primary processor has failed.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
patch-2.6.26-rc1-20080505-timer-fasteoi-cleanup-0
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_32.c linux-2.6.26-rc1-20080505/arch/x86/kernel/io_apic_32.c
--- linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_32.c	2008-05-21 18:51:28.000000000 +0000
+++ linux-2.6.26-rc1-20080505/arch/x86/kernel/io_apic_32.c	2008-05-21 18:52:36.000000000 +0000
@@ -2228,6 +2228,7 @@ static inline void __init check_timer(vo
 		printk(" works.\n");
 		goto out;
 	}
+	disable_8259A_irq(0);
 	apic_write_around(APIC_LVT0, APIC_LVT_MASKED | APIC_DM_FIXED | vector);
 	printk(" failed.\n");
 
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_64.c linux-2.6.26-rc1-20080505/arch/x86/kernel/io_apic_64.c
--- linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_64.c	2008-05-18 00:24:43.000000000 +0000
+++ linux-2.6.26-rc1-20080505/arch/x86/kernel/io_apic_64.c	2008-05-21 19:00:05.000000000 +0000
@@ -1729,6 +1729,7 @@ static inline void __init check_timer(vo
 		apic_printk(APIC_VERBOSE," works.\n");
 		goto out;
 	}
+	disable_8259A_irq(0);
 	apic_write(APIC_LVT0, APIC_LVT_MASKED | APIC_DM_FIXED | cfg->vector);
 	apic_printk(APIC_VERBOSE," failed.\n");
 
--


[ message continues ]
Previous thread: [PATCH 2/8] x86: I/O APIC: Remove parameters to fiddle with the 8259A by Maciej W. Rozycki on Wednesday, May 21, 2008 - 2:09 pm. (1 message)

Next thread: [PATCH 4/8] x86: I/O APIC: Keep IRQ off when changing LVT registers by Maciej W. Rozycki on Wednesday, May 21, 2008 - 2:09 pm. (1 message)