login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
21
Re: [PATCH] USB: fix deadlock in HCD code
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Leonardo Chiquitto <lchiquitto@...>
To: Alan Stern <stern@...>, Jiri Kosina <jkosina@...>
Cc: Greg KH <greg@...>, Oliver Neukum <oliver@...>, <linux-kernel@...>, <linux-usb@...>
Subject:
Re: [PATCH] USB: fix deadlock in HCD code
Date: Wednesday, May 21, 2008 - 3:32 pm
>> > > Used in the suspend code. Your patch is indeed correct, but I fear
quoted text
>> > > there might be a second bug caused by wrong calling conditions. >> > The problem in the Novell bugzilla entry was caused by the fact that the >> > OHCI irq routine was invoked with interrupts enabled, owing to a missing >> > IRQF_DISABLED flag. That bug has already been fixed in 2.6.25. >> >> That indeed is 2.6.25 kernel. I guess you are talking about commit >> 442258e2ff69 here. > > Yes. > >> If so, the reporter is definitely using the kernel >> containing this commit, and the lockups still trigger. >> >> Seems that my patch is papering over the real bug (someone enabling >> interrupts somewhere) indeed, but I can't seem to be able to find such >> codepath. > > You could try testing the interrupt-enable flag at various places > in ohci-hcd (start with finish_urb) and printing an error message if > interrupts are enabled. > > One possibility is that in an earlier call to finish_urb, > usb_hcd_giveback_urb was called with interrupts disabled and returned > with interrupts enabled. In other words, some driver's callback > routine may have enabled interrupts incorrectly.
Alan, I am trying your suggestion right now. Lets see if it finds something. Thanks, Leonardo --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] USB: fix deadlock in HCD code
, Jiri Kosina
, (Wed May 21, 8:09 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Peter Zijlstra
, (Wed May 21, 6:26 pm)
Re: [PATCH] USB: fix deadlock in HCD code
, Oliver Neukum
, (Wed May 21, 9:21 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Jiri Kosina
, (Wed May 21, 9:27 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Oliver Neukum
, (Wed May 21, 9:40 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Oliver Neukum
, (Wed May 21, 9:32 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Jiri Kosina
, (Wed May 21, 9:36 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Oliver Neukum
, (Wed May 21, 9:47 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Alan Stern
, (Wed May 21, 10:13 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Jiri Kosina
, (Wed May 21, 10:22 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Alan Stern
, (Wed May 21, 10:46 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Oliver Neukum
, (Wed May 21, 4:03 pm)
Re: [PATCH] USB: fix deadlock in HCD code
, Leonardo Chiquitto
, (Wed May 21, 3:32 pm)
Re: [PATCH] USB: fix deadlock in HCD code
, David Vrabel
, (Wed May 21, 10:29 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Alan Stern
, (Wed May 21, 10:42 am)
Re: [PATCH] USB: fix deadlock in HCD code
, David Vrabel
, (Wed May 21, 10:53 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Alan Stern
, (Wed May 21, 10:58 am)
Re: [PATCH] USB: fix deadlock in HCD code
, Oliver Neukum
, (Wed May 21, 10:31 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Jeremy Allison
Re: [RFC] Heads up on sys_fallocate()
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Joerg Roedel
[PATCH 03/34] AMD IOMMU: add defines and structures for ACPI scanning code
Eric W. Biederman
[PATCH] powerpc pseries eeh: Convert to kthread API
linux-netdev
:
David Miller
[GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Natalie Protasevich
[BUG] New Kernel Bugs
git
:
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
2 users
and
864 guests
online.
Online users
strcmp
danahouse
Syndicate