On Wed, May 21, 2008 at 10:44:18AM -0700, Andrew Morton wrote:
It probably did make things marginally worse from that standpoint, but
the code style weanies also make things worse, so at least IMHO it's a
wash.
I'd suggest that the more aggressive public code reviews and the
perception that it is highly painful, time-consuming, and expensive to
get code merged up. But of course we need that to maintain quality.
Even if we eliminated all code style weanies slapdowns, if a Asian
Engineer submits a patchset, and it gets (rightly) ripped to pieces by
Cristoph for all sorts of code quality problems, and by Al Viro
because it intrdoces tons and tons of deadlocks, we'll still have the
potential problem that the Asian engineer feels that he has shamed his
company and has to resign or will get fired by his management.
The only way to solve that problem is either to change the perception
of Asian engineers and at their companies (and there has been some
success along that line that what is being attacked is the code, not
the submitter), and we could meet them halfway by offering to do an
initial code reivew privately so they don't have to feel that they are
getting publically humiliated. (And there is a little of that going
on, informally, as well.)
So yes, it's a problem, and I'd agree if this was an gratuitously mean
code review. i.e., the difference between, "isn't this a locking
hierarchy violation?" vs "Congratulations! You've just completely
screwed up VM locking hierarchy, you idiot!".
People have been a bit frustrated by the stupid patches and people who
waste time with whitespace patches or running checkpatch.pl on random
files, so it's a bit understandable that they might slap down those
folks --- and I would hope that one of these Asian engineers would be
able to see the difference between a desperately needed slapdown and
the reception they might get when they submit a patch to be merged up.
(But if they are getting their patches ripped apart during the code
review, and that's causing them to lose face inside their company,
that's a different problem.)
- Ted
--
