Re: [PATCH 1/3] signals: sigqueue_free: don't free sigqueue if it is queued

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: Oleg Nesterov <oleg@...>, Andrew Morton <akpm@...>, Austin Clements <amdragon+kernelbugzilla@...>, Ingo Molnar <mingo@...>, john stultz <johnstul@...>, Michael Kerrisk <mtk.manpages@...>, Thomas Gleixner <tglx@...>, <linux-kernel@...>
Date: Wednesday, May 21, 2008 - 3:33 pm

> I thought we didn't even know which queue it was pending on if it was 

Removing the entry without fixing the pending set is the bug we're trying
to fix.  That's what it does now, and it's wrong.

Oleg had a patch that marked the sigqueue entry with whether it was on the
shared queue or not.  The caller in timer_delete knows which thread it is
when it's on a thread queue, and whether it's on the shared queue.  So it
could be the caller's responsibility to know, i.e. its sigqueue_free call
matches its send_sigqueue call.


Thanks,
Roland
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 1/3] signals: sigqueue_free: don't free sigqueue ..., Roland McGrath, (Wed May 21, 3:33 pm)