Home » Mailing list archives » linux-kernel » 2008 » May » 21

Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page allocator pass-through

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Matt Mackall <mpm@...>
To: Pekka J Enberg <penberg@...>
Cc: <linux-kernel@...>, <clameter@...>, <lethal@...>, <dhowells@...>
Subject: Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page allocator pass-through
Date: Wednesday, May 21, 2008 - 3:07 pm

On Wed, 2008-05-21 at 21:26 +0300, Pekka J Enberg wrote:

Ok, first, BUG_ON is wrong.

We already know users (ie nommu memory usage reporting) are abusing this
interface. Making them blow up is unnecessary. Just give them wrong
answers. Issuing a warning might be a good idea for debugging.

Second, I'd prefer to keep this sort of debugging code out of SLOB.
SLUB is much better suited to debugging allocator abuse.

-- 
Mathematics is the supreme nostalgia of our time.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RFC/PATCH 3/3] SLOB: make ksize() more strict for page allo..., Pekka J Enberg, (Wed May 21, 2:26 pm)
Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page ..., Matt Mackall, (Wed May 21, 3:07 pm)
Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page ..., Pekka Enberg, (Wed May 21, 3:11 pm)
Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page ..., Christoph Lameter, (Wed May 21, 5:12 pm)
Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page ..., Pekka Enberg, (Wed May 21, 5:13 pm)
Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page ..., Christoph Lameter, (Wed May 21, 5:16 pm)