Home » Mailing list archives » linux-kernel » 2008 » May » 21

Re: [PATCH 1/2] Add thread_info_cache_init() to all archs

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Benjamin Herrenschmidt <benh@...>
To: Andrew Morton <akpm@...>
Cc: Linux-Arch <linux-arch@...>, <linux-m32r@...>, <takata@...>, <linux-kernel@...>, <linuxppc-dev@...>, Paul Mackerras <paulus@...>, Luke Browning <LukeBrowning@...>
Subject: Re: [PATCH 1/2] Add thread_info_cache_init() to all archs
Date: Wednesday, May 21, 2008 - 1:56 pm

On Fri, 2008-04-18 at 16:44 +1000, Benjamin Herrenschmidt wrote:

Back to this old subject...

I'm having reports that this is not working...

gcc is seeing the empty weak function and is optimizing it out
before it gets a chance to link to the arch provided one.

This would affect that and the other one next to it..

That seems pretty bad... it causes nasty crashes as we end up having no
idea what the compiler decided to generate... I suppose we could keep
the weak stubs out of the file where they are called but that sucks.

ie. This is some form of gcc 4.1.1

Is that a known problem ? A gcc issue ? Not sure what is expected from
those weak functions.

Ben.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/2] Add thread_info_cache_init() to all archs, Benjamin Herrenschmidt, (Wed Apr 9, 11:22 pm)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Andrew Morton, (Sun Apr 13, 8:19 pm)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Benjamin Herrenschmidt, (Sun Apr 13, 8:38 pm)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Andrew Morton, (Sun Apr 13, 10:13 pm)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Benjamin Herrenschmidt, (Thu Apr 17, 11:58 pm)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Kyle McMartin, (Fri Apr 18, 12:21 am)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Andrew Morton, (Fri Apr 18, 12:19 am)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Benjamin Herrenschmidt, (Fri Apr 18, 2:44 am)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Benjamin Herrenschmidt, (Wed May 21, 1:56 pm)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Andrew Morton, (Wed May 21, 2:41 pm)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Benjamin Herrenschmidt, (Wed May 21, 3:44 pm)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Andrew Morton, (Wed May 21, 4:52 pm)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Sam Ravnborg, (Wed May 21, 3:06 pm)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Benjamin Herrenschmidt, (Wed May 21, 4:38 pm)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Michael Ellerman, (Fri Apr 18, 12:38 am)
Re: [PATCH 1/2] Add thread_info_cache_init() to all archs, Benjamin Herrenschmidt, (Thu Apr 10, 5:46 pm)