Home » Mailing list archives » linux-kernel » 2008 » May » 21

[PATCH] linux-next: Tree for May 21 - build failure with netfilter on __nf_ct_helper_find()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Kamalesh Babulal <kamalesh@...>
To: Stephen Rothwell <sfr@...>
Cc: <linux-next@...>, LKML <linux-kernel@...>, <netfilter-devel@...>, <apw@...>
Subject: [PATCH] linux-next: Tree for May 21 - build failure with netfilter on __nf_ct_helper_find()
Date: Wednesday, May 21, 2008 - 7:32 am

Hi Stephen,

The next-20080521 kernel build fails, on x86_64 machine 

CC net/netfilter/nf_conntrack_helper.o
net/netfilter/nf_conntrack_helper.c: In function ‘__nf_ct_helper_find’:
net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function ‘hlist_for_each_entry_rcu’
net/netfilter/nf_conntrack_helper.c:58: error: ‘hnode’ undeclared (first use in this function)
net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once
net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.)
net/netfilter/nf_conntrack_helper.c:58: error: expected ‘;’ before ‘{’ token
net/netfilter/nf_conntrack_helper.c:50: warning: unused variable ‘mask’
net/netfilter/nf_conntrack_helper.c: In function ‘__nf_conntrack_helper_find_byname’:
net/netfilter/nf_conntrack_helper.c:74: error: ‘hnode’ undeclared (first use in this function)
net/netfilter/nf_conntrack_helper.c:74: error: expected ‘;’ before ‘{’ token
net/netfilter/nf_conntrack_helper.c: In function ‘nf_conntrack_helper_register’:
net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function ‘hlist_add_head_rcu’
net/netfilter/nf_conntrack_helper.c: In function ‘nf_conntrack_helper_unregister’:
net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function ‘hlist_del_rcu’
make[2]: *** [net/netfilter/nf_conntrack_helper.o] Error 1
make[1]: *** [net/netfilter] Error 2
make: *** [net] Error 2

This build error is because of the missing include file.I have tested
the patch for the build failure only.

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
--- linux-2.6.26-rc3/net/netfilter/nf_conntrack_helper.c	2008-05-20 20:24:14.000000000 +0530
+++ linux-2.6.26-rc3/net/netfilter/~nf_conntrack_helper.c	2008-05-22 00:17:32.000000000 +0530
@@ -20,6 +20,7 @@
 #include <linux/err.h>
 #include <linux/kernel.h>
 #include <linux/netdevice.h>
+#include <linux/rculist.h>
 
 #include <net/netfilter/nf_conntrack.h>
 #include <net/netfilter/nf_conntrack_l3proto.h>
-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
linux-next: Tree for May 21, Stephen Rothwell, (Wed May 21, 1:59 am)
[PATCH] linux-next: Tree for May 21 - build failure with net..., Kamalesh Babulal, (Wed May 21, 7:32 am)
Re: [PATCH] linux-next: Tree for May 21 - build failure with..., Stephen Rothwell, (Wed May 21, 8:52 am)
Re: [PATCH] linux-next: Tree for May 21 - build failure with..., Kamalesh Babulal, (Wed May 21, 9:29 am)
Re: [PATCH] linux-next: Tree for May 21 - build failure with..., Stephen Rothwell, (Wed May 21, 8:11 pm)
Re: [PATCH] linux-next: Tree for May 21 - build failure with..., Ingo Molnar, (Thu May 22, 4:15 am)
Re: [PATCH] linux-next: Tree for May 21 - build failure with..., Stephen Rothwell, (Thu May 22, 7:29 pm)