Hi,

There are three methods in the network stack which start with
#ifndef I_WISH_WORLD_WERE_PERFECT.

These methods are:
ipip_err() in net/ipv4/ipip.c
ipgre_err() in net/ipv4/ip_gre.c
ipip6_err() in net/ipv6/sit.c

When building the kernel with -DI_WISH_WORLD_WERE_PERFECT we have
various compilation
errors, mostly due to the fact that the corresponding code was not
updated recently.

(As we all know, indeed the world is not perfect, unluckily...)

This patch fixes these errors and enables building the kernel
successfully with -DI_WISH_WORLD_WERE_PERFECT.

(Note : I am not fully sure about correctness of len = skb->len, which I added;
feedback on this point is welcomed).


Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>
[ message continues ]

From: "Rami Rosen" <ramirose@gmail.com>

I think it is better to delete this code.  It is impossible
for anyone to build test it without making source modifications,
therefore it will continute to break over and over again over
time.
--

[ message continues ]

Hi,
  Unless there will be any objection here, I suggest consider the
following patch which simply removes the code for the
-DI_WISH_WORLD_WERE_PERFECT in the three methods which use it.

The compilation errors we get when using -DI_WISH_WORLD_WERE_PERFECT
show that this code was not built and not used for really a long time.

Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>


[ message continues ]

From: "Rami Rosen" <ramirose@gmail.com>

Applied, thanks for following up on this Rami.
--

[ message continues ]