Home » Mailing list archives » linux-kernel » 2008 » May » 21

Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when the timer is destroyed

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roland McGrath <roland@...>
To: Oleg Nesterov <oleg@...>
Cc: Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, Austin Clements <amdragon+kernelbugzilla@...>, Ingo Molnar <mingo@...>, john stultz <johnstul@...>, Michael Kerrisk <mtk.manpages@...>, Thomas Gleixner <tglx@...>, <linux-kernel@...>
Subject: Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when the timer is destroyed
Date: Tuesday, May 20, 2008 - 10:27 pm

> 	q->flags |= SIGQUEUE_CANCELLED;

Just make it:

	spin_lock_irqsave(lock, flags);
	q->flags |= SIGQUEUE_CANCELLED;
	q->flags &= ~SIGQUEUE_PREALLOC;

and we needn't wax philosophical about the meaning of locking rules.  That
patch would have my ACK, but I concur with Linus about the undesireability
of the plain = version.


Thanks,
Roland
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when the ti..., Oleg Nesterov, (Sat May 17, 11:14 am)
Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when th..., Oleg Nesterov, (Sat May 17, 11:31 am)
Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when th..., Linus Torvalds, (Sat May 17, 1:11 pm)
Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when th..., Oleg Nesterov, (Sun May 18, 1:15 pm)
Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when th..., Roland McGrath, (Tue May 20, 10:27 pm)
Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when th..., Linus Torvalds, (Sun May 18, 1:24 pm)
Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when th..., Oleg Nesterov, (Sun May 18, 1:46 pm)
Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when th..., Linus Torvalds, (Sun May 18, 1:40 pm)