Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-try-2.patch added to -mm tree

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Andrew Morton <akpm@...>

Cc: Bryan Wu <cooloney@...>, <linux-kernel@...>, <michael.hennerich@...>

Subject: Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-try-2.patch added to -mm tree

Date: Tuesday, May 20, 2008 - 8:41 pm

On Tue, May 20, 2008 at 4:02 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
quoted text> On Tue, 20 May 2008 15:51:13 +0800 "Bryan Wu" <cooloney@kernel.org> wrote:
>> Need I resend out the a new patch which fold these 3 patches together.
>> it is easier for you to maintain.
>
> Nope,  I keep the patches separate and then fold them prior to sending
> to Linus.
>
> I marked this as for-2.6.26 as it's clearly non-injurious to existing stuff.
>
> This:
>
>> -#if defined(__arm__) || defined(__mips__) || defined(__avr32__)
>> +#if defined(__arm__) || defined(__mips__) || defined(__avr32__) || defined(bfin)
>
> should probably be using CONFIG_foo but that might not work if it's to
> be preprocessed by userspace.  I didn't look.  Plus that'd be
> off-topic.

it should be defined(__bfin__) at least.  perhaps i should add that
check to checkpatch.pl as well ...
-mike
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-t..., Bryan Wu, (Tue May 20, 3:51 am)

Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-t..., Mike Frysinger, (Wed May 21, 7:34 pm)

RE: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-t..., Hennerich, Michael, (Tue May 27, 7:15 am)

Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-t..., Bryan Wu, (Tue May 27, 11:49 am)

Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-t..., Andrew Morton, (Tue May 20, 4:02 am)

Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-t..., Mike Frysinger, (Tue May 20, 8:41 pm)

Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-t..., Andrew Morton, (Wed May 21, 7:11 pm)

Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-t..., Mike Frysinger, (Wed May 21, 7:23 pm)


linux-kernel:
Amit K. Arora	[RFC] Heads up on sys_fallocate()
Linus Torvalds	Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..
Paul Jackson	Re: cpuset-remove-sched-domain-hooks-from-cpusets
Greg KH	[GIT PATCH] driver core patches against 2.6.24
git:

linux-netdev:
Linus Torvalds	Re: [GIT]: Networking
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	Re: [klibc] [patch] import socket defines
openbsd-misc:

Re: + pcmcia-add-support-the-cf-pcmcia-driver-for-blackfin-try-2.patch added to -mm tree

Online users