Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from lib/hexdump.c instead

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: <harvey.harrison@...>

Cc: <crquan@...>, <herbert@...>, <netdev@...>, <linux-kernel@...>

Subject: Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from lib/hexdump.c instead

Date: Tuesday, May 20, 2008 - 6:45 pm

From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Tue, 20 May 2008 15:40:12 -0700

quoted text> On Tue, 2008-05-20 at 15:36 -0700, David Miller wrote:
> > From: Denis Cheng <crquan@gmail.com>
> > Date: Mon, 19 May 2008 02:37:44 +0800
> > 
> > > Here the local hexbuf is a duplicate of global const char hex_asc from
> > > lib/hexdump.c, except the hex letters' cases:
> > > 
> > > const char hexbuf[] = "0123456789ABCDEF";
> > > 
> > > const char hex_asc[] = "0123456789abcdef";
> > > 
> > > and here to print HW addresses, the hex cases are not significant.
> > > 
> > > Signed-off-by: Denis Cheng <crquan@gmail.com>
> > 
> > Applied, thanks.
> 
> You may want to use the hex_asc_hi, hex_asc_lo helpers to do the
> mask/shifts for you.

Good idea, I'll revert, Denis can you generate a new patch?

Thanks.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] net/ipv4/arp.c: Use the exported hex_asc from lib/he..., Denis Cheng, (Sun May 18, 2:37 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from li..., David Miller, (Tue May 20, 6:36 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from li..., Harvey Harrison, (Tue May 20, 6:41 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from li..., Harvey Harrison, (Tue May 20, 6:40 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from li..., David Miller, (Tue May 20, 6:45 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from li..., rae l, (Tue May 20, 10:27 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from li..., David Miller, (Wed May 21, 8:35 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from li..., Harvey Harrison, (Wed May 21, 8:37 pm)


linux-kernel:
Greg KH	[GIT PATCH] driver core patches against 2.6.24
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3

Rob Landley	What still uses the block layer?
git:

linux-netdev:
Antonio Almeida	HTB accuracy for high speed
Alexey Dobriyan	Re: [GIT]: Networking
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
openbsd-misc:

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from lib/hexdump.c instead

Online users