Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from lib/hexdump.c instead

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Harvey Harrison

Subject: Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from lib/hexdump.c instead

Date: Tuesday, May 20, 2008 - 3:40 pm

On Tue, 2008-05-20 at 15:36 -0700, David Miller wrote:
quoted text> From: Denis Cheng <crquan@gmail.com>
> Date: Mon, 19 May 2008 02:37:44 +0800
> 
> > Here the local hexbuf is a duplicate of global const char hex_asc from
> > lib/hexdump.c, except the hex letters' cases:
> > 
> > const char hexbuf[] = "0123456789ABCDEF";
> > 
> > const char hex_asc[] = "0123456789abcdef";
> > 
> > and here to print HW addresses, the hex cases are not significant.
> > 
> > Signed-off-by: Denis Cheng <crquan@gmail.com>
> 
> Applied, thanks.

You may want to use the hex_asc_hi, hex_asc_lo helpers to do the
mask/shifts for you.

Harvey

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] net/ipv4/arp.c: Use the exported hex_asc from lib/ ..., Denis Cheng, (Sun May 18, 11:37 am)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from ..., David Miller, (Tue May 20, 3:36 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from ..., Harvey Harrison, (Tue May 20, 3:40 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from ..., Harvey Harrison, (Tue May 20, 3:41 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from ..., David Miller, (Tue May 20, 3:45 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from ..., rae l, (Tue May 20, 7:27 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from ..., David Miller, (Wed May 21, 5:35 pm)

Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from ..., Harvey Harrison, (Wed May 21, 5:37 pm)


linux-kernel:
Christoph Lameter	[PATCH 1/2] Make page->private usable in compound pages V1
Luben Tuikov	Re: Integration of SCST in the mainstream Linux kernel
Alexey Dobriyan	Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
Michal Nazarewicz	Re: [PATCH] USB: Gadget: g_multi: added INF file for gadget with multiple configur...
Jesse Barnes	Re: PCI probing changes
git:
Jakub Narebski	Re: GSoC 2008 - Mentors Wanted!
Jan Harkes	Re: git-svn and huge data and modifying the git-svn-HEAD branch directly
Andy Parkins	git-fetch fails with error code 128
Marcus Griep	Re: [PATCH 1/3] Git.pm: Add faculties to allow temp files to be cached
Junio C Hamano	Re: [JGIT PATCH 2/2] Decrease the fetch pack client buffer to the lower minimum
git-commits-head:
Linux Kernel Mailing List	ARM: 5970/1: nomadik-gpio: fix spinlock usage
Linux Kernel Mailing List	sh-sci: update receive error handling for muxed irqs
Linux Kernel Mailing List	No need to do lock_super() for exclusion in generic_shutdown_super()
Linux Kernel Mailing List	x86, msr: Export the register-setting MSR functions via /dev/*/msr
Linux Kernel Mailing List	Input: gpio-keys - add support for disabling gpios through sysfs
linux-netdev:
Eric Dumazet	[PATCH] net: ALIGN/PTR_ALIGN cleanup in alloc_netdev_mq()/netdev_priv()
Patrick McHardy	[NET_SCHED]: sch_ingress: remove netfilter support
Rose, Gregory V	RE: __bad_udelay in network driver breaks build
Patrick McHardy	Re: no reassembly for outgoing packets on RAW socket
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc:
ropers	Re: Real men don't attack straw men
elitdostlar	Seks partneri arayan bayanlar bu adreste - 8878xs706x6438
Marcus Andree	Re: This is what Linus Torvalds calls openBSD crowd
Lars D. Noodén	Re: sshd.config and AllowUsers
Henning Brauer	Re: Sun Blade 1000?