Here are some patches against your 2.6.26-rc3-git tree.
They fix a race condition when device_create is called.  At that point

in time sysfs files can be created automatically by the class or the

driver subsystem, and if those files are opened before the device

specific data is set, oopses can happen.  This was found and reported

for the bdi subsystem by Arthur Jones and he verified that these patches

fix the problem.
I then went and audited all users of the api and found other places

where this was also a problem.  This patch series fixes all of those

instances.
The API will be chaned in 2.6.27 so this can not happen in the future by

making device_create() look exactly like device_create_drvdata() but to

do that now would require a few hundred other changes through the tree.

I'll leave that for .27 and have patches queued up right now in -next

for this so it gets good testing.
These patches have been in -mm and -next.
Please pull from:

	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-2.6.git/
The patchs will be sent as a follow-on to this message to lkml for

people to see.
thanks,
greg k-h
------------
 drivers/base/core.c                    |   85 +++++++++++++++++++++++++++++--

 drivers/ide/ide-probe.c                |    5 +-

 drivers/infiniband/core/user_mad.c     |   14 ++---

 drivers/infiniband/core/uverbs_main.c  |   11 ++--

 drivers/leds/led-class.c               |    6 +--

 drivers/power/power_supply_core.c      |    6 +--

 drivers/s390/char/vmlogrdr.c           |    9 ++--

 drivers/scsi/ch.c                      |    7 +--

 drivers/scsi/osst.c                    |    3 +-

 drivers/scsi/sg.c                      |   11 ++--

 drivers/scsi/st.c                      |   12 +++--

 drivers/uio/uio.c                      |    7 +--

 drivers/usb/core/hcd.c                 |    6 +-

 drivers/usb/misc/phidgetkit.c          |    6 +-

 drivers/usb/misc/phidgetmotorcontrol.c |    7 +--

 drivers/usb/misc/phidgetservo.c        |    6 +-

 drivers/vid...
[ message continues ]

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_drvdata().  It fixes the problem in all of the scsi

drivers that need it.
Cc: Kay Sievers <kay.sievers@vrfy.org>

Cc: Doug Gilbert <dgilbert@interlog.com>

Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/scsi/ch.c   |    7 +++----

 drivers/scsi/osst.c |    3 +--

 drivers/scsi/sg.c   |   11 ++++++-----

 drivers/scsi/st.c   |   12 +++++++-----

 4 files changed, 17 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c

index 75c84d7..c4b938b 100644

--- a/drivers/scsi/ch.c

+++ b/drivers/scsi/ch.c

@@ -910,9 +910,9 @@ static int ch_probe(struct device *dev)

 	ch->minor = minor;

 	sprintf(ch->name,"ch%d",ch->minor);
-	class_dev = device_create(ch_sysfs_class, dev,

-				  MKDEV(SCSI_CHANGER_MAJOR,ch->minor),

-				  "s%s", ch->name);

+	class_dev = device_create_drvdata(ch_sysfs_class, dev,

+					  MKDEV(SCSI_CHANGER_MAJOR, ch->minor),

+					  ch, "s%s", ch->name);

 	if (IS_ERR(class_dev)) {

 		printk(KERN_WARNING "ch%d: device_create failed\n",

 		       ch->minor);

@@ -926,7 +926,6 @@ static int ch_probe(struct device *dev)

 	if (init)

 		ch_init_elem(ch);
-	dev_set_drvdata(dev, ch);

 	sdev_printk(KERN_INFO, sd, "Attached scsi changer %s\n", ch->name);
 	return 0;

diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c

index 31f7aec..243d8be 100644

--- a/drivers/scsi/osst.c

+++ b/drivers/scsi/osst.c

@@ -5695,13 +5695,12 @@ static int osst_sysfs_add(dev_t dev, struct device *device, struct osst_tape * S

 	struct device *osst_member;

 	int err;
-	osst_member = device_create(osst_sysfs_class, device, dev, ...
[ message continues ]

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_drvdata().
Cc: Kay Sievers <kay.sievers@vrfy.org>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/usb/core/hcd.c |    6 +++---

 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c

index bf10e9c..09a53e7 100644

--- a/drivers/usb/core/hcd.c

+++ b/drivers/usb/core/hcd.c

@@ -818,12 +818,12 @@ static int usb_register_bus(struct usb_bus *bus)

 	set_bit (busnum, busmap.busmap);

 	bus->busnum = busnum;
-	bus->dev = device_create(usb_host_class, bus->controller, MKDEV(0, 0),

-				 "usb_host%d", busnum);

+	bus->dev = device_create_drvdata(usb_host_class, bus->controller,

+					 MKDEV(0, 0), bus,

+					 "usb_host%d", busnum);

 	result = PTR_ERR(bus->dev);

 	if (IS_ERR(bus->dev))

 		goto error_create_class_dev;

-	dev_set_drvdata(bus->dev, bus);
 	/* Add it to the local list of buses */

 	list_add (&bus->bus_list, &usb_bus_list);

--

1.5.5.1
--

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_drvdata().  It fixes all 3 phidget drivers, which all have

the same problem.
Cc: Kay Sievers <kay.sievers@vrfy.org>

Cc: Sean Young <sean@mess.org>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/usb/misc/phidgetkit.c          |    6 +++---

 drivers/usb/misc/phidgetmotorcontrol.c |    7 +++----

 drivers/usb/misc/phidgetservo.c        |    6 +++---

 3 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/misc/phidgetkit.c b/drivers/usb/misc/phidgetkit.c

index 24230c6..4cfa25b 100644

--- a/drivers/usb/misc/phidgetkit.c

+++ b/drivers/usb/misc/phidgetkit.c

@@ -595,14 +595,14 @@ static int interfacekit_probe(struct usb_interface *intf, const struct usb_devic

         } while(value);

         kit->dev_no = bit;
-        kit->dev = device_create(phidget_class, &kit->udev->dev, 0,

-               		"interfacekit%d", kit->dev_no);

+	kit->dev = device_create_drvdata(phidget_class, &kit->udev->dev,

+					MKDEV(0, 0), kit,

+					"interfacekit%d", kit->dev_no);

         if (IS_ERR(kit->dev)) {

                 rc = PTR_ERR(kit->dev);

                 kit->dev = NULL;

                 goto out;

         }

-	dev_set_drvdata(kit->dev, kit);
 	if (usb_submit_urb(kit->irq, GFP_KERNEL)) {

 		rc = -EIO;

diff --git a/drivers/usb/misc/phidgetmotorcontrol.c b/drivers/usb/misc/phidgetmotorcontrol.c

index f0113c1..9b4696f 100644

--- a/drivers/usb/misc/phidgetmotorcontrol.c

+++ b/drivers/usb/misc/phidgetmotorcontrol.c

@@ -365,16 +365,15 @@ static int motorcontrol_probe(struct usb_interface *intf, const struct usb_devic

 	} while(value);

 	mc->dev_no = bit;
-	mc->dev = device...
[ message continues ]

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_drvdata().
Cc: Kay Sievers <kay.sievers@vrfy.org>

Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>

Cc: Heiko Carstens <heiko.carstens@de.ibm.com>

Cc: Cornelia Huck <cornelia.huck@de.ibm.com>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/s390/char/vmlogrdr.c |    9 ++++-----

 1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/s390/char/vmlogrdr.c b/drivers/s390/char/vmlogrdr.c

index e848734..2c2428c 100644

--- a/drivers/s390/char/vmlogrdr.c

+++ b/drivers/s390/char/vmlogrdr.c

@@ -762,10 +762,10 @@ static int vmlogrdr_register_device(struct vmlogrdr_priv_t *priv)

 		device_unregister(dev);

 		return ret;

 	}

-	priv->class_device = device_create(vmlogrdr_class, dev,

-					   MKDEV(vmlogrdr_major,

-						 priv->minor_num),

-					   "%s", dev->bus_id);

+	priv->class_device = device_create_drvdata(vmlogrdr_class, dev,

+						   MKDEV(vmlogrdr_major,

+							 priv->minor_num),

+						   priv, "%s", dev->bus_id);

 	if (IS_ERR(priv->class_device)) {

 		ret = PTR_ERR(priv->class_device);

 		priv->class_device=NULL;

@@ -773,7 +773,6 @@ static int vmlogrdr_register_device(struct vmlogrdr_priv_t *priv)

 		device_unregister(dev);

 		return ret;

 	}

-	dev->driver_data = priv;

 	priv->device = dev;

 	return 0;

 }

--

1.5.5.1
--

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_drvdata().
Cc: Kay Sievers <kay.sievers@vrfy.org>

Cc: Jaroslav Kysela <perex@perex.cz>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 sound/core/sound.c |    8 +++-----

 1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/sound/core/sound.c b/sound/core/sound.c

index 812f91b..6c8ab48 100644

--- a/sound/core/sound.c

+++ b/sound/core/sound.c

@@ -259,8 +259,9 @@ int snd_register_device_for_dev(int type, struct snd_card *card, int dev,

 		return minor;

 	}

 	snd_minors[minor] = preg;

-	preg->dev = device_create(sound_class, device, MKDEV(major, minor),

-				  "%s", name);

+	preg->dev = device_create_drvdata(sound_class, device,

+					  MKDEV(major, minor),

+					  private_data, "%s", name);

 	if (IS_ERR(preg->dev)) {

 		snd_minors[minor] = NULL;

 		mutex_unlock(&sound_mutex);

@@ -269,9 +270,6 @@ int snd_register_device_for_dev(int type, struct snd_card *card, int dev,

 		return minor;

 	}
-	if (preg->dev)

-		dev_set_drvdata(preg->dev, private_data);

-

 	mutex_unlock(&sound_mutex);

 	return 0;

 }

--

1.5.5.1
--

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_drvdata().
Cc: Kay Sievers <kay.sievers@vrfy.org>

Cc: Hans J. Koch <hjk@linutronix.de>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/uio/uio.c |    7 +++----

 1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c

index 55cc7b8..0a12e90 100644

--- a/drivers/uio/uio.c

+++ b/drivers/uio/uio.c

@@ -649,15 +649,14 @@ int __uio_register_device(struct module *owner,

 	if (ret)

 		goto err_get_minor;
-	idev->dev = device_create(uio_class->class, parent,

-				  MKDEV(uio_major, idev->minor),

-				  "uio%d", idev->minor);

+	idev->dev = device_create_drvdata(uio_class->class, parent,

+					  MKDEV(uio_major, idev->minor), idev,

+					  "uio%d", idev->minor);

 	if (IS_ERR(idev->dev)) {

 		printk(KERN_ERR "UIO: device register failed\n");

 		ret = PTR_ERR(idev->dev);

 		goto err_device_create;

 	}

-	dev_set_drvdata(idev->dev, idev);
 	ret = uio_dev_add_attributes(idev);

 	if (ret)

--

1.5.5.1
--

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_drvdata().
Cc: Kay Sievers <kay.sievers@vrfy.org>

Cc: Anton Vorontsov <cbou@mail.ru>

Cc: David Woodhouse <dwmw2@infradead.org>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/power/power_supply_core.c |    6 ++----

 1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/power/power_supply_core.c b/drivers/power/power_supply_core.c

index 138dd76..af1633e 100644

--- a/drivers/power/power_supply_core.c

+++ b/drivers/power/power_supply_core.c

@@ -91,15 +91,13 @@ int power_supply_register(struct device *parent, struct power_supply *psy)

 {

 	int rc = 0;
-	psy->dev = device_create(power_supply_class, parent, 0,

-				 "%s", psy->name);

+	psy->dev = device_create_drvdata(power_supply_class, parent, 0,

+					 psy, "%s", psy->name);

 	if (IS_ERR(psy->dev)) {

 		rc = PTR_ERR(psy->dev);

 		goto dev_create_failed;

 	}
-	dev_set_drvdata(psy->dev, psy);

-

 	INIT_WORK(&psy->changed_work, power_supply_changed_work);
 	rc = power_supply_create_attrs(psy);

--

1.5.5.1
--

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_drvdata().
Cc: Kay Sievers <kay.sievers@vrfy.org>

Cc: Richard Purdie <rpurdie@rpsys.net>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/leds/led-class.c |    6 ++----

 1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c

index b3c54be..559a408 100644

--- a/drivers/leds/led-class.c

+++ b/drivers/leds/led-class.c

@@ -103,13 +103,11 @@ int led_classdev_register(struct device *parent, struct led_classdev *led_cdev)

 {

 	int rc;
-	led_cdev->dev = device_create(leds_class, parent, 0, "%s",

-					    led_cdev->name);

+	led_cdev->dev = device_create_drvdata(leds_class, parent, 0, led_cdev,

+					      "%s", led_cdev->name);

 	if (IS_ERR(led_cdev->dev))

 		return PTR_ERR(led_cdev->dev);
-	dev_set_drvdata(led_cdev->dev, led_cdev);

-

 	/* register the attributes */

 	rc = device_create_file(led_cdev->dev, &dev_attr_brightness);

 	if (rc)

--

1.5.5.1
--

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_drvdata().
Cc: Kay Sievers <kay.sievers@vrfy.org>

Reviewed-by: Roland Dreier <rolandd@cisco.com>

Cc: Sean Hefty <sean.hefty@intel.com>

Cc: Hal Rosenstock <hal.rosenstock@gmail.com>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/infiniband/core/user_mad.c    |   14 ++++++--------

 drivers/infiniband/core/uverbs_main.c |   11 ++++++-----

 2 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/infiniband/core/user_mad.c b/drivers/infiniband/core/user_mad.c

index 3aa2db5..840ede9 100644

--- a/drivers/infiniband/core/user_mad.c

+++ b/drivers/infiniband/core/user_mad.c

@@ -1005,8 +1005,9 @@ static int ib_umad_init_port(struct ib_device *device, int port_num,

 	if (cdev_add(port->cdev, base_dev + port->dev_num, 1))

 		goto err_cdev;
-	port->dev = device_create(umad_class, device->dma_device,

-				  port->cdev->dev, "umad%d", port->dev_num);

+	port->dev = device_create_drvdata(umad_class, device->dma_device,

+					  port->cdev->dev, port,

+					  "umad%d", port->dev_num);

 	if (IS_ERR(port->dev))

 		goto err_cdev;
@@ -1024,15 +1025,12 @@ static int ib_umad_init_port(struct ib_device *device, int port_num,

 	if (cdev_add(port->sm_cdev, base_dev + port->dev_num + IB_UMAD_MAX_PORTS, 1))

 		goto err_sm_cdev;
-	port->sm_dev = device_create(umad_class, device->dma_device,

-				     port->sm_cdev->dev,

-				     "issm%d", port->dev_num);

+	port->sm_dev = device_create_drvdata(umad_class, device->dma_device,

+					     port->sm_cdev->dev, port,

+					     "issm%d", port->dev_num);

 	if (IS_ERR(port->sm_dev))

 		goto err_sm_cdev;
-...
[ message continues ]

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_drvdata().
Cc: Kay Sievers <kay.sievers@vrfy.org>

Cc: James Simmons <jsimmons@infradead.org>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/video/display/display-sysfs.c |   10 +++++++---

 1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/video/display/display-sysfs.c b/drivers/video/display/display-sysfs.c

index 3547717..6ef800b 100644

--- a/drivers/video/display/display-sysfs.c

+++ b/drivers/video/display/display-sysfs.c

@@ -26,6 +26,7 @@

 #include <linux/ctype.h>

 #include <linux/idr.h>

 #include <linux/err.h>

+#include <linux/kdev_t.h>
 static ssize_t display_show_name(struct device *dev,

 				struct device_attribute *attr, char *buf)

@@ -152,10 +153,13 @@ struct display_device *display_device_register(struct display_driver *driver,

 		mutex_unlock(&allocated_dsp_lock);
 		if (!ret) {

-			new_dev->dev = device_create(display_class, parent, 0,

-						"display%d", new_dev->idx);

+			new_dev->dev = device_create_drvdata(display_class,

+							     parent,

+							     MKDEV(0,0),

+							     new_dev,

+							     "display%d",

+							     new_dev->idx);

 			if (!IS_ERR(new_dev->dev)) {

-				dev_set_drvdata(new_dev->dev, new_dev);

 				new_dev->parent = parent;

 				new_dev->driver = driver;

 				mutex_init(&new_dev->lock);

--

1.5.5.1
--

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_drvdata().
Cc: Kay Sievers <kay.sievers@vrfy.org>

Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/ide/ide-probe.c |    5 ++---

 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c

index 34b0d4f..655ec7e 100644

--- a/drivers/ide/ide-probe.c

+++ b/drivers/ide/ide-probe.c

@@ -648,13 +648,12 @@ static int ide_register_port(ide_hwif_t *hwif)
 	get_device(&hwif->gendev);
-	hwif->portdev = device_create(ide_port_class, &hwif->gendev,

-				      MKDEV(0, 0), hwif->name);

+	hwif->portdev = device_create_drvdata(ide_port_class, &hwif->gendev,

+					      MKDEV(0, 0), hwif, hwif->name);

 	if (IS_ERR(hwif->portdev)) {

 		ret = PTR_ERR(hwif->portdev);

 		device_unregister(&hwif->gendev);

 	}

-	dev_set_drvdata(hwif->portdev, hwif);

 out:

 	return ret;

 }

--

1.5.5.1
--

There is a race from when a device is created with device_create() and

then the drvdata is set with a call to dev_set_drvdata() in which a

sysfs file could be open, yet the drvdata will be NULL, causing all

sorts of bad things to happen.
This patch fixes the problem by using the new function,

device_create_vargs().
Many thanks to Arthur Jones <ajones@riverbed.com> for reporting the bug,

and testing patches out.
Cc: Kay Sievers <kay.sievers@vrfy.org>

Cc: Arthur Jones <ajones@riverbed.com>

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>

Cc: Miklos Szeredi <mszeredi@suse.cz>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 mm/backing-dev.c |   12 ++----------

 1 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/mm/backing-dev.c b/mm/backing-dev.c

index 7c4f9e0..f2e574d 100644

--- a/mm/backing-dev.c

+++ b/mm/backing-dev.c

@@ -172,30 +172,22 @@ postcore_initcall(bdi_class_init);

 int bdi_register(struct backing_dev_info *bdi, struct device *parent,

 		const char *fmt, ...)

 {

-	char *name;

 	va_list args;

 	int ret = 0;

 	struct device *dev;
 	va_start(args, fmt);

-	name = kvasprintf(GFP_KERNEL, fmt, args);

+	dev = device_create_vargs(bdi_class, parent, MKDEV(0, 0), bdi, fmt, args);

 	va_end(args);

-

-	if (!name)

-		return -ENOMEM;

-

-	dev = device_create(bdi_class, parent, MKDEV(0, 0), name);

 	if (IS_ERR(dev)) {

 		ret = PTR_ERR(dev);

 		goto exit;

 	}
 	bdi->dev = dev;

-	dev_set_drvdata(bdi->dev, bdi);

-	bdi_debug_register(bdi, name);

+	bdi_debug_register(bdi, dev_name(dev));
 exit:

-	kfree(name);

 	return ret;

 }

 EXPORT_SYMBOL(bdi_register);

--

1.5.5.1
--

We want to have the drvdata field set properly when creating the device

as sysfs callbacks can assume it is present and it can race the later

setting of this field.
So, create two new functions, deviec_create_vargs() and

device_create_drvdata() that take this new field.
device_create_drvdata() will go away in 2.6.27 as the drvdata field will

just be moved to the device_create() call as it should be.
Cc: Kay Sievers <kay.sievers@vrfy.org>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---

 drivers/base/core.c    |   85 ++++++++++++++++++++++++++++++++++++++++++++---

 include/linux/device.h |   12 +++++++

 2 files changed, 91 insertions(+), 6 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c

index be288b5..f861c2b 100644

--- a/drivers/base/core.c

+++ b/drivers/base/core.c

@@ -1084,11 +1084,13 @@ static void device_create_release(struct device *dev)

 }
 /**

- * device_create - creates a device and registers it with sysfs

+ * device_create_vargs - creates a device and registers it with sysfs

  * @class: pointer to the struct class that this device should be registered to

  * @parent: pointer to the parent struct device of this new device, if any

  * @devt: the dev_t for the char device to be added

+ * @drvdata: the data to be added to the device for callbacks

  * @fmt: string for the device's name

+ * @args: va_list for the device's name

  *

  * This function can be used by char device classes.  A struct device

  * will be created in sysfs, registered to the specified class.

@@ -1104,10 +1106,10 @@ static void device_create_release(struct device *dev)

  * Note: the struct class passed to this function must have previously

  * been created with a call to class_create().

  */

-struct device *device_create(struct class *class, struct device *parent,

-			     dev_t devt, const char *fmt, ...)

+struct device *device_create_vargs(struct class *class, struct device *parent,

+				   dev_t devt, void *drvdata, const char *fmt,

+				   va_list ...
[ message continues ]