Re: [PATCH 2/4] pktgen: make sure that pktgen_thread_worker has been executed

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: <den@...>

Cc: <akpm@...>, <netdev@...>, <linux-kernel@...>, <kaber@...>, <robert.olsson@...>, <greearb@...>

Subject: Re: [PATCH 2/4] pktgen: make sure that pktgen_thread_worker has been executed

Date: Tuesday, May 20, 2008 - 6:12 pm

From: "Denis V. Lunev" <den@openvz.org>
Date: Tue, 20 May 2008 13:59:47 +0400

quoted text> The following courruption can happen during pktgen stop:
> list_del corruption. prev->next should be ffff81007e8a5e70, but was 6b6b6b6b6b6b6b6b
> kernel BUG at lib/list_debug.c:67!
>       :pktgen:pktgen_thread_worker+0x374/0x10b0
>       ? autoremove_wake_function+0x0/0x40
>       ? _spin_unlock_irqrestore+0x42/0x80
>       ? :pktgen:pktgen_thread_worker+0x0/0x10b0
>       kthread+0x4d/0x80
>       child_rip+0xa/0x12
>       ? restore_args+0x0/0x30
>       ? kthread+0x0/0x80
>       ? child_rip+0x0/0x12
> RIP  list_del+0x48/0x70
> 
> The problem is that pktgen_thread_worker can not be executed if kthread_stop
> has been called too early. Insert a completion on the normal initialization
> path to make sure that pktgen_thread_worker will gain the control for sure.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Cc: Patrick McHardy <kaber@trash.net>
> Cc: Robert Olsson <robert.olsson@its.uu.se>
> Cc: Ben Greear <greearb@candelatech.com>
> Acked-by: Alexey Dobriyan <adobriyan@openvz.org>

Patch applied, thanks a lot Denis!
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/4] proc: proc_get_inode should get module only once, Denis V. Lunev, (Tue May 20, 5:59 am)

[PATCH 4/4] flock: remove unused fields from file_lock_opera..., Denis V. Lunev, (Tue May 20, 5:59 am)

[PATCH 3/4] modules: proper cleanup of kobject without CONFI..., Denis V. Lunev, (Tue May 20, 5:59 am)

Re: [PATCH 3/4] modules: proper cleanup of kobject without C..., Rusty Russell, (Thu May 22, 5:20 am)

Re: [PATCH 3/4] modules: proper cleanup of kobject without C..., Greg KH, (Thu May 22, 1:54 pm)

Re: [PATCH 3/4] modules: proper cleanup of kobject without C..., Rusty Russell, (Thu May 22, 9:34 pm)

Re: [PATCH 3/4] modules: proper cleanup of kobject without C..., Denis V. Lunev, (Thu May 22, 7:44 am)

Re: [PATCH 3/4] modules: proper cleanup of kobject without C..., Rusty Russell, (Thu May 22, 9:51 pm)

[PATCH 2/4] pktgen: make sure that pktgen_thread_worker has ..., Denis V. Lunev, (Tue May 20, 5:59 am)

Re: [PATCH 2/4] pktgen: make sure that pktgen_thread_worker ..., David Miller, (Tue May 20, 6:12 pm)

[PATCH 2/4] pktgen: make sure that pktgen_thread_worker has ..., Robert Olsson, (Tue May 20, 2:30 pm)

Re: [PATCH 2/4] pktgen: make sure that pktgen_thread_worker ..., Denis V. Lunev, (Tue May 20, 2:43 pm)

Re: [PATCH 2/4] pktgen: make sure that pktgen_thread_worker ..., Robert Olsson, (Tue May 20, 3:59 pm)


linux-kernel:
debian developer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Linus Torvalds	Re: Slow DOWN, please!!!
Tony Lindgren	[PATCH 37/90] ARM: OMAP: MPUIO wake updates
git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Alexey Dobriyan	Re: [GIT]: Networking
Dushan Tcholich	Re: ksoftirqd high cpu load on kernels 2.6.24 to 2.6.27-rc1-mm1
openbsd-misc:

Re: [PATCH 2/4] pktgen: make sure that pktgen_thread_worker has been executed

Online users