Re: [PATCH 1/3][-mm] add class_reclassify macro

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Dave Young <hidave.darkstar@...>, <matthew@...>, <kay.sievers@...>, <linux-kernel@...>, <linux-scsi@...>
Date: Tuesday, May 20, 2008 - 1:21 pm

On Tue, May 20, 2008 at 03:02:32AM -0700, Andrew Morton wrote:

Um, no, that's a "feature" that some types of hardware and interfaces
require.

This is one reason I really don't like this type of conversion, it's
causing lots of problems for no known gain.

So I would just recommend dropping this patch set, the current "convert
class semaphore to a mutex" patch in the -mm tree is already causing
lockdep warnings, and trying to do something like this isn't really
going to solve the root problem here.

thanks,

greg k-h
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/3][-mm] add class_reclassify macro, Dave Young, (Tue May 20, 5:55 am)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Andrew Morton, (Tue May 20, 6:02 am)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Greg KH, (Tue May 20, 1:21 pm)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Dave Young, (Tue May 27, 2:42 am)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Andrew Morton, (Tue May 27, 2:59 am)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Matthew Wilcox, (Wed May 28, 11:48 am)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Greg KH, (Wed May 28, 12:06 pm)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Greg KH, (Wed May 28, 12:28 pm)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Dave Young, (Tue May 27, 3:31 am)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Matthew Wilcox, (Tue May 20, 7:36 am)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Dave Young, (Tue May 20, 7:05 am)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Andrew Morton, (Tue May 20, 1:30 pm)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Matthew Wilcox, (Tue May 20, 1:36 pm)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Andrew Morton, (Tue May 20, 3:23 pm)
Re: [PATCH 1/3][-mm] add class_reclassify macro, Dave Young, (Tue May 20, 10:05 pm)