Home » Mailing list archives » linux-kernel » 2008 » May » 20

Re: [PATCH] [2/11] Add unlocked_fasync

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jonathan Corbet <corbet@...>
To: Andi Kleen <andi@...>
Cc: <linux-kernel@...>
Subject: Re: [PATCH] [2/11] Add unlocked_fasync
Date: Tuesday, May 20, 2008 - 11:58 am

I guess my one concern with this mirrors what other people have said:
might not it be better to just push the BKL down into the fasync()
implementations and avoid adding yet another file operation?  A quick
grep shows 43 drivers defining fasync() functions - and many of those
use the same one.  fs/ has a few more.  Obnoxious but doable, unless
there's something I'm missing?

Thanks,

jon
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [0/11] REPOST: Early exception fixes, Andi Kleen, (Tue May 20, 11:28 am)
[PATCH] [10/11] Use unlocked_fasync in RTC, Andi Kleen, (Tue May 20, 11:28 am)
[PATCH] [5/11] Convert fuse to unlocked_fasync, Andi Kleen, (Tue May 20, 11:28 am)
[PATCH] [8/11] Use unlocked_fasync in random.c, Andi Kleen, (Tue May 20, 11:28 am)
[PATCH] [4/11] Convert socket fasync to unlocked_fasync, Andi Kleen, (Tue May 20, 11:28 am)
[PATCH] [6/11] Convert bad_inode to unlocked_fasync, Andi Kleen, (Tue May 20, 11:28 am)
[PATCH] [2/11] Add unlocked_fasync, Andi Kleen, (Tue May 20, 11:28 am)
Re: [PATCH] [2/11] Add unlocked_fasync, Randy Dunlap, (Tue May 20, 11:58 am)
Re: [PATCH] [2/11] Add unlocked_fasync , Jonathan Corbet, (Tue May 20, 11:58 am)
Re: [PATCH] [2/11] Add unlocked_fasync, Andi Kleen, (Tue May 20, 2:31 pm)
Re: [PATCH] [2/11] Add unlocked_fasync, Arjan van de Ven, (Tue May 20, 11:58 am)
Re: [PATCH] [2/11] Add unlocked_fasync, Alan Cox, (Tue May 20, 2:33 pm)
Re: [PATCH] [2/11] Add unlocked_fasync, Andi Kleen, (Tue May 20, 2:59 pm)
Re: [PATCH] [2/11] Add unlocked_fasync, Andi Kleen, (Tue May 20, 2:30 pm)
Re: [PATCH] [2/11] Add unlocked_fasync, Arjan van de Ven, (Tue May 20, 4:06 pm)
Re: [PATCH] [2/11] Add unlocked_fasync, Andi Kleen, (Tue May 20, 7:35 pm)
Re: [PATCH] [2/11] Add unlocked_fasync, Arjan van de Ven, (Wed May 21, 12:47 am)
[PATCH] [3/11] Convert pipe over to unlocked_fasync, Andi Kleen, (Tue May 20, 11:28 am)
[PATCH] [11/11] Convert uio to fasync_unlocked, Andi Kleen, (Tue May 20, 11:28 am)
[PATCH] [9/11] Convert hpet to unlocked_fasync, Andi Kleen, (Tue May 20, 11:28 am)
Re: [PATCH] [9/11] Convert hpet to unlocked_fasync, Clemens Ladisch, (Wed May 21, 5:01 am)
[PATCH] [7/11] Convert DRM to unlocked_fasync, Andi Kleen, (Tue May 20, 11:28 am)
Re: [PATCH] [7/11] Convert DRM to unlocked_fasync, Dave Airlie, (Wed May 21, 2:36 am)
[PATCH] [1/11] Remove BKL from remote_llseek v2, Andi Kleen, (Tue May 20, 11:28 am)