Re: [PATCH] x86: Get irq for hpet timer

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Kevin Hao <kexin.hao@...>
Cc: Clemens Ladisch <clemens@...>, <venkatesh.pallipadi@...>, <bob.picco@...>, <mingo@...>, <tglx@...>, <linux-kernel@...>
Date: Tuesday, May 20, 2008 - 11:46 am

On Tue, 20 May 2008, Kevin Hao wrote:


 Hmm, you probably want to skip all lines that are edge-triggered.  
Otherwise you may have problems with sharing.  Drivers for devices used
with these edge-triggered lines may have special provisions to permit
sharing in a crafted way in special arrangements (cf. the 8250 serial or
the IDE driver), but that may not work in a generic way with a different
driver in the scenario.  And the polarity may be wrong too --
edge-triggered lines are often active-high, because it's fine with them.

 This driver is quite platform-specific -- how about instead of blindly
probing for interrupt lines, you actually allocate one somehow in platform
code?  For example the x86 platform could select an otherwise unused
interrupt line for you -- having routed all the legacy and PCI devices,
these systems quite frequently are left with a couple of otherwise unused
I/O APIC inputs.  If not, sharing with a PCI interrupt line would be a
good choice.  AFAIK, except from 8254 and RTC emulation the HPET cannot be
used with the legacy 8259A interrupt controllers, so that is a non issue
(but platform will know to disable your driver then).

  Maciej
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] x86: Get irq for hpet timer, Kevin Hao, (Fri May 16, 2:05 am)
Re: [PATCH] x86: Get irq for hpet timer, Clemens Ladisch, (Fri May 16, 4:46 am)
Re: [PATCH] x86: Get irq for hpet timer, Kevin Hao, (Fri May 16, 5:14 am)
Re: [PATCH] x86: Get irq for hpet timer, Clemens Ladisch, (Mon May 19, 12:10 pm)
Re: [PATCH] x86: Get irq for hpet timer, Kevin Hao, (Tue May 20, 5:03 am)
Re: [PATCH] x86: Get irq for hpet timer, Maciej W. Rozycki, (Tue May 20, 11:46 am)
Re: [PATCH] x86: Get irq for hpet timer, Clemens Ladisch, (Wed May 21, 4:28 am)
Re: [PATCH] x86: Get irq for hpet timer, Maciej W. Rozycki, (Wed May 21, 11:47 pm)
Re: [PATCH] x86: Get irq for hpet timer, Kevin Hao, (Thu May 22, 3:27 am)
Re: [PATCH] x86: Get irq for hpet timer, Maciej W. Rozycki, (Thu May 22, 11:25 am)
Re: [PATCH] x86: Get irq for hpet timer, Kevin Hao, (Wed May 28, 6:42 am)
Re: [PATCH] x86: Get irq for hpet timer, Maciej W. Rozycki, (Wed May 28, 11:13 pm)
Re: [PATCH] x86: Get irq for hpet timer, Kevin Hao, (Thu May 29, 6:41 am)
Re: [PATCH] x86: Get irq for hpet timer, Maciej W. Rozycki, (Thu May 29, 10:32 am)
Re: [PATCH] x86: Get irq for hpet timer, Kevin Hao, (Fri May 30, 1:32 am)
Re: [PATCH] x86: Get irq for hpet timer, Ingo Molnar, (Mon Jun 2, 5:35 am)
Re: [PATCH] x86: Get irq for hpet timer, Maciej W. Rozycki, (Mon May 19, 5:21 pm)
Re: [PATCH] x86: Get irq for hpet timer, Balaji Rao R, (Fri May 16, 3:53 am)
Re: [PATCH] x86: Get irq for hpet timer, Kevin Hao, (Fri May 16, 4:03 am)
Re: [PATCH] x86: Get irq for hpet timer, Balaji Rao, (Fri May 16, 4:30 am)