login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
20
Re: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Jan-Bernd Themann
Subject:
Re: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc
Date: Tuesday, May 20, 2008 - 6:53 am
On Monday 12 May 2008 23:38, Joe Perches wrote:
quoted text
> Signed-off-by: Joe Perches <joe@perches.com> > > --- > > drivers/net/ehea/ehea_main.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c > index f9bc21c..fd4be0d 100644 > --- a/drivers/net/ehea/ehea_main.c > +++ b/drivers/net/ehea/ehea_main.c > @@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev, > port->vgrp = grp; > > cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL); > if (!cb1) { > ehea_error("no mem for cb1"); > goto out; > } > > - memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter)); > - > hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id, > H_PORT_CB1, H_PORT_CB1_ALL, cb1); > if (hret != H_SUCCESS) > ehea_error("modify_ehea_port failed"); > > kfree(cb1); > out: > return; >
The patch looks good. Acked-by: Jan-Bernd Themann <themann@de.ibm.com> Thanks, Jan-Bernd --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset
, Christophe Jaillet
, (Mon May 12, 2:35 pm)
[PATCH] drivers/net/ehea - remove unnecessary memset after ...
, Joe Perches
, (Mon May 12, 2:38 pm)
RE: [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset
, Faisal Latif
, (Tue May 13, 2:46 pm)
Re: [ofa-general] RE: [PATCH 1/1] infiniband/hw/nes/: avoi ...
, Roland Dreier
, (Wed May 14, 9:36 am)
Re: [PATCH] drivers/net/ehea - remove unnecessary memset a ...
, Jan-Bernd Themann
, (Tue May 20, 6:53 am)
Re: [PATCH] drivers/net/ehea - remove unnecessary memset a ...
, Jeff Garzik
, (Thu May 22, 3:22 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Dave Jones
Re: OT: character encodings (was: Linux 2.6.20-rc4)
Greg Kroah-Hartman
[PATCH 17/36] sysdev: detect multiple driver registrations
Sam Ravnborg
Re: [PATCH] kbuild: fix make V=1
Nick Piggin
Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
Greg Kroah-Hartman
[PATCH 16/36] driver core: cpu: fix section mismatch in cpu.c:store_online
git
:
Stephen R. van den Berg
Re: [RFC] origin link for cherry-pick and revert
Junio C Hamano
Re: [PATCH 1/2] Teach git-describe to display distances from tags.
Johannes Schindelin
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on
fantasy1215
Will tortoisesvn conflict with tortoisegit?
Junio C Hamano
Re: [PATCH 6/6] Teach core object handling functions about gitlinks
linux-netdev
:
Jarek Poplawski
Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event...
Lennert Buytenhek
Re: Distributed Switch Architecture(DSA)
Daniel Schaffrath
Re: tcp bw in 2.6
Guo-Fu Tseng
Re: jme: UDP checksum error, and lots of them
Gerrit Renker
[PATCH 37/37] dccp: Debugging functions for feature negotiation
openbsd-misc
:
Claudio Jeker
Re: Vlan Tag on Vlan Tag (l2tunneling)
Josh Grosse
ssh/sshd challenge-response seems to have stopped working in -current
Pieter Verberne
File collision while using pkg_add
Tomas Bodzar
bsd: uvm_mapent_alloc: out of static map entries
Community First Financial
Teacher A+ Loan
git-commits-head
:
Linux Kernel Mailing List
ath9k: Added get_survey callback in order to get channel noise
Linux Kernel Mailing List
tracing: protect reader of cmdline output
Linux Kernel Mailing List
kconfig: recalc symbol value before showing search results
Linux Kernel Mailing List
[ARM] 5185/1: Fix spi num_chipselect for lubbock
Linux Kernel Mailing List
swsusp: provide users with a hint about the no_console_suspend option
Colocation donated by:
Syndicate