linux-kernel mailing list

FromSubjectsort iconDate
Balaji Rao
Re: [RFC][-mm] Simple stats for cpu resource controller v3
On Saturday 03 May 2008 05:11:33 am Andrew Morton wrote: oh! am sorry about that! some cosmetic changes remain. It also contains some modifications done to the percpu_counter core. OK, so when does account_system_time get called for the first time ? after IRQs are set up, is it ? So, where do we place the hook ? Here's the patch. diff --git a/include/linux/percpu_counter.h b/include/linux/percpu_counter.h index 9007ccd..8a1b756 100644 --- a/include/linux/percpu_counter.h +++ b/include/lin...
May 2, 7:56 pm 2008
Hiroshi Shimamoto
[PATCH] x86_32: move do_nmi() to nmi_32.c
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> on x86_64 do_nmi() is in nmi_64.c. Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> --- arch/x86/kernel/nmi_32.c | 30 ++++++++++++++++++++++++++++++ arch/x86/kernel/traps_32.c | 32 +------------------------------- include/asm-x86/nmi.h | 3 ++- 3 files changed, 33 insertions(+), 32 deletions(-) diff --git a/arch/x86/kernel/nmi_32.c b/arch/x86/kernel/nmi_32.c index 69bdae5..641d2d9 100644 --- a/arch/x...
May 2, 7:45 pm 2008
Hiroshi Shimamoto
[PATCH] x86_32: use per_cpu data
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> use per_cpu for per CPU data. Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> --- arch/x86/kernel/nmi_32.c | 29 +++++++++++++++++------------ 1 files changed, 17 insertions(+), 12 deletions(-) diff --git a/arch/x86/kernel/nmi_32.c b/arch/x86/kernel/nmi_32.c index 11b14bb..69bdae5 100644 --- a/arch/x86/kernel/nmi_32.c +++ b/arch/x86/kernel/nmi_32.c @@ -293,9 +293,9 @@ void stop_apic_nmi_watchdog(void *unused) ...
May 2, 7:45 pm 2008
Hiroshi Shimamoto
[PATCH] x86_64: nmi and irq counters are unsigned
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> __nmi_count, apic_timer_irqs and irq0_irqs are unsigned. Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> --- arch/x86/kernel/nmi_64.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/nmi_64.c b/arch/x86/kernel/nmi_64.c index 5a29ded..33cb8ec 100644 --- a/arch/x86/kernel/nmi_64.c +++ b/arch/x86/kernel/nmi_64.c @@ -79,7 +79,7 @@ static __init void nmi_cpu_busy(void *data) ...
May 2, 7:44 pm 2008
Moore, Eric
HELP: Is writeq an atomic operation??
Is a 64bit write to MMIO registers an atomic operation when using the writeq API? My concern is when I send 64bit data via writeq, will it be sent out as two 32 bit writes? If so, is it possible that another CPU be sending the data at the same time. Meaning can I write the 1st 32bit data from CPU-A, meanwhile CPU-B is writing his 32bit data at the same time, and CPU-A didn't complete the full 64bit in one shot. If this could occur, is there an API that I can use to make sure the entire data se...
May 2, 6:40 pm 2008
Jesse Barnes
Re: HELP: Is writeq an atomic operation??
I think this is normal; PCIe defines transactions in terms of dwords, to a 64 bit write would indeed be a transaction packet with a length of two (it can go up to 4k). AFAIK though transactions are processed as a whole, so even a 4k write (as long as it's generated as a single transaction) won't result in the device seeing e.g. 2x2k writes. I'd have to double check the routing rules to be 100% sure though, maybe in some cases the fabric is allowed to break up transactions (?). Jesse -- ...
May 2, 7:12 pm 2008
Roland Dreier
Re: HELP: Is writeq an atomic operation??
> Here is a trace from pci express analyzer. I'm sending > 0x0800010000000000 to the adress DD1400C0 using writeq. Notice that in > the TLP header it sent a 32bit Memory write with data length of two. By the way, are you worried that there is something wrong with this trace? Your write went out in a single PCIe packet, so it looks perfect to me. Does the "Mem MWr(32)" worry you? I can't see why it would be a problem -- the PCIe TLP only has one type of memory write transaction (w...
May 2, 7:04 pm 2008
Moore, Eric
RE: HELP: Is writeq an atomic operation??
The concern was raised in a code review we had earlier; it sounds like we are good. Under platforms where writeq is not defined, what should I do? --
May 2, 7:20 pm 2008
Andi Kleen
Re: HELP: Is writeq an atomic operation??
With what CPU/chipset was that? -Andi --
May 2, 6:50 pm 2008
Moore, Eric
RE: HELP: Is writeq an atomic operation??
I'm developing sas driver for next generation controllers. They should work at least on x86, x86_64, ia64, and ppc64. The host I was using for gathering that trace was x86_64 Intel Platform. Here is the lspci output: 00:00.0 Host bridge: Intel Corporation E7520 Memory Controller Hub (rev 0c) Subsystem: Super Micro Computer Inc Unknown device 5480 Flags: bus master, fast devsel, latency 0 Capabilities: [40] Vendor Specific Information 00:00.1 Class ff00: Intel Corporation E7525/E7520 Er...
May 2, 7:03 pm 2008
Andi Kleen
Re: HELP: Is writeq an atomic operation??
I doubt the CPU was to blame. Probably the chipset split it up for some reason. Did you check the data sheets? At the CPU level writeq is simply a 64bit store on x86-64 Linux. -Andi --
May 2, 7:13 pm 2008
Roland Dreier
Re: HELP: Is writeq an atomic operation??
> Is a 64bit write to MMIO registers an atomic operation when using the > writeq API? > > My concern is when I send 64bit data via writeq, will it be sent out as > two 32 bit writes? If so, is it possible that another CPU be sending > the data at the same time. Meaning can I write the 1st 32bit data from > CPU-A, meanwhile CPU-B is writing his 32bit data at the same time, and > CPU-A didn't complete the full 64bit in one shot. If this could occur, > is there...
May 2, 6:46 pm 2008
David Miller
Re: HELP: Is writeq an atomic operation??
From: "Moore, Eric" <Eric.Moore@lsi.com> The answer to this question this is platform dependent. On most 64-bit platforms, it is. On some 32-bit ones, it is not. This is not a SCSI layer question, so belongs minimally on linux-kernel which I've CC:'d. --
May 2, 6:32 pm 2008
Roland Dreier
Re: HELP: Is writeq an atomic operation??
> > Is a 64bit write to MMIO registers an atomic operation when using the > > writeq API? > > The answer to this question this is platform dependent. > > On most 64-bit platforms, it is. On some 32-bit ones, it is not. Are there any 32-bit platforms with writeq()? A quick grep suggests not. Are there any 64-bit platforms where writeq() allows the MMIO to be split into multiple cycles from the target device's view? I've been coding assuming that at least no o...
May 2, 6:43 pm 2008
Moore, Eric
RE: HELP: Is writeq an atomic operation??
I hope that is the case. --
May 2, 6:49 pm 2008
Roland Dreier
Re: HELP: Is writeq an atomic operation??
> > Are there any 32-bit platforms with writeq()? A quick grep > > suggests not. > > I think writeq defined in include/asm-x86/io_64.h Umm... io_64.h is 64-bit only (look at asm-x86/io.h if you don't believe me ;) - R. --
May 2, 6:53 pm 2008
Moore, Eric
RE: HELP: Is writeq an atomic operation??
Yeah, I forgot I have a #ifndef writeq, then defined the x86_64 version of that. I've not tested on x86, so I'm not sure whether it works. How are you handling writeq when its not defined, as the case in x86? Eric --
May 2, 7:13 pm 2008
Roland Dreier
Re: HELP: Is writeq an atomic operation??
> Yeah, I forgot I have a #ifndef writeq, then defined the x86_64 version > of that. I've not tested on x86, so I'm not sure whether it works. > How are you handling writeq when its not defined, as the case in x86? Write two writel() inside a spinlock to avoid any transactions in the middle (the HW I'm dealing with can deal with two 32-bit transactions, as long as nothing comes in the middle). If your hardware demands a single 64-bit transaction, you may be in trouble, because I'm no...
May 2, 7:21 pm 2008
Moore, Eric
RE: HELP: Is writeq an atomic operation??
Thanks for the code sample. Yes, I need to send a single atomic 64-bit transaction. Eric --
May 2, 7:31 pm 2008
David Miller
Re: HELP: Is writeq an atomic operation??
From: Roland Dreier <rdreier@cisco.com> Right, I guess there aren't, but what drivers do currently is roll their own 64-bit MMIO for such cases. I noticed this when writing drivers/net/niu.c I suppose this is on purpose, so the driver can setup any such protection and handling, as needed. --
May 2, 6:49 pm 2008
Fenghua Yu
[PATCH] Handle invalid ACPI SLIT table
This is a SLIT sanity checking patch. It moves slit_valid() function to generic ACPI code and does sanity checking for both x86 and ia64. It sets up node_distance with LOCAL_DISTANCE and REMOTE_DISTANCE when hitting invalid SLIT table on ia64. It also cleans up unused variable localities in acpi_parse_slit() on x86. Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> --- arch/ia64/kernel/acpi.c | 9 +++++++-- arch/x86/mm/srat_64.c | 27 --------------------------- drivers/acpi/n...
May 2, 6:26 pm 2008
Andrew Morton
git trees which are not yet in linux-next
git-cifs: git+ssh://master.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6.git git-gfs2-nmw: git+ssh://master.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-2.6-nmw.git git-ieee1394: git+ssh://master.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git#for-mm git-jg-misc: git+ssh://master.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git#irq-remove git-libata-all: git+ssh://master.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-2.6.git git-mips: git://git.linux-mips...
May 2, 6:12 pm 2008
Andrew Morton
Re: git trees which are not yet in linux-next
On Fri, 2 May 2008 15:12:06 -0700 doh. I'm pulling linux-next's constituent trees independently, so if I spot a turd in linux-next I can just grep the various git trees to find out where it came from. It seems wrong though... --
May 2, 6:42 pm 2008
Jeff Garzik
Re: git trees which are not yet in linux-next
libata-dev.git#NEXT is for linux-next, and libata-dev.git#ALL is for -mm Already taken care of. Jeff --
May 2, 6:20 pm 2008
Andrew Morton
Re: git trees which are not yet in linux-next
On Fri, 02 May 2008 18:20:26 -0400 Oh. Something seems to have gone wrong then. Next/Trees has: libata git git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git#NEXT but: y:/usr/src/25> diffstat patches/linux-next.patch | grep /ata/ y:/usr/src/25> There's nothing there? (plans for git-jg-misc?) --
May 2, 6:33 pm 2008
Dan Williams
[PATCH] md: fix raid5 'repair' operations
commit bd2ab67030e9116f1e4aae1289220255412b37fd "md: close a livelock window in handle_parity_checks5" introduced a bug in handling 'repair' operations. After a repair operation completes we clear the state bits tracking this operation. However, they are cleared too early and this results in the code deciding to re-run the parity check operation. Since we have done the repair in memory the second check does not find a mismatch and thus does not do a writeback. Test results: $ echo repair > /...
May 2, 5:27 pm 2008
Sam Ravnborg
kconfig frontend updates
The following patchset implments the following: o Inputfiles to all*config can be specified with K= o less chatty oldconfig mode o Drop useless warnings This is work-in-progress aimed for next mergewindow. Posted here mainly to get some feedback and a bit of review. Patches follows to lkml + kbuild lists Sam --
May 2, 4:47 pm 2008
Sam Ravnborg
Re: kconfig frontend updates
git added a bad email address in cc: Just ignore the error or edit away the "sam@uranus.ravnborg.org" address. git config is fixed so it should not happen again. Sam --
May 2, 5:01 pm 2008
sam
[PATCH] kconfig: add support for K=file
From: Sam Ravnborg <sam@uranus.ravnborg.org> Input file to all*config, randconfig and defconfig can be specified using the environment variable 'K'. It is expected to be used like this: make K=my_config alldefconfig This replaces the KCONFIL_ALLCONFIG support and the input files named: all*.config Signed-off-by: Sam Ravnborg <sam@ravnborg.org> --- scripts/kconfig/Makefile | 31 ++--- scripts/kconfig/aconf.c | 316 ++++++++++++++++++++++++++++++++++++++++++++++ scripts/kco...
May 2, 4:49 pm 2008
sam
[PATCH] kconfig: drop all*config support in conf.c
From: Sam Ravnborg <sam@uranus.ravnborg.org> With the introduction of aconf we can now kill all the old all*config support code in conf.c Modified Makefile so defconfig is now handled by aconf always. This removed the feature that kconfig could look up a default configuration in one of the files listed in DEFCONFIG_LIST. But this was only used by archs that did not define KBUILD_DEFCONFIG so no harm done. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> --- scripts/kconfig/Makefil...
May 2, 4:49 pm 2008
sam
[PATCH] kconfig: conf is less chatty
From: Sam Ravnborg <sam@uranus.ravnborg.org> No one really used the output generated during a oldconfig run. So drop it and behave like the old 'silentoldconfig' always did. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> --- Makefile | 2 +- scripts/kconfig/Makefile | 5 +---- scripts/kconfig/conf.c | 42 ++++++++++++++---------------------------- 3 files changed, 16 insertions(+), 33 deletions(-) diff --git a/Makefile b/Makefile index d3634cd..99fcf12...
May 2, 4:49 pm 2008
sam
[PATCH] kconfig: .gitignore aconf
From: Sam Ravnborg <sam@uranus.ravnborg.org> --- scripts/kconfig/.gitignore | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/scripts/kconfig/.gitignore b/scripts/kconfig/.gitignore index b49584c..ae664f9 100644 --- a/scripts/kconfig/.gitignore +++ b/scripts/kconfig/.gitignore @@ -13,6 +13,7 @@ lkc_defs.h # configuration programs # conf +aconf mconf qconf gconf -- 1.5.4.1.143.ge7e51 --
May 2, 4:49 pm 2008
sam
[PATCH] kconfig: kill the warning "trying to assign nonexist...
From: Sam Ravnborg <sam@uranus.ravnborg.org> The warning is only annoying and not used. So drop it. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> --- scripts/kconfig/confdata.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index ee5fe94..ea44754 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -222,10 +222,8 @@ load: continue; if (def == S_DEF_USER) { ...
May 2, 4:49 pm 2008
Frans Pop
[git head] Should X86_PAT really default to yes?
With X86_PAT enabled, when X is started I get about 40 lines (with varying addresses) like: kernel: Xorg:3358 /dev/mem expected mapping type write-back for 807bf000-81000000, got uncached-minus And when X exits I get a bunch of lines like: kernel: Xorg:3349 freeing invalid memtype 80020000-8002a000 I also noticed artifacts (a band of about 2 cm high across the screen) after X goes to black but before the switch to VT1. When I unset X86_PAT all this disappeared. Apparently this has been s...
May 2, 3:22 pm 2008
Pallipadi, Venkatesh
RE: [git head] Should X86_PAT really default to yes?
Copying the X-guys. The messages all look like debug messages from X and should not cause any side-effects other than little annoyance. I am not sure why band of 2 cm is there... Do you see any performance difference with or without PAT. Thanks, Venki --
May 2, 3:37 pm 2008
Jesse Barnes
Re: [git head] Should X86_PAT really default to yes?
These messages? They're coming from the kernel it looks like, from the map_devmem routine in pat.c. I'm not sure they're accurate though; for PCI regions /dev/mem is *supposed* to map with UC- and not WB, so maybe this This is just a transient issue during VT switch or server exit though, right? X functionality isn't affected, and your VTs work fine? If so, it might not be a PAT issue but just a different memory layout or something (and therefore it would really just be a cosmetic bug in...
May 2, 4:40 pm 2008
Pallipadi, Venkatesh
RE: [git head] Should X86_PAT really default to yes?
Indeed. I think these messages are due to X using the mprotect workaround to change UC_MINUS to WB. I don't see these error messages on my 965 here. May be I have different x version. What may be happening: 1) process A mmaps /dev/mem and gets UC_MINUS 2) Changes the page table to make pg_prot WB 3) Does a fork to create process B 4) While copying the vma, we go through map_devmem request WB, but get UC_MINUS back 5) We are not changing vma pg_prot to new value at this point (we should chang...
May 2, 5:55 pm 2008
Jesse Barnes
Re: [git head] Should X86_PAT really default to yes?
More recent versions of X will use sysfs rather than /dev/mem (though we're still using the mprotect hack there to give us UC-), so yeah this warning should already be gone in more recent builds. Jesse --
May 2, 6:07 pm 2008
Jacek Luczak
[ALSA] [regression] No sound on ALC861 Analog with current git
Hi Takashi, I've found that my sound card is muted with current git: it's recognized, controls are set correctly, etc., but there's no sound in speakers. I've bisected it down and found that this issue was caused by: commit f6c7e5461e9046445d50c5c7a9a4587824239623 [ALSA] hda-codec - Fix auto-configuration of Realtek codecs This patch fixes some bugs in the auto-configurator of Realtek codecs: - add missing pin set-up for speaker pins - fix the speaker auto-mute function not to conflict with ...
May 2, 3:15 pm 2008
Harvey Harrison
[PATCH 14/14] net: use get/put_unaligned_* helpers
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- net/bridge/br_stp_bpdu.c | 4 ++-- net/core/filter.c | 4 ++-- net/ipv4/cipso_ipv4.c | 18 ++++++++---------- net/ipv4/tcp_input.c | 18 +++++++++--------- 4 files changed, 21 insertions(+), 23 deletions(-) diff --git a/net/bridge/br_stp_bpdu.c b/net/bridge/br_stp_bpdu.c index 8deab64..ddeb6e5 100644 --- a/net/bridge/br_stp_bpdu.c +++ b/net/bridge/br_stp_bpdu.c @@ -58,12 +58,12 @@ static inline void br...
May 2, 3:05 pm 2008
David Miller
Re: [PATCH 14/14] net: use get/put_unaligned_* helpers
From: Harvey Harrison <harvey.harrison@gmail.com> Applied. --
May 2, 7:26 pm 2008
Harvey Harrison
[PATCH 13/14] wireless: use get/put_unaligned_* helpers
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- net/mac80211/mesh_hwmp.c | 2 +- net/wireless/radiotap.c | 16 +++++++--------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c index 3df8092..2368973 100644 --- a/net/mac80211/mesh_hwmp.c +++ b/net/mac80211/mesh_hwmp.c @@ -26,7 +26,7 @@ static inline u32 u32_field_get(u8 *preq_elem, int offset, bool ae) { if (ae) offset += 6; - return le32_to_cp...
May 2, 3:05 pm 2008
Harvey Harrison
[PATCH 12/14] bluetooth: use get/put_unaligned_* helpers
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Acked-by: Marcel Holtmann <marcel@holtmann.org> --- net/bluetooth/bnep/core.c | 8 ++++---- net/bluetooth/hci_event.c | 9 ++++----- net/bluetooth/hci_sock.c | 2 +- net/bluetooth/l2cap.c | 2 +- 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c index 347e935..f85d946 100644 --- a/net/bluetooth/bnep/core.c +++ b/net/bluetooth/bnep/core.c @...
May 2, 3:05 pm 2008
David Miller
Re: [PATCH 12/14] bluetooth: use get/put_unaligned_* helpers
From: Harvey Harrison <harvey.harrison@gmail.com> Applied. --
May 2, 7:25 pm 2008
Harvey Harrison
[PATCH 11/14] lzo: use get/put_unaligned_* helpers
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- lib/lzo/lzo1x_decompress.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/lzo/lzo1x_decompress.c b/lib/lzo/lzo1x_decompress.c index 77f0f9b..5dc6b29 100644 --- a/lib/lzo/lzo1x_decompress.c +++ b/lib/lzo/lzo1x_decompress.c @@ -138,8 +138,7 @@ match: t += 31 + *ip++; } m_pos = op - 1; - m_pos -= le16_to_cpu(get_unaligned( - (const unsigned short *)ip)) >> 2; + ...
May 2, 3:05 pm 2008
Harvey Harrison
[PATCH 10/14] include: use get/put_unaligned_* helpers
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- include/linux/reiserfs_fs.h | 4 ++-- include/linux/smb_fs.h | 19 +++++++------------ include/net/ieee80211_radiotap.h | 2 +- 3 files changed, 10 insertions(+), 15 deletions(-) diff --git a/include/linux/reiserfs_fs.h b/include/linux/reiserfs_fs.h index 4aacaee..e9963af 100644 --- a/include/linux/reiserfs_fs.h +++ b/include/linux/reiserfs_fs.h @@ -526,8 +526,8 @@ struct item_head { ** p is the array ...
May 2, 3:05 pm 2008
Harvey Harrison
[PATCH 09/14] hid: use get/put_unaligned_* helpers
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- drivers/hid/hid-core.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index f43d6d3..426ac5a 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -780,7 +780,7 @@ static __inline__ __u32 extract(__u8 *report, unsigned offset, unsigned n) */ static __inline__ void implement(__u8 *report, unsigned offset, unsigned n, __u32 value) ...
May 2, 3:05 pm 2008
Harvey Harrison
[PATCH 08/14] irda: use get_unaligned_* helpers
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- net/irda/iriap.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/net/irda/iriap.c b/net/irda/iriap.c index 9e15c82..4a105dc 100644 --- a/net/irda/iriap.c +++ b/net/irda/iriap.c @@ -451,12 +451,14 @@ static void iriap_getvaluebyclass_confirm(struct iriap_cb *self, n = 2; /* Get length, MSB first */ - len = be16_to_cpu(get_unaligned((__be16 *)(fp+n))); n += 2; + len = get_unaligned_be16(fp...
May 2, 3:05 pm 2008
David Miller
Re: [PATCH 08/14] irda: use get_unaligned_* helpers
From: Harvey Harrison <harvey.harrison@gmail.com> Applied. --
May 2, 7:21 pm 2008
Harvey Harrison
[PATCH 07/14] fs: ldm.[ch] use get_unaligned_* helpers
Replace the private BE16/BE32/BE64 macros with direct calls to get_unaligned_be16/32/64. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- fs/partitions/ldm.c | 70 +++++++++++++++++++++++++------------------------- fs/partitions/ldm.h | 5 --- 2 files changed, 35 insertions(+), 40 deletions(-) diff --git a/fs/partitions/ldm.c b/fs/partitions/ldm.c index 0fdda2e..8652fb9 100644 --- a/fs/partitions/ldm.c +++ b/fs/partitions/ldm.c @@ -133,17 +133,17 @@ static bool ldm_p...
May 2, 3:05 pm 2008
previous daytodaynext day
May 1, 2008May 2, 2008May 3, 2008