login
Header Space

 
 

Re: [PATCH] Driver for IXP4xx built-in Ethernet ports

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jeff Garzik <jeff@...>
Cc: <linux-kernel@...>, <netdev@...>
Date: Friday, May 2, 2008 - 6:09 pm

Jeff Garzik <jeff@garzik.org> writes:


Thanks.

They (#ifdef __ARMEB__) are indeed very ugly but I don't know how to
clean them, except by splitting the driver into two (which is worse).

The most used things are #defined and then used without those
__ARMEB__ checks.

Duplicating those functions is effectively splitting into two :-(

Well, perhaps Intel could give us firmware which could convert LE-BE
on the fly while TX/RX, that would make the LE code go away.
Binary-only :-(

OTOH I could convert #if* DEBUG_*, I will look at it.
-- 
Krzysztof Halasa
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Driver for IXP4xx built-in Ethernet ports, Krzysztof Halasa, (Sun Apr 20, 1:06 pm)
Re: [PATCH] Driver for IXP4xx built-in Ethernet ports, Jeff Garzik, (Tue Apr 29, 2:01 am)
Re: [PATCH] Driver for IXP4xx built-in Ethernet ports, Krzysztof Halasa, (Fri May 2, 6:09 pm)
Re: [PATCH] Driver for IXP4xx built-in Ethernet ports, Krzysztof Halasa, (Mon Apr 28, 5:16 am)
Re: [PATCH] Driver for IXP4xx built-in Ethernet ports, Martin Michlmayr, (Sat Apr 26, 5:29 am)
Re: [PATCH] Driver for IXP4xx built-in Ethernet ports, Mikael Pettersson, (Sat Apr 26, 6:16 am)
speck-geostationary