login
Header Space

 
 

Re: [PATCH] via-rhine: suspend/resume bugfix

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Pavel Machek <pavel@...>
Cc: Ondrej Zajicek <santiago@...>, Jiri Slaby <jirislaby@...>, <akpm@...>, <linux-kernel@...>, <netdev@...>, <rl@...>
Date: Friday, May 2, 2008 - 4:57 pm

On Fri, May 02, 2008 at 10:32:46PM +0200, Pavel Machek wrote:

IRQ line is not neccessary (i hope), but the patch puts this to
suspend path:

/* Switch to loopback mode to avoid hardware races. */
iowrite8(rp->tx_thresh | 0x02, ioaddr + TxConfig);

/* Disable interrupts by clearing the interrupt mask. */
iowrite16(0x0000, ioaddr + IntrEnable);

/* Stop the chip's Tx and Rx processes. */
iowrite16(CmdStop, ioaddr + ChipCmd);

(this was copied from shutdown path of the driver)

I suppose that the first one might break WoL. Unfortunately
on my hardware the WoL don't work even without the patch.

-- 
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] via-rhine: suspend/resume bugfix, Ondrej Zajicek, (Sun Apr 27, 3:13 am)
Re: [PATCH] via-rhine: suspend/resume bugfix, Jiri Slaby, (Sun Apr 27, 4:59 am)
Re: [PATCH] via-rhine: suspend/resume bugfix, Ondrej Zajicek, (Sun Apr 27, 5:58 am)
Re: [PATCH] via-rhine: suspend/resume bugfix, Pavel Machek, (Fri May 2, 4:32 pm)
Re: [PATCH] via-rhine: suspend/resume bugfix, Ondrej Zajicek, (Fri May 2, 4:57 pm)
speck-geostationary