On Fri, 2008-05-02 at 20:53 +0200, Frans Pop wrote:
Hm. I enabled group scheduling, with Peter's patch + revert of the
commit that is giving me grief + the below, and it seems to work ok
here. Definitely no sound skips even under quite hefty load.
The below _seems_ to make a difference stand-alone, but subjective
things like 'lurches' require _very_ much testing... you tend to see
what you want to see with such things. As you can see, I thought about
submitting it, but I have way too much subjective poison in my system
from testing this and that while reading source.
Fix undesirable rq.clock update noops.
Signed-off-by: Mike Galbraith <efault@gmx.de>
Index: linux-2.6.26.git/kernel/sched.c
===================================================================
--- linux-2.6.26.git.orig/kernel/sched.c
+++ linux-2.6.26.git/kernel/sched.c
@@ -668,9 +668,6 @@ static void __update_rq_clock(struct rq
s64 delta = now - prev_raw;
u64 clock = rq->clock;
-#ifdef CONFIG_SCHED_DEBUG
- WARN_ON_ONCE(cpu_of(rq) != smp_processor_id());
-#endif
/*
* Protect against sched_clock() occasionally going backwards:
*/
@@ -3009,8 +3006,8 @@ static void double_rq_lock(struct rq *rq
spin_lock(&rq1->lock);
}
}
- update_rq_clock(rq1);
- update_rq_clock(rq2);
+ __update_rq_clock(rq1);
+ __update_rq_clock(rq2);
}
/*
@@ -3860,7 +3857,7 @@ redo:
/* Attempt to move tasks */
double_lock_balance(this_rq, busiest);
/* this_rq->clock is already updated */
- update_rq_clock(busiest);
+ __update_rq_clock(busiest);
ld_moved = move_tasks(this_rq, this_cpu, busiest,
imbalance, sd, CPU_NEWLY_IDLE,
&all_pinned);
@@ -3959,8 +3956,8 @@ static void active_load_balance(struct r
/* move a task from busiest_rq to target_rq */
double_lock_balance(busiest_rq, target_rq);
- update_rq_clock(busiest_rq);
- update_rq_clock(target_rq);
+ __update_rq_clock(busiest_rq);
+ __update_rq_clock(target_rq);
/* Search for an sd spanning us and the target CPU. */
for_each_domain(target_cpu, sd) {
Index: linux-2.6.26.git/kernel/sched_fair.c
===================================================================
--- linux-2.6.26.git.orig/kernel/sched_fair.c
+++ linux-2.6.26.git/kernel/sched_fair.c
@@ -1221,7 +1221,7 @@ static void check_preempt_wakeup(struct
int se_depth, pse_depth;
if (unlikely(rt_prio(p->prio))) {
- update_rq_clock(rq);
+ __update_rq_clock(rq);
update_curr(cfs_rq);
resched_task(curr);
return;
--