Re: huge gcc 4.1.{0,1} __weak problem

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Venki Pallipadi <venkatesh.pallipadi@...>
Cc: Tom Rini <trini@...>, Andrew Morton <akpm@...>, <bunk@...>, <davem@...>, <mingo@...>, <tglx@...>, <hpa@...>, <linux-kernel@...>, <suresh.b.siddha@...>
Date: Thursday, May 1, 2008 - 8:34 pm

On Thu, 1 May 2008, Venki Pallipadi wrote:

Is it always about inlining? If so, can't we add a __noinline__ to the 
declaration of __weak?

Something like this oneliner?

		Linus

---
 include/linux/compiler-gcc.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 5c8351b..4061fc7 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -41,7 +41,7 @@
 
 #define __deprecated			__attribute__((deprecated))
 #define __packed			__attribute__((packed))
-#define __weak				__attribute__((weak))
+#define __weak				__attribute__((weak)) noinline
 #define __naked				__attribute__((naked))
 #define __noreturn			__attribute__((noreturn))
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] /dev/mem gcc weak function workaround, Venki Pallipadi, (Tue Apr 29, 9:31 pm)
Re: [PATCH] /dev/mem gcc weak function workaround, David Miller, (Wed Apr 30, 12:28 am)
RE: [PATCH] /dev/mem gcc weak function workaround, Pallipadi, Venkatesh, (Wed Apr 30, 8:49 am)
huge gcc 4.1.{0,1} __weak problem, Adrian Bunk, (Thu May 1, 5:56 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Jeremy Fitzhardinge, (Fri May 2, 5:09 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Adrian Bunk, (Fri May 2, 5:19 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Andrew Morton, (Thu May 1, 6:20 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Linus Torvalds, (Thu May 1, 6:27 pm)
[2.6.26 patch] #error for gcc 4.1.{0,1}, Adrian Bunk, (Thu Jun 26, 6:37 am)
Re: huge gcc 4.1.{0,1} __weak problem, David Miller, (Thu May 1, 6:51 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Venki Pallipadi, (Thu May 1, 6:35 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Tom Rini, (Thu May 1, 7:23 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Andrew Morton, (Thu May 1, 6:42 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Tom Rini, (Thu May 1, 7:21 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Venki Pallipadi, (Thu May 1, 7:30 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Linus Torvalds, (Thu May 1, 8:34 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Suresh Siddha, (Thu May 1, 8:39 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Jeremy Fitzhardinge, (Fri May 2, 5:11 pm)
Re: huge gcc 4.1.{0,1} __weak problem, David Miller, (Fri May 2, 6:02 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Jakub Jelinek, (Thu May 1, 6:49 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Andrew Morton, (Thu May 1, 6:33 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Tom Rini, (Thu May 1, 7:24 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Andrew Morton, (Thu May 1, 7:59 pm)
Re: huge gcc 4.1.{0,1} __weak problem, Andi Kleen, (Fri May 2, 5:09 am)
Re: huge gcc 4.1.{0,1} __weak problem, Adrian Bunk, (Fri May 2, 4:10 am)
Re: huge gcc 4.1.{0,1} __weak problem, Vegard Nossum, (Fri May 2, 3:18 am)
Re: huge gcc 4.1.{0,1} __weak problem, Theodore Tso, (Fri May 2, 9:43 am)
Re: huge gcc 4.1.{0,1} __weak problem, Justin Mattock, (Thu May 1, 8:21 pm)
Re: [PATCH] /dev/mem gcc weak function workaround, Tom Rini, (Wed Apr 30, 4:15 pm)