Re: [PATCH] capabilities: add bounding set to /proc/self/status

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Serge E. Hallyn <serue@...>
Cc: lkml <linux-kernel@...>, <linux-security-module@...>, Michael Kerrisk <mtk.manpages@...>
Date: Thursday, May 1, 2008 - 8:34 pm

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Acked-by: Andrew G. Morgan <morgan@kernel.org>

Cheers

Andrew

Serge E. Hallyn wrote:
| There is currently no way to query the bounding set of another
| task.  As there appears to be no security reason not to, and
| as Michael Kerrisk points out the following valid reasons to do
| so exist:
|
| * consistency (I can see all of the other per-thread/process sets in
| /proc/.../status)
| * debugging -- I could imagine that it would make the job of debugging
| an application that uses capabilities a little simpler.
|
| this patch adds the bounding set to /proc/self/status right after
| the effective set.
|
| If at all possible (and if acked by Andrew Morgan) it would be nice to
| get this into the 2.6.26 cycle.  But I realize it probably is too late
| for that.
|
| Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
| Acked-by: Michael Kerrisk <mtk.manpages@gmail.com>
| ---
|  fs/proc/array.c |    1 +
|  1 files changed, 1 insertions(+), 0 deletions(-)
|
| diff --git a/fs/proc/array.c b/fs/proc/array.c
| index c135cbd..160dd4a 100644
| --- a/fs/proc/array.c
| +++ b/fs/proc/array.c
| @@ -297,6 +297,7 @@ static inline void task_cap(struct seq_file *m,
struct task_struct *p)
|  	render_cap_t(m, "CapInh:\t", &p->cap_inheritable);
|  	render_cap_t(m, "CapPrm:\t", &p->cap_permitted);
|  	render_cap_t(m, "CapEff:\t", &p->cap_effective);
| +	render_cap_t(m, "CapBnd:\t", &p->cap_bset);
|  }
|
|  static inline void task_context_switch_counts(struct seq_file *m,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFIGmGn+bHCR3gb8jsRAlufAJ0eheUXQ1xvB8HofY3KbPIUHqSUXQCeOQf2
pZBx38zkUe7nviE7Z77ns3k=
=lPd5
-----END PGP SIGNATURE-----
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] capabilities: add bounding set to /proc/self/sta..., Andrew G. Morgan, (Thu May 1, 8:34 pm)