Home » Mailing list archives » linux-kernel » 2008 » May » 19

Re: [PATCH, RFC] Char dev BKL pushdown v2

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roland Dreier <rdreier@...>
To: Jonathan Corbet <corbet@...>
Cc: Linus Torvalds <torvalds@...>, Ingo Molnar <mingo@...>, Andrew Morton <akpm@...>, Peter Zijlstra <a.p.zijlstra@...>, Thomas Gleixner <tglx@...>, Alan Cox <alan@...>, Alexander Viro <viro@...>, <linux-kernel@...>, Stephen Rothwell <sfr@...>
Subject: Re: [PATCH, RFC] Char dev BKL pushdown v2
Date: Monday, May 19, 2008 - 4:38 pm

> If you're sure that this code doesn't need the BKL (and it kind of
 > looked that way to me), the preferred approach seems to be to put in a
 > comment to that effect so that it's clear that the code has been looked
 > at.  So sending me a patch which does this would be great.

OK, will send such a patch after auditing more carefully.  Just to be
very clear, the issue is to make sure the locking is sufficient to
protect against multiple racing open calls to the same character device?

 - R.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH, RFC] Char dev BKL pushdown v2, Jonathan Corbet, (Sun May 18, 6:15 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Stefan Richter, (Mon May 19, 1:46 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Stefan Richter, (Mon May 19, 3:27 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Stefan Richter, (Mon May 19, 4:07 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Ingo Molnar, (Mon May 19, 9:17 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Stephen Rothwell, (Mon May 19, 12:03 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2 , Jonathan Corbet, (Mon May 19, 9:46 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Roland Dreier, (Mon May 19, 12:00 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2 , Jonathan Corbet, (Mon May 19, 9:37 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Roland Dreier, (Mon May 19, 4:38 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2 , Jonathan Corbet, (Mon May 19, 4:42 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Roland Dreier, (Mon May 19, 6:18 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Alan Cox, (Tue May 20, 4:26 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2 , Jonathan Corbet, (Mon May 19, 6:56 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Jeff Dike, (Mon May 19, 10:10 pm)