Re: [PATCH, RFC] Char dev BKL pushdown v2

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jonathan Corbet <corbet@...>
Cc: Linus Torvalds <torvalds@...>, Ingo Molnar <mingo@...>, Andrew Morton <akpm@...>, Peter Zijlstra <a.p.zijlstra@...>, Thomas Gleixner <tglx@...>, Alan Cox <alan@...>, Alexander Viro <viro@...>, <linux-kernel@...>, Stephen Rothwell <sfr@...>
Date: Monday, May 19, 2008 - 12:00 am

Great work, Jon!  It's really cool to see some real momentum towards
getting rid of the BKL at last.

 >  drivers/infiniband/core/ucm.c                |    2 +
 >  drivers/infiniband/core/user_mad.c           |    7 ++++
 >  drivers/infiniband/core/uverbs_main.c        |    9 ++++--
 >  drivers/infiniband/hw/ipath/ipath_file_ops.c |    2 +

All of these changes look fine from a pure "push the BKL down" point of
view.  However I am 99% sure no BKL use is required in any of these (and
I will think deeper to get another .9% surer tomorrow).

Is the plan that we have a pure "push the BKL down" changeset merged,
and then I can merge BKL removal patches for these places that never
needed the BKL?  (I guess I can send you such a patch to base on top of
your tree for when Linus pulls it?  Is 2.6.27 the plan?)  The
alternative is to never add the BKL to these places as part of this
patch -- which seems to be a bad, risky plan, since if any mistakes are
made, then bisection just lands on some giant patch.

Thanks,
  Roland
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH, RFC] Char dev BKL pushdown v2, Jonathan Corbet, (Sun May 18, 6:15 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Stefan Richter, (Mon May 19, 1:46 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Stefan Richter, (Mon May 19, 3:27 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Stefan Richter, (Mon May 19, 4:07 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Ingo Molnar, (Mon May 19, 9:17 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Stephen Rothwell, (Mon May 19, 12:03 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2 , Jonathan Corbet, (Mon May 19, 9:46 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Roland Dreier, (Mon May 19, 12:00 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2 , Jonathan Corbet, (Mon May 19, 9:37 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Roland Dreier, (Mon May 19, 4:38 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2 , Jonathan Corbet, (Mon May 19, 4:42 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Roland Dreier, (Mon May 19, 6:18 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Alan Cox, (Tue May 20, 4:26 am)
Re: [PATCH, RFC] Char dev BKL pushdown v2 , Jonathan Corbet, (Mon May 19, 6:56 pm)
Re: [PATCH, RFC] Char dev BKL pushdown v2, Jeff Dike, (Mon May 19, 10:10 pm)