============================================= [ INFO: possible recursive locking detected ] 2.6.26-rc2-mm1 #8 --------------------------------------------- swapper/1 is trying to acquire lock: (&cls->mutex){--..}, at: [<c02a6564>] device_add+0x3ef/0x4ec but task is already holding lock: (&cls->mutex){--..}, at: [<c02a82e7>] class_for_each_device+0x29/0x95 other info that might help us debug this: 1 lock held by swapper/1: #0: (&cls->mutex){--..}, at: [<c...

OK, since the previous announcement, I've revisited all of the open() functions which didn't get lock_kernel() calls the first time around. Alan pointed out that even a completely empty open() might, in fact, need to acquire the BKL, so now they all do. Hopefully, this completes this work (at this level - there's plenty of down-pushing to do within subsystems). There's a new tree with this stuff: git://git.lwn.net/linux-2.6.git bkl-removal Stephen, might it be about time to pull this into li...

From: Christophe Jaillet <christophe.jaillet@wanadoo.fr> Hi, here is a patch against /scripts/kconfig/util.c : 1) The field 'len' of the 'gstr' structure seems to track the size of the memory already allocated for the "growable string". So the value of this field should be the same as the 'malloc()' just above, shouldn't it ? Note: this patch is based on 'linux-2.6.25.tar.bz2' Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr> --- --- linux 2.6.25/scripts...

<posted & mailed> (I've dropped akpm because the mail server doesn't like where I'm sending from with this address) Bad news - the patches all applied to 2.6.26-rc2 / current HEAD but the problem remained. The trace at the end seems slightly different though (alas I have to transcribe): BUG: unable to handle kernel paging request at e725ffac IP: [<c025fdb6>] scsi_bus_uevent+0x1/0x17 *pde = 27845163 *pte = 2725f160 Oops: 0000 [#1] DEBUG_PAGEALLOC [...] dev_uevent de...

My laptop (Dell XPS m1330, Core 2 Duo, 64bit, IWL3945) failed to associate today (the AP was *very* busy with a big long transfer). After looking in the logs I found this (full dmesg and the relevant part of syslog attached): May 18 18:59:24 blimp kernel: wlan0: RX deauthentication from 00:16:b6:ed:e7:98 (reason=7) May 18 18:59:24 blimp kernel: wlan0: deauthenticated May 18 18:59:24 blimp kernel: wlan0: RX deauthentication from 00:16:b6:ed:e7:98 (reason=7) May 18 18:59:24 blimp last message repea...

From: Geert Uytterhoeven <geert@linux-m68k.org> Update the m68k defconfigs Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- arch/m68k/configs/amiga_defconfig | 159 ++++++++++++++++++++--------------- arch/m68k/configs/apollo_defconfig | 140 +++++++++++++++++++----------- arch/m68k/configs/atari_defconfig | 143 ++++++++++++++++++++----------- arch/m68k/configs/bvme6000_defconfig | 138 +++++++++++++++++++----------- arch/m68k/configs/hp300_defconfig | 1...

From: Geert Uytterhoeven <geert@linux-m68k.org> According to the tests in do_initcalls(), the proper error code in case no device is found is -ENODEV, not -ENXIO or -EIO. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/block/amiflop.c | 6 +++--- drivers/block/z2ram.c | 2 +- drivers/input/serio/q40kbd.c | 2 +- drivers/video/amifb.c | 4 ++-- drivers/video/hpfb.c | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-...

From: Geert Uytterhoeven <geert@linux-m68k.org> The *_ISA type defines are quite generic and cause namespace conflicts (e.g. with `AMIGAHW_DECLARE(GG2_ISA)' in <asm/amigahw.h>) for some kernel configurations. Use ISA_TYPE_* to avoid such conflicts. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- arch/m68k/kernel/setup.c | 6 +++--- include/asm-m68k/io.h | 44 ++++++++++++++++++++++---------------------- 2 files changed, 25 insertions(+), 25 deletions(-) ...

From: Geert Uytterhoeven <geert@linux-m68k.org> Some network drivers do not check whether they're actually running on the correct platform, causing multi-platform kernels to crash if they are not. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/net/82596.c | 7 +++++++ drivers/net/apne.c | 3 +++ drivers/net/mac89x0.c | 3 +++ drivers/net/macmace.c | 3 +++ drivers/net/sun3lance.c | 3 +++ 5 files changed, 19 insertions(+) --- a/...

From: Geert Uytterhoeven <geert@linux-m68k.org> UIO needs m68k_mmutype: ERROR: "m68k_mmutype" [drivers/uio/uio.ko] undefined! (noticed by Christian T. Steigies) Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- arch/m68k/kernel/setup.c | 3 ++- include/asm-m68k/setup.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) --- a/arch/m68k/kernel/setup.c +++ b/arch/m68k/kernel/setup.c @@ -41,11 +41,12 @@ #endif unsigned long m68k_machtype; -unsigne...

From: Geert Uytterhoeven <geert@linux-m68k.org> m68k: Correctly handle multi-ISA at runtime in multi-platform kernels Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- arch/m68k/kernel/setup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/arch/m68k/kernel/setup.c +++ b/arch/m68k/kernel/setup.c @@ -346,17 +346,17 @@ void __init setup_arch(char **cmdline_p) /* set ISA defs early as possible */ #if defined(CONFIG_ISA) && defined(MULTI_...

From: Geert Uytterhoeven <geert@linux-m68k.org> Mark Q40/Q60 floppy support broken: arch/m68k/q40/q40ints.c: In function 'q40_irq_handler': arch/m68k/q40/q40ints.c:214: error: implicit declaration of function 'floppy_hardint' Including <asm/floppy.h> doesn't help, as it causes a lot of additional error messages (cfr. Sun 3x). Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- arch/m68k/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -...

From: Geert Uytterhoeven <geert@linux-m68k.org> When running a HP300-enabled kernel on non-HP300 hardware, a test in the early startup code jumps to the wrong label, causing a double bus fault. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- arch/m68k/kernel/head.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/m68k/kernel/head.S +++ b/arch/m68k/kernel/head.S @@ -1434,7 +1434,7 @@ L(mmu_fixup_done): #endif #ifdef CONFIG_HP300 - is_not_hp3...

From: Geert Uytterhoeven <geert@linux-m68k.org> Correct FB_HP300 dependencies: - FB_HP300 doesn't depend only on HP300, but also on DIO (which depends on HP300) - FB_HP300 does not need FB_CFB_FILLRECT Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/video/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -629,8 +629,7 @@ config FB_MAC config FB_HP300 bool - depends ...

From: Geert Uytterhoeven <geert@linux-m68k.org> Convert access_ok() from a macro to an inline function, so the compiler no longer complains about unused variables: fs/read_write.c: In function 'rw_copy_check_uvector': fs/read_write.c:556: warning: unused variable 'buf' Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- include/asm-m68k/uaccess.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/include/asm-m68k/uaccess.h +++ b/include/asm-m6...

Currently, rfkill support for read/write rfkill switches is hacked through a round-trip over the input layer and rfkill-input to let a driver sync rfkill->state to hardware changes. This is buggy and sub-optimal. It causes real problems. It is best to think of the rfkill class as supporting only write-only switches at the moment. In order to implement the read/write functionality properly: Add a get_state() hook that is called by the class every time it needs to fetch the current state of...

SW_RFKILL_ALL is the "emergency power-off all radios" input event. It must be handled, and must always do the same thing as far as the rfkill system is concerned: all transmitters are to go *immediately* offline. For safety, do NOT allow userspace to override EV_SW SW_RFKILL_ALL OFF. As long as rfkill-input is loaded, that event will *always* be processed, and it will *always* force all rfkill switches to disable all wireless transmitters, regardless of user_claim attribute or anything else. Si...

The resume handler should reset the wireless transmitter rfkill state to exactly what it was when the system was suspended. Do it, and do it using the normal routines for state change while at it. The suspend handler should force-switch the transmitter to blocked state, ignoring caches. Do it. Also take an opportunity shot to rfkill_remove_switch() and also force the transmitter to blocked state there, bypassing caches. Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br> Cc: Iv...

Use the notification chains to also send uevents, so that userspace can be notified of state changes of every rfkill switch. Userspace should use these events for OSD/status report applications and rfkill GUI frontends. HAL might want to broadcast them over DBUS, for example. It might be also useful for userspace implementations of rfkill-input, or to use HAL as the platform driver which promotes rfkill switch change events into input events (to synchronize all other switches) when necessary for ...

Currently, radios are always enabled when their rfkill interface is registered. This is not optimal, the safest state for a radio is to be offline unless the user turns it on. Add a module parameter that causes all radios to be disabled when their rfkill interface is registered. The module default is not changed so unless the parameter is used, radios will still be forced to their enabled state when they are registered. The new rfkill module parameter is called "default_state". Signed-off-by...

Rework some subdriver init and exit handlers, in order to fix some initialization error paths that were missing, or broken. Hitting those bugs should be extremely rare in the real world, but should that happen, thinkpad-acpi would fail to dealocate some resources and a reboot might well be needed to be able to load the driver again. Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br> --- drivers/misc/thinkpad_acpi.c | 435 ++++++++++++++++++++++-------------------- 1 files change...

rfkill really should have been named rfswitch. As it is, one can get confused whether RFKILL_STATE_ON means the KILL switch is on (and therefore, the radio is being *blocked* from operating), or whether it means the RADIO rf output is on. Clearly state that RFKILL_STATE_ON means the radio is *unblocked* from operating (i.e. there is no rf killing going on). Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br> Cc: Ivo van Doorn <IvDoorn@gmail.com> Cc: John W. Linville <linv...

The less tested codepaths for LED handling, used on ThinkPads 570, 600e/x, 770e, 770x, A21e, A2xm/p, T20-22, X20 and maybe a few others, would write data to kernel memory it had no business touching, for leds number 3 and above. If one is lucky, that illegal write would cause an OOPS, but chances are it would silently corrupt a byte. The problem was introduced in commit af116101, "ACPI: thinkpad-acpi: add sysfs led class support to thinkpad leds (v3.2)". Fix the bug by refactoring the entire cod...

Hi, This patch series unifies ATAPI support present in ide-{floppy,tape,scsi} device drivers and moves it out to the core IDE code (new ide-atapi.c file). In the process many bugs were shaken out and ~300 LOC were removed. diffstat: drivers/ide/Kconfig | 6 drivers/ide/Makefile | 1 drivers/ide/ide-atapi.c | 296 ++++++++++++++++++++++ drivers/ide/ide-cd.c | 5 drivers/ide/ide-floppy.c | 431 +++++++------------------------- drivers/ide/ide-tape.c | 630 ++...

Read Status Register before stopping DMA engine to match ide-tape device driver - it should be safe and shouldn't affect anything. This is a preparation for adding generic ide_pc_intr() helper. Cc: Borislav Petkov <petkovbb@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/ide-floppy.c | 6 +++--- drivers/scsi/ide-scsi.c | 7 ++++--- 2 files changed, 7 insertions(+), 6 deletions(-) Index: b/drivers/ide/ide-floppy.c ==================...