login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
18
Re: [PATCH 2/6] ERR_PTR: add ERR_OR_0_PTR
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Johannes Weiner
Subject:
Re: [PATCH 2/6] ERR_PTR: add ERR_OR_0_PTR
Date: Sunday, May 18, 2008 - 4:04 pm
Hi Marcin, Marcin Slusarz <marcin.slusarz@gmail.com> writes:
quoted text
> Some codepaths call ERR_PTR with possibly 0 argument, which is not > a valid errno and rely on conversion from 0 to NULL pointer. > Add ERR_OR_0_PTR function which accepts errnos and 0 as an argument. > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > --- > include/linux/err.h | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/include/linux/err.h b/include/linux/err.h > index 7b5daa6..cdec8b6 100644 > --- a/include/linux/err.h > +++ b/include/linux/err.h > @@ -26,6 +26,13 @@ static inline void *__ERR_PTR(long error) > > #define ERR_PTR(error) (BUILD_BUG_ON(__builtin_constant_p(error) && !IS_ERR_VALUE(error)), __ERR_PTR(error)) > > +static inline void *__ERR_OR_0_PTR(long error) > +{ > + return (void *) error; > +} > + > +#define ERR_OR_0_PTR(error) (BUILD_BUG_ON(__builtin_constant_p(error) && error && !IS_ERR_VALUE(error)), __ERR_OR_0_PTR(error))
ERR_OR_0_PTR could use __ERR_PTR() too. And please break those lines ;) Hannes --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] let ERR_PTR BUILD_BUG_ON when we know its argument ...
, Marcin Slusarz
, (Sun May 11, 1:12 pm)
Re: [PATCH] let ERR_PTR BUILD_BUG_ON when we know its argu ...
, Andrew Morton
, (Mon May 12, 4:38 pm)
Re: [PATCH] let ERR_PTR BUILD_BUG_ON when we know its argu ...
, Marcin Slusarz
, (Tue May 13, 1:18 pm)
[PATCH 0/6] Sanity checks for ERR_PTR argument
, Marcin Slusarz
, (Sun May 18, 2:56 pm)
[PATCH 1/6] ERR_PTR: if errno value is known at compile ti ...
, Marcin Slusarz
, (Sun May 18, 2:56 pm)
[PATCH 2/6] ERR_PTR: add ERR_OR_0_PTR
, Marcin Slusarz
, (Sun May 18, 3:01 pm)
[PATCH 3/6] vfs: open_exec cleanup
, Marcin Slusarz
, (Sun May 18, 3:01 pm)
[PATCH 4/6] procfs: switch ERR_PTR to ERR_OR_0_PTR when "e ...
, Marcin Slusarz
, (Sun May 18, 3:03 pm)
[PATCH 5/6] vfs: fix ERR_PTR abuse in generic_readlink
, Marcin Slusarz
, (Sun May 18, 3:03 pm)
[PATCH 6/6] ERR_PTR: warn when ERR_PTR parameter is not er ...
, Marcin Slusarz
, (Sun May 18, 3:04 pm)
Re: [PATCH 2/6] ERR_PTR: add ERR_OR_0_PTR
, Johannes Weiner
, (Sun May 18, 4:04 pm)
Re: [PATCH 6/6] ERR_PTR: warn when ERR_PTR parameter is no ...
, Johannes Weiner
, (Sun May 18, 4:13 pm)
Re: [PATCH 3/6] vfs: open_exec cleanup
, Christoph Hellwig
, (Sun May 18, 10:53 pm)
Re: [PATCH 2/6] ERR_PTR: add ERR_OR_0_PTR
, Christoph Hellwig
, (Sun May 18, 10:55 pm)
Re: [PATCH 2/6] ERR_PTR: add ERR_OR_0_PTR
, Al Viro
, (Sun May 18, 11:33 pm)
Re: [PATCH 1/6] ERR_PTR: if errno value is known at compil ...
, Alexey Dobriyan
, (Sun May 18, 11:38 pm)
Re: [PATCH 6/6] ERR_PTR: warn when ERR_PTR parameter is no ...
, Alexey Dobriyan
, (Sun May 18, 11:43 pm)
Re: [PATCH 6/6] ERR_PTR: warn when ERR_PTR parameter is no ...
, Johannes Weiner
, (Mon May 19, 5:11 am)
Re: [PATCH 3/6] vfs: open_exec cleanup
, Marcin Slusarz
, (Thu May 22, 8:57 am)
Re: [PATCH 1/6] ERR_PTR: if errno value is known at compil ...
, Marcin Slusarz
, (Thu May 22, 9:03 am)
Re: [PATCH 6/6] ERR_PTR: warn when ERR_PTR parameter is no ...
, Marcin Slusarz
, (Thu May 22, 9:08 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Mel Gorman
Re: [PATCH 1/4] vmstat: remove zone->lock from walk_zones_in_node
Guenter Roeck
Re: [lm-sensors] Location for thermal drivers
David Woodhouse
Re: RFC: Moving firmware blobs out of the kernel.
Siddha, Suresh B
Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU k...
Peter Zijlstra
Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)
git-commits-head
:
Linux Kernel Mailing List
[MIPS] Fix potential latency problem due to non-atomic cpu_wait.
Linux Kernel Mailing List
USB: rename USB_SPEED_VARIABLE to USB_SPEED_WIRELESS
Linux Kernel Mailing List
lib/vsprintf.c: fix bug omitting minus sign of numbers (module_param)
Linux Kernel Mailing List
[Bluetooth] Initiate authentication during connection establishment
Linux Kernel Mailing List
[POWERPC] 4xx: Add ppc40x_defconfig
linux-netdev
:
MERCEDES
Your mail id has won 950,000.00 in the MERCEDES Benz Online Promo.for claims send:
David Miller
Re: [PATCH] xen/netfront: do not mark packets of length < MSS as GSO
David Miller
Re: skb_segment() questions
Shan Wei
[RFC PATCH net-next 2/5]IPv6:netfilter: Send an ICMPv6 "Fragment Reassembly Timeou...
Stanislaw Gruszka
[PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
git
:
Nicolas Sebrecht
git-svn died of signal 11 (was "3 failures on test t9100 (svn)")
Junio C Hamano
Re: [PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
Martin Langhoff
Re: [PATCH] GIT commit statistics.
Alexandre Julliard
[PATCH] gitweb: Put back shortlog instead of graphiclog in the project list.
Josh Triplett
[PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
openbsd-misc
:
Taisto Qvist XX
Re: AMD GEODE LX-800 just works with kernel from install42.iso and kernelpanics wi...
Nico Meijer
Re: gOS Develop Kit with VIA pc-1 Processor Platform VIA C7-D
Andreas Bihlmaier
Re: jetway board sensors (Fintek F71805F)
admin
Drive a 2009 car from R799p/m
Antti Harri
Re: how to create a sha256 hash
Colocation donated by:
Syndicate