[PATCH 20/40] ide-{floppy,tape}: merge pc->idefloppy_callback and pc->idetape_callback

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Bartlomiej Zolnierkiewicz
Date: Sunday, May 18, 2008 - 11:57 am

Merge pc->idefloppy_callback and pc->idetape_callback into pc->callback.

There should be no functional changes caused by this patch.

Cc: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-floppy.c |    6 +++---
 drivers/ide/ide-tape.c   |    8 ++++----
 include/linux/ide.h      |    4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)

Index: b/drivers/ide/ide-floppy.c
===================================================================
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -354,7 +354,7 @@ static void idefloppy_init_pc(struct ide
 	pc->req_xfer = 0;
 	pc->buf = pc->pc_buf;
 	pc->buf_size = IDEFLOPPY_PC_BUFFER_SIZE;
-	pc->idefloppy_callback = &ide_floppy_callback;
+	pc->callback = ide_floppy_callback;
 }
 
 static void idefloppy_create_request_sense_cmd(struct ide_atapi_pc *pc)
@@ -438,7 +438,7 @@ static ide_startstop_t idefloppy_pc_intr
 		if (floppy->failed_pc == pc)
 			floppy->failed_pc = NULL;
 		/* Command finished - Call the callback function */
-		pc->idefloppy_callback(drive);
+		pc->callback(drive);
 		return ide_stopped;
 	}
 
@@ -612,7 +612,7 @@ static ide_startstop_t idefloppy_issue_p
 		pc->error = IDEFLOPPY_ERROR_GENERAL;
 
 		floppy->failed_pc = NULL;
-		pc->idefloppy_callback(drive);
+		pc->callback(drive);
 		return ide_stopped;
 	}
 
Index: b/drivers/ide/ide-tape.c
===================================================================
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -687,7 +687,7 @@ static void idetape_init_pc(struct ide_a
 	pc->buf_size = IDETAPE_PC_BUFFER_SIZE;
 	pc->bh = NULL;
 	pc->b_data = NULL;
-	pc->idetape_callback = ide_tape_callback;
+	pc->callback = ide_tape_callback;
 }
 
 static void idetape_create_request_sense_cmd(struct ide_atapi_pc *pc)
@@ -841,7 +841,7 @@ static ide_startstop_t idetape_pc_intr(i
 		if (tape->failed_pc == pc)
 			tape->failed_pc = NULL;
 		/* Command finished - Call the callback function */
-		pc->idetape_callback(drive);
+		pc->callback(drive);
 		return ide_stopped;
 	}
 
@@ -1034,7 +1034,7 @@ static ide_startstop_t idetape_issue_pc(
 			pc->error = IDETAPE_ERROR_GENERAL;
 		}
 		tape->failed_pc = NULL;
-		pc->idetape_callback(drive);
+		pc->callback(drive);
 		return ide_stopped;
 	}
 	debug_log(DBG_SENSE, "Retry #%d, cmd = %02X\n", pc->retries, pc->c[0]);
@@ -1120,7 +1120,7 @@ static ide_startstop_t idetape_media_acc
 		pc->error = IDETAPE_ERROR_GENERAL;
 		tape->failed_pc = NULL;
 	}
-	pc->idetape_callback(drive);
+	pc->callback(drive);
 	return ide_stopped;
 }
 
Index: b/include/linux/ide.h
===================================================================
--- a/include/linux/ide.h
+++ b/include/linux/ide.h
@@ -625,8 +625,8 @@ struct ide_atapi_pc {
 	 * to change/removal later.
 	 */
 	u8 pc_buf[256];
-	void (*idefloppy_callback) (ide_drive_t *);
-	void (*idetape_callback) (ide_drive_t *);
+
+	void (*callback)(ide_drive_t *);
 
 	/* idetape only */
 	struct idetape_bh *bh;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/40] ide: generic ATAPI support, Bartlomiej Zolnierki ..., (Sun May 18, 11:54 am)
[PATCH 01/40] ide-scsi: fix race in idescsi_transfer_pc(), Bartlomiej Zolnierki ..., (Sun May 18, 11:54 am)
[PATCH 02/40] ide-scsi: fix DRQ checking for DMA transfers ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:54 am)
[PATCH 03/40] ide-scsi: fix handling of DMA errors in ides ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:54 am)
[PATCH 04/40] ide-scsi: fix Interrupt Reason checking in i ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:55 am)
[PATCH 05/40] ide-scsi: merge idescsi_input_buffers() and ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:55 am)
[PATCH 06/40] ide-scsi: remove superfluous BUG_ON() from i ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:55 am)
[PATCH 07/40] ide-scsi: add debug_log() macro, Bartlomiej Zolnierki ..., (Sun May 18, 11:55 am)
[PATCH 08/40] ide-tape: idetape_pc_intr() should use local ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:55 am)
[PATCH 09/40] ide-tape: remove superfluous error message f ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:55 am)
[PATCH 10/40] ide-tape: remove superfluous warning message ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:55 am)
[PATCH 11/40] ide-tape: remove unneeded CONFIG_BLK_DEV_IDE ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:56 am)
[PATCH 12/40] ide-tape: remove stale comments from idetape ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:56 am)
[PATCH 13/40] ide-tape: remove SIMULATE_ERRORS debug code, Bartlomiej Zolnierki ..., (Sun May 18, 11:56 am)
[PATCH 14/40] ide-floppy: merge idefloppy_transfer_pc() an ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:56 am)
[PATCH 15/40] ide-{floppy,tape,scsi}: log device name inst ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:56 am)
[PATCH 16/40] ide-tape: make idetape_retry_pc() void, Bartlomiej Zolnierki ..., (Sun May 18, 11:56 am)
[PATCH 17/40] ide-tape: merge callbacks, Bartlomiej Zolnierki ..., (Sun May 18, 11:57 am)
[PATCH 18/40] ide-tape: make pc-&gt;idetape_callback void, Bartlomiej Zolnierki ..., (Sun May 18, 11:57 am)
[PATCH 19/40] ide-floppy: merge callbacks, Bartlomiej Zolnierki ..., (Sun May 18, 11:57 am)
[PATCH 20/40] ide-{floppy,tape}: merge pc->idefloppy_callb ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:57 am)
[PATCH 21/40] ide-{floppy,tape}: PC_FLAG_DMA_RECOMMENDED - ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:57 am)
[PATCH 22/40] ide-floppy: start DMA engine in idefloppy_tr ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:57 am)
[PATCH 23/40] ide-tape: set PC_FLAG_DMA_IN_PROGRESS flag i ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:57 am)
[PATCH 24/40] ide-tape: factor out waiting for good ireaso ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:58 am)
[PATCH 25/40] ide: add PC_FLAG_ZIP_DRIVE pc flag, Bartlomiej Zolnierki ..., (Sun May 18, 11:58 am)
[PATCH 26/40] ide-{cd,floppy,tape}: remove checking for dr ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:58 am)
[PATCH 27/40] ide-scsi: set drive-&gt;scsi flag for devices h ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:58 am)
[PATCH 28/40] ide: add ide_transfer_pc() helper, Bartlomiej Zolnierki ..., (Sun May 18, 11:58 am)
[PATCH 29/40] ide-scsi: move idescsi_map_sg() call out fro ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:58 am)
[PATCH 30/40] ide: add PC_FLAG_DRQ_INTERRUPT pc flag, Bartlomiej Zolnierki ..., (Sun May 18, 11:58 am)
[PATCH 31/40] ide: add ide_issue_pc() helper, Bartlomiej Zolnierki ..., (Sun May 18, 11:59 am)
[PATCH 32/40] ide-{floppy,tape}: move checking of -&gt;failed ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:59 am)
[PATCH 33/40] ide-tape: factor out DSC handling from ideta ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:59 am)
[PATCH 34/40] ide-tape: add ide_tape_io_buffers() helper, Bartlomiej Zolnierki ..., (Sun May 18, 11:59 am)
[PATCH 35/40] ide-tape: always log debug info in idetape_p ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:59 am)
[PATCH 36/40] ide-floppy: add more debugging to idefloppy_ ..., Bartlomiej Zolnierki ..., (Sun May 18, 11:59 am)
[PATCH 37/40] ide-scsi: use pc-&gt;callback, Bartlomiej Zolnierki ..., (Sun May 18, 12:00 pm)
[PATCH 38/40] ide-scsi: add more debugging to idescsi_pc_i ..., Bartlomiej Zolnierki ..., (Sun May 18, 12:00 pm)
[PATCH 39/40] ide-{floppy,scsi}: read Status Register befo ..., Bartlomiej Zolnierki ..., (Sun May 18, 12:00 pm)
[PATCH 40/40] ide: add ide_pc_intr() helper, Bartlomiej Zolnierki ..., (Sun May 18, 12:00 pm)
Re: [PATCH 04/40] ide-scsi: fix Interrupt Reason checking ..., Borislav Petkov, (Sun May 18, 10:10 pm)
Re: [PATCH 00/40] ide: generic ATAPI support, Borislav Petkov, (Thu May 22, 12:43 am)
Re: [PATCH 00/40] ide: generic ATAPI support, Bartlomiej Zolnierki ..., (Sun May 25, 6:23 am)
Re: [PATCH 04/40] ide-scsi: fix Interrupt Reason checking ..., Bartlomiej Zolnierki ..., (Tue May 27, 11:30 am)
Re: [PATCH 14/40] ide-floppy: merge idefloppy_transfer_pc( ..., Bartlomiej Zolnierki ..., (Tue May 27, 11:57 am)
Re: [PATCH 22/40] ide-floppy: start DMA engine in ideflopp ..., Bartlomiej Zolnierki ..., (Tue May 27, 11:58 am)
Re: [PATCH 14/40] ide-floppy: merge idefloppy_transfer_pc( ..., Bartlomiej Zolnierki ..., (Thu May 29, 4:01 pm)